unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: John Doe <dftxbs3e@free.fr>
Cc: 45725@debbugs.gnu.org
Subject: [bug#45725] [PATCH] gnu: Add gutenprint.
Date: Tue, 19 Jan 2021 15:56:47 +0100	[thread overview]
Message-ID: <87eeihht5c.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210109111236.31405-1-dftxbs3e@free.fr> (John Doe's message of "Sat, 9 Jan 2021 12:12:36 +0100")

Hi,

John Doe <dftxbs3e@free.fr> skribis:

> * gnu/packages/cups.scm (gutenprint): New variable.

[...]

> +    (synopsis "Printer drivers for CUPS on GNU/Linux")

You can remove “on GNU/Linux”, it’s implicit (I don’t see how it could
be non-portable actually!).

> +    ;; Supported printers list from:
> +    ;; http://gimp-print.sourceforge.net/p_Supported_Printers.php
> +    ;; Remember to update on version bumps with this command:
> +    ;; $ curl http://gimp-print.sourceforge.net/p_Supported_Printers.php | \
> +    ;; grep -Po '(?<=^<tr><td>).+?(?=</td>)' | sed 's/^/@item /g'
> +    (description "Printer drivers for
                     ^
Please make it a full sentence, as per:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

> +CUPS on GNU/Linux, Macintosh OS X, and other POSIX-compliant operating systems.
> +This project also maintains an enhanced Print plug-in for GIMP 2.x from
> +the same code base.  This driver claims to support these printers:
> +
> +@enumerate
> +@item Canon BJ-30
> +@item Canon BJC-50

I think we shouldn’t have such lists, even with the comment above on how
to update it.  It’s not the right place for that and it would scare away
translators (who are already shy enough when it comes to translating
package descriptions :-)).

What you could do is write a sentence like:

  “This driver supports widespread inkjet printers by major vendors,
  including Canon, Epson, Fujitsu, and SONY.”  (arbitrary choice)

That way people will at least see the vendor names, but the description
remains human-readable.

Otherwise LGTM.  Could you send an updated patch?

Thanks,
Ludo’.




  reply	other threads:[~2021-01-19 15:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08 11:38 [bug#45725] [PATCH] gnu: Add gutenprint John Doe
2021-01-08 11:51 ` [bug#45725] [PATCH v2] " John Doe
2021-01-08 12:50   ` Jonathan Brielmaier
2021-01-08 12:09 ` dftxbs3e
2021-01-09 11:12 ` [bug#45725] [PATCH v3] " John Doe
2021-01-19 14:56   ` Ludovic Courtès [this message]
2021-01-20  4:04     ` [bug#45725] [PATCH] " dftxbs3e
2021-08-13 20:03 ` [bug#45725] Getting Gutenprint in Guix Faré
2021-08-13 21:38   ` Faré
2021-08-14  3:34     ` Faré
2022-02-12  9:34 ` [bug#45725] [PATCH v4] gnu: Add gutenprint Brice Waegeneire
2022-04-30 11:21 ` [bug#45725] [PATCH] " Milan Svoboda
2022-04-30 15:09 ` Milan Svoboda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeihht5c.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=45725@debbugs.gnu.org \
    --cc=dftxbs3e@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).