unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 46031@debbugs.gnu.org
Subject: [bug#46031] services: cuirass: Add "simple-cuirass-services".
Date: Mon, 22 Feb 2021 13:59:25 +0100	[thread overview]
Message-ID: <87eeh8b6mq.fsf@gnu.org> (raw)
In-Reply-To: <87k0r0iizg.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 22 Feb 2021 09:50:43 +0100")

Hi!

Mathieu Othacehe <othacehe@gnu.org> skribis:

>> I wonder if it would make sense to allow users to pass directly a
>> manifest, as in (pseudo syntax):
>>
>>   (simple-cuirass-configuration
>>     (build (list (build-manifest … (local-file "my-manifest.scm"))))
>>     (channels …))
>
> It would be nice but Cuirass doesn't support specification update for
> now. Passing a manifest this way would require to drop the database
> content at each reconfiguration.

Ah yes, that wouldn’t be convenient.

>> What about exposing ‘simple-cuirass-configuration->specs’, and document
>> it such that one can do:
>>
>>   (service cuirass-service-type
>>            (cuirass-configuration
>>              (specifications
>>               (simple-cuirass-configuration->specs config))))
>
> I agree it feels nicer, however with this service I'd like to hide the
> dependencies to postgresql-service-type and
> postgresql-role-service-type. That's why "simple-cuirass-services"
> returns three services. Maybe you see another way?

When a service extends a service type, an instance of that service type
is automatically added if it’s missing (provided that service type has a
default value).  This happens in ‘instantiate-missing-services’.

So, if postgresql-role-service-type and postgresql-service-type have a
default value, simple-cuirass-service could extend them both (possibly
with a dummy value) and it would just work.

HTH!

Ludo’.




  reply	other threads:[~2021-02-22 13:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-22  8:50 [bug#46031] services: cuirass: Add "simple-cuirass-services" Mathieu Othacehe
2021-01-22 16:37 ` Jonathan Brielmaier
2021-01-22 17:55   ` Mathieu Othacehe
2021-01-24 13:47     ` Jonathan Brielmaier
2021-01-29 11:39       ` Mathieu Othacehe
2021-02-02 22:43         ` Jonathan Brielmaier
2021-02-19 19:16           ` bug#46031: " Mathieu Othacehe
2021-02-19 21:35             ` [bug#46031] " Jonathan Brielmaier
2021-02-22  8:53               ` Mathieu Othacehe
2021-02-20 10:59 ` Ludovic Courtès
2021-02-22  8:50   ` Mathieu Othacehe
2021-02-22 12:59     ` Ludovic Courtès [this message]
2021-02-23  8:48       ` Mathieu Othacehe
2021-02-23  9:29         ` Ludovic Courtès
2021-02-23 13:30           ` Mathieu Othacehe
2021-02-23 17:42             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeh8b6mq.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=46031@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).