unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Simon Josefsson <simon@josefsson.org>
Cc: 48242@debbugs.gnu.org
Subject: [bug#48242] [PATCH] gnu: oath-toolkit: Build libpskc and pskctool.
Date: Fri, 07 May 2021 00:55:06 +0200	[thread overview]
Message-ID: <87eeejmq0l.fsf@nckx> (raw)
In-Reply-To: <87a6p82mek.fsf@latte.josefsson.org>

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

Simon,

Simon Josefsson 写道:
> Is there a lint-style tool to help me detect and/or fix that?

You're probably already aware of ‘guix lint’, but maybe not, since 
it should have detected the tabs used instead of spaces.  Please 
let me know if you did and it didn't!

The ordering isn't a hard policy, but I ‘strongly recommend’ it 
;-)

I've removed more than one duplicate input/import that would have 
been trivially caught if the lists were sorted.  In one case it 
effectively masked a version mismatch bug.  And it costs nothing 
to sort new code, and keep existing sorted lists sorted...

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2021-05-06 22:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 18:00 [bug#48242] [PATCH] gnu: oath-toolkit: Build libpskc and pskctool Simon Josefsson via Guix-patches via
2021-05-06  7:13 ` Simon Josefsson via Guix-patches via
2021-05-06  7:50 ` bug#48242: " Tobias Geerinckx-Rice via Guix-patches via
2021-05-06 10:21   ` [bug#48242] " Simon Josefsson via Guix-patches via
2021-05-06 22:55     ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeejmq0l.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=48242@debbugs.gnu.org \
    --cc=me@tobias.gr \
    --cc=simon@josefsson.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).