unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Xinglu Chen <public@yoctocell.xyz>
Cc: 49819@debbugs.gnu.org
Subject: [bug#49819] [PATCH] gnu: Add emacs-geiser-chez.
Date: Tue, 03 Aug 2021 15:01:04 -0400	[thread overview]
Message-ID: <87eeba9wun.fsf@gmail.com> (raw)
In-Reply-To: <9443b246c7d74a51435e7f0c5bbb9c6ac23af33c.1627896152.git.public@yoctocell.xyz> (Xinglu Chen's message of "Mon, 02 Aug 2021 11:23:10 +0200")

Hello,

Xinglu Chen <public@yoctocell.xyz> writes:

> * gnu/packages/emacs-xyz.scm (emacs-geiser-chez): New variable.
> ---
>  gnu/packages/emacs-xyz.scm | 43 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 43 insertions(+)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index e3b94228e1..bbda1db614 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -138,6 +138,7 @@
>    #:use-module (gnu packages aspell)
>    #:use-module (gnu packages audio)
>    #:use-module (gnu packages bash)
> +  #:use-module (gnu packages chez)
>    #:use-module (gnu packages cmake)
>    #:use-module (gnu packages code)
>    #:use-module (gnu packages cpp)
> @@ -408,6 +409,48 @@ a generic Scheme interaction mode for the GNU Emacs editor.")
>  a generic Scheme interaction mode for the GNU Emacs editor.")
>      (license license:bsd-3)))
>  
> +(define-public emacs-geiser-chez
> +  (package
> +    (name "emacs-geiser-chez")
> +    (version "0.16")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://gitlab.com/emacs-geiser/chez")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0cc1z5z5cpvxa5f3n8kvms0wxlybzcg4l1bh3rwv1l1sb0lk1xzx"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     '(#:include (cons "^src/" %default-include)
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'make-autoloads 'patch-autoloads
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (substitute* (string-append
> +                           (elpa-directory (assoc-ref outputs "out"))
> +                           "/geiser-chez-autoloads.el")
> +               ;; Activating implementations fails when Geiser is not yet
> +               ;; loaded, so let's defer that until it is.
> +               (("\\(geiser-activate-implementation .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))
> +               (("\\(geiser-implementation-extension .*\\)" all)
> +                (string-append
> +                 "(eval-after-load 'geiser-impl '" all ")"))))))))

Could you please report the above issue to upstream so that it can
properly be fixed?  And then add a reference to it in a comment in the
above package definition.

> +    (inputs
> +     `(("chez-scheme" ,chez-scheme)))
> +    (propagated-inputs
> +     `(("emacs-geiser" ,emacs-geiser)))
> +    (home-page "https://nongnu.org/geiser/")
> +    (synopsis "Support for Chez Scheme in Geiser")
> +    (description
> +     "This package adds support for using Chez Scheme in Emacs with Geiser.")
> +    (license license:bsd-3)))
> +
>  (define-public emacs-vc-hgcmd
>    (package
>      (name "emacs-vc-hgcmd")

The rest LGTM!

Thank you,

Maxim




  reply	other threads:[~2021-08-03 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  9:23 [bug#49819] [PATCH] gnu: Add emacs-geiser-chez Xinglu Chen
2021-08-03 19:01 ` Maxim Cournoyer [this message]
2021-08-04  8:14   ` Xinglu Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeba9wun.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=49819@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).