unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 47849@debbugs.gnu.org, Maxime Devos <maximedevos@telenet.be>
Subject: [bug#47849] [PATCH] Add a jami-daemon service.
Date: Tue, 03 Aug 2021 10:36:45 -0400	[thread overview]
Message-ID: <87eeba7fya.fsf@gmail.com> (raw)
In-Reply-To: <2a559e87966b2383d39ccfddbb667d67b9d21632.camel@student.tugraz.at> (Leo Prikler's message of "Tue, 03 Aug 2021 09:35:22 +0200")

Hi Leo,

[...]

>> > I did not look at the rest of this patch, but 1+2 LGTM.
>> > 
>> > Regards,
>> 
>> Thanks a lot for having a look!  It's been long in the making.
>> 
>> Pushed as commit 69dcc24c9f.
> As I said, I only looked at parts of it, so this push was perhaps a bit
> hasty.  I recently also hastily pushed something and had to fix it up
> later.  Let's try to keep a cool head and not let the heat get to us
> :)

Point taken; there was an adjustment to be made in (guix self) that I
had overlooked; the push ended up breaking 'guix pull' (I quickly
reverted and fixed it with the help of Chris Baines -- thank you!).
Letting some more time would have perhaps allowed someone to catch that
issue (or running 'make as-derivation').

Thanks again,

Maxim




      reply	other threads:[~2021-08-03 14:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <handler.47849.B47849.162151424825211@debbugs.gnu.org>
2021-08-01  6:58 ` [bug#47849] [PATCH v3] services: Add a service for the Jami daemon Maxim Cournoyer
2021-08-01  6:58   ` [bug#47849] [PATCH v3 1/3] .dir-locals.el: Specify indentation rule for with-shepherd-action Maxim Cournoyer
2021-08-01  6:58   ` [bug#47849] [PATCH v3 2/3] build: shepherd: Use autoload to lazily bind Shepherd modules Maxim Cournoyer
2021-08-01  6:58   ` [bug#47849] [PATCH v3 3/3] services: Add a service for Jami Maxim Cournoyer
2021-08-01  7:58     ` Leo Prikler
2021-08-02 19:17       ` bug#47849: [PATCH] Add a jami-daemon service Maxim Cournoyer
2021-08-03  7:35         ` [bug#47849] " Leo Prikler
2021-08-03 14:36           ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eeba7fya.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=47849@debbugs.gnu.org \
    --cc=leo.prikler@student.tugraz.at \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).