* [bug#50375] [PATCH] gnu: Add mlterm. @ 2021-09-04 16:42 iKaSeRo 2021-09-04 19:50 ` Xinglu Chen 0 siblings, 1 reply; 5+ messages in thread From: iKaSeRo @ 2021-09-04 16:42 UTC (permalink / raw) To: 50375; +Cc: iKaSeRo * gnu/packages/terminals.scm (mlterm): New variable. --- gnu/packages/terminals.scm | 40 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm index 1cdf0e1831..037504ee4f 100644 --- a/gnu/packages/terminals.scm +++ b/gnu/packages/terminals.scm @@ -25,6 +25,7 @@ ;;; Copyright © 2020 Leo Famulari <leo@famulari.name> ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be> +;;; Copyright © 2021 ikasero <ahmed@ikasero.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -66,6 +67,7 @@ #:use-module (gnu packages docbook) #:use-module (gnu packages fontutils) #:use-module (gnu packages freedesktop) + #:use-module (gnu packages fribidi) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) @@ -1458,3 +1460,41 @@ ephemeral serial ports. It features automatic port detection, port enumeration, support for non-standard baud rates, the ability to wait for ports to appear, and the ability to read and write via stdin and stdout.") (license license:expat))) + +(define-public mlterm + (package + (name "mlterm") + (version "3.9.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mlterm/01release/mlterm-" + version "/mlterm-" version ".tar.gz")) + (sha256 + (base32 + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) + (build-system gnu-build-system) + (arguments `(#:tests? #f + #:configure-flags + (list (string-append "--prefix=" (assoc-ref %outputs "out")) + "--disable-static" + "--enable-optimize-redrawing" + "--with-imagelib=gdk-pixbuf"))) + (native-inputs + `(("gettext" ,gettext-minimal) + ("pkg-config" ,pkg-config))) + (inputs + `(("cairo" ,cairo) + ("fontconfig" ,fontconfig) + ("freetype" ,freetype) + ("fribidi" ,fribidi) + ("gdk-pixbuf" ,gdk-pixbuf) + ("gtk+" ,gtk+) + ("libx11" ,libx11) + ("libxext" ,libxext) + ("libxft" ,libxft))) + (home-page "http://mlterm.sourceforge.net/") + (synopsis "Multi Lingual TERMinal emulator") + (description "mlterm is a multi-lingual terminal emulator which supports +various character sets and encodings in the world.") + (license license:bsd-3))) -- 2.33.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#50375] [PATCH] gnu: Add mlterm. 2021-09-04 16:42 [bug#50375] [PATCH] gnu: Add mlterm iKaSeRo @ 2021-09-04 19:50 ` Xinglu Chen 2021-09-05 11:31 ` [bug#50375] [PATCH v2] " iKaSeRo 0 siblings, 1 reply; 5+ messages in thread From: Xinglu Chen @ 2021-09-04 19:50 UTC (permalink / raw) To: iKaSeRo, 50375; +Cc: iKaSeRo [-- Attachment #1: Type: text/plain, Size: 3060 bytes --] On Sat, Sep 04 2021, iKaSeRo wrote: > * gnu/packages/terminals.scm (mlterm): New variable. > --- > gnu/packages/terminals.scm | 40 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm > index 1cdf0e1831..037504ee4f 100644 > --- a/gnu/packages/terminals.scm > +++ b/gnu/packages/terminals.scm > @@ -25,6 +25,7 @@ > ;;; Copyright © 2020 Leo Famulari <leo@famulari.name> > ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech> > ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be> > +;;; Copyright © 2021 ikasero <ahmed@ikasero.com> > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -66,6 +67,7 @@ > #:use-module (gnu packages docbook) > #:use-module (gnu packages fontutils) > #:use-module (gnu packages freedesktop) > + #:use-module (gnu packages fribidi) > #:use-module (gnu packages gettext) > #:use-module (gnu packages ghostscript) > #:use-module (gnu packages gl) > @@ -1458,3 +1460,41 @@ ephemeral serial ports. It features automatic port detection, port enumeration, > support for non-standard baud rates, the ability to wait for ports to appear, > and the ability to read and write via stdin and stdout.") > (license license:expat))) > + > +(define-public mlterm > + (package > + (name "mlterm") > + (version "3.9.1") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://sourceforge/mlterm/01release/mlterm-" > + version "/mlterm-" version ".tar.gz")) > + (sha256 > + (base32 > + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) > + (build-system gnu-build-system) > + (arguments `(#:tests? #f What’s the reason for disabling tests; there should be a comment with a short explanation. Nit: This is usually on its own line (arguments `(#:tests? #f #:configure-flags ...)) > + #:configure-flags > + (list (string-append "--prefix=" (assoc-ref %outputs "out")) > + "--disable-static" > + "--enable-optimize-redrawing" > + "--with-imagelib=gdk-pixbuf"))) > + (native-inputs > + `(("gettext" ,gettext-minimal) > + ("pkg-config" ,pkg-config))) > + (inputs > + `(("cairo" ,cairo) > + ("fontconfig" ,fontconfig) > + ("freetype" ,freetype) > + ("fribidi" ,fribidi) > + ("gdk-pixbuf" ,gdk-pixbuf) > + ("gtk+" ,gtk+) > + ("libx11" ,libx11) > + ("libxext" ,libxext) > + ("libxft" ,libxft))) > + (home-page "http://mlterm.sourceforge.net/") > + (synopsis "Multi Lingual TERMinal emulator") > + (description "mlterm is a multi-lingual terminal emulator which supports > +various character sets and encodings in the world.") > + (license license:bsd-3))) > -- > 2.33.0 The package builds fine, and the rest LGTM! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 861 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* [bug#50375] [PATCH v2] gnu: Add mlterm. 2021-09-04 19:50 ` Xinglu Chen @ 2021-09-05 11:31 ` iKaSeRo 2021-09-05 18:43 ` Xinglu Chen 2021-09-05 22:18 ` bug#50375: " Tobias Geerinckx-Rice via Guix-patches via 0 siblings, 2 replies; 5+ messages in thread From: iKaSeRo @ 2021-09-05 11:31 UTC (permalink / raw) To: 50375, public; +Cc: iKaSeRo * gnu/packages/terminals.scm (mlterm): New variable. --- Xinglu Chen <public@yoctocell.xyz> writes: >> * gnu/packages/terminals.scm (mlterm): New variable. >> --- >> gnu/packages/terminals.scm | 40 ++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 40 insertions(+) >> >> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm >> index 1cdf0e1831..037504ee4f 100644 >> --- a/gnu/packages/terminals.scm >> +++ b/gnu/packages/terminals.scm >> @@ -25,6 +25,7 @@ >> ;;; Copyright © 2020 Leo Famulari <leo@famulari.name> >> ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech> >> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be> >> +;;; Copyright © 2021 ikasero <ahmed@ikasero.com> >> ;;; >> ;;; This file is part of GNU Guix. >> ;;; >> @@ -66,6 +67,7 @@ >> #:use-module (gnu packages docbook) >> #:use-module (gnu packages fontutils) >> #:use-module (gnu packages freedesktop) >> + #:use-module (gnu packages fribidi) >> #:use-module (gnu packages gettext) >> #:use-module (gnu packages ghostscript) >> #:use-module (gnu packages gl) >> @@ -1458,3 +1460,41 @@ ephemeral serial ports. It features automatic port detection, port enumeration, >> support for non-standard baud rates, the ability to wait for ports to appear, >> and the ability to read and write via stdin and stdout.") >> (license license:expat))) >> + >> +(define-public mlterm >> + (package >> + (name "mlterm") >> + (version "3.9.1") >> + (source >> + (origin >> + (method url-fetch) >> + (uri (string-append "mirror://sourceforge/mlterm/01release/mlterm-" >> + version "/mlterm-" version ".tar.gz")) >> + (sha256 >> + (base32 >> + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) >> + (build-system gnu-build-system) >> + (arguments `(#:tests? #f > > What’s the reason for disabling tests; there should be a comment with a > short explanation. > Because there are no tests, Now I added a comment thanks! > Nit: This is usually on its own line > > (arguments > `(#:tests? #f > #:configure-flags > ...)) > Didn't know that, fixed >> + #:configure-flags >> + (list (string-append "--prefix=" (assoc-ref %outputs "out")) >> + "--disable-static" >> + "--enable-optimize-redrawing" >> + "--with-imagelib=gdk-pixbuf"))) >> + (native-inputs >> + `(("gettext" ,gettext-minimal) >> + ("pkg-config" ,pkg-config))) >> + (inputs >> + `(("cairo" ,cairo) >> + ("fontconfig" ,fontconfig) >> + ("freetype" ,freetype) >> + ("fribidi" ,fribidi) >> + ("gdk-pixbuf" ,gdk-pixbuf) >> + ("gtk+" ,gtk+) >> + ("libx11" ,libx11) >> + ("libxext" ,libxext) >> + ("libxft" ,libxft))) >> + (home-page "http://mlterm.sourceforge.net/") >> + (synopsis "Multi Lingual TERMinal emulator") >> + (description "mlterm is a multi-lingual terminal emulator which supports >> +various character sets and encodings in the world.") >> + (license license:bsd-3))) >> -- >> 2.33.0 > > The package builds fine, and the rest LGTM! Thanks for the review! gnu/packages/terminals.scm | 41 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm index 1cdf0e1831..4c39b41f0a 100644 --- a/gnu/packages/terminals.scm +++ b/gnu/packages/terminals.scm @@ -25,6 +25,7 @@ ;;; Copyright © 2020 Leo Famulari <leo@famulari.name> ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be> +;;; Copyright © 2021 ikasero <ahmed@ikasero.com> ;;; ;;; This file is part of GNU Guix. ;;; @@ -66,6 +67,7 @@ #:use-module (gnu packages docbook) #:use-module (gnu packages fontutils) #:use-module (gnu packages freedesktop) + #:use-module (gnu packages fribidi) #:use-module (gnu packages gettext) #:use-module (gnu packages ghostscript) #:use-module (gnu packages gl) @@ -1458,3 +1460,42 @@ ephemeral serial ports. It features automatic port detection, port enumeration, support for non-standard baud rates, the ability to wait for ports to appear, and the ability to read and write via stdin and stdout.") (license license:expat))) + +(define-public mlterm + (package + (name "mlterm") + (version "3.9.1") + (source + (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/mlterm/01release/mlterm-" + version "/mlterm-" version ".tar.gz")) + (sha256 + (base32 + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) + (build-system gnu-build-system) + (arguments + `(#:tests? #f ; no tests + #:configure-flags + (list (string-append "--prefix=" (assoc-ref %outputs "out")) + "--disable-static" + "--enable-optimize-redrawing" + "--with-imagelib=gdk-pixbuf"))) + (native-inputs + `(("gettext" ,gettext-minimal) + ("pkg-config" ,pkg-config))) + (inputs + `(("cairo" ,cairo) + ("fontconfig" ,fontconfig) + ("freetype" ,freetype) + ("fribidi" ,fribidi) + ("gdk-pixbuf" ,gdk-pixbuf) + ("gtk+" ,gtk+) + ("libx11" ,libx11) + ("libxext" ,libxext) + ("libxft" ,libxft))) + (home-page "http://mlterm.sourceforge.net/") + (synopsis "Multi Lingual TERMinal emulator") + (description "mlterm is a multi-lingual terminal emulator which supports +various character sets and encodings in the world.") + (license license:bsd-3))) -- 2.33.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [bug#50375] [PATCH v2] gnu: Add mlterm. 2021-09-05 11:31 ` [bug#50375] [PATCH v2] " iKaSeRo @ 2021-09-05 18:43 ` Xinglu Chen 2021-09-05 22:18 ` bug#50375: " Tobias Geerinckx-Rice via Guix-patches via 1 sibling, 0 replies; 5+ messages in thread From: Xinglu Chen @ 2021-09-05 18:43 UTC (permalink / raw) To: iKaSeRo, 50375; +Cc: iKaSeRo [-- Attachment #1: Type: text/plain, Size: 3544 bytes --] On Sun, Sep 05 2021, iKaSeRo wrote: > * gnu/packages/terminals.scm (mlterm): New variable. > --- > Xinglu Chen <public@yoctocell.xyz> writes: > >>> * gnu/packages/terminals.scm (mlterm): New variable. >>> --- >>> gnu/packages/terminals.scm | 40 ++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 40 insertions(+) >>> >>> diff --git a/gnu/packages/terminals.scm b/gnu/packages/terminals.scm >>> index 1cdf0e1831..037504ee4f 100644 >>> --- a/gnu/packages/terminals.scm >>> +++ b/gnu/packages/terminals.scm >>> @@ -25,6 +25,7 @@ >>> ;;; Copyright © 2020 Leo Famulari <leo@famulari.name> >>> ;;; Copyright © 2021 Ekaitz Zarraga <ekaitz@elenq.tech> >>> ;;; Copyright © 2021 Raphaël Mélotte <raphael.melotte@mind.be> >>> +;;; Copyright © 2021 ikasero <ahmed@ikasero.com> >>> ;;; >>> ;;; This file is part of GNU Guix. >>> ;;; >>> @@ -66,6 +67,7 @@ >>> #:use-module (gnu packages docbook) >>> #:use-module (gnu packages fontutils) >>> #:use-module (gnu packages freedesktop) >>> + #:use-module (gnu packages fribidi) >>> #:use-module (gnu packages gettext) >>> #:use-module (gnu packages ghostscript) >>> #:use-module (gnu packages gl) >>> @@ -1458,3 +1460,41 @@ ephemeral serial ports. It features automatic port detection, port enumeration, >>> support for non-standard baud rates, the ability to wait for ports to appear, >>> and the ability to read and write via stdin and stdout.") >>> (license license:expat))) >>> + >>> +(define-public mlterm >>> + (package >>> + (name "mlterm") >>> + (version "3.9.1") >>> + (source >>> + (origin >>> + (method url-fetch) >>> + (uri (string-append "mirror://sourceforge/mlterm/01release/mlterm-" >>> + version "/mlterm-" version ".tar.gz")) >>> + (sha256 >>> + (base32 >>> + "03fnynwv7d1aicwk2rp31sgncv5m65agvygqvsgn59v9di40gnnb")))) >>> + (build-system gnu-build-system) >>> + (arguments `(#:tests? #f >> >> What’s the reason for disabling tests; there should be a comment with a >> short explanation. >> > Because there are no tests, Now I added a comment thanks! >> Nit: This is usually on its own line >> >> (arguments >> `(#:tests? #f >> #:configure-flags >> ...)) >> > Didn't know that, fixed >>> + #:configure-flags >>> + (list (string-append "--prefix=" (assoc-ref %outputs "out")) >>> + "--disable-static" >>> + "--enable-optimize-redrawing" >>> + "--with-imagelib=gdk-pixbuf"))) >>> + (native-inputs >>> + `(("gettext" ,gettext-minimal) >>> + ("pkg-config" ,pkg-config))) >>> + (inputs >>> + `(("cairo" ,cairo) >>> + ("fontconfig" ,fontconfig) >>> + ("freetype" ,freetype) >>> + ("fribidi" ,fribidi) >>> + ("gdk-pixbuf" ,gdk-pixbuf) >>> + ("gtk+" ,gtk+) >>> + ("libx11" ,libx11) >>> + ("libxext" ,libxext) >>> + ("libxft" ,libxft))) >>> + (home-page "http://mlterm.sourceforge.net/") >>> + (synopsis "Multi Lingual TERMinal emulator") >>> + (description "mlterm is a multi-lingual terminal emulator which supports >>> +various character sets and encodings in the world.") >>> + (license license:bsd-3))) >>> -- >>> 2.33.0 >> >> The package builds fine, and the rest LGTM! > Thanks for the review! You are welcome! The updated patch looks good, but I don’t have commit access. [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 861 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#50375: [PATCH v2] gnu: Add mlterm. 2021-09-05 11:31 ` [bug#50375] [PATCH v2] " iKaSeRo 2021-09-05 18:43 ` Xinglu Chen @ 2021-09-05 22:18 ` Tobias Geerinckx-Rice via Guix-patches via 1 sibling, 0 replies; 5+ messages in thread From: Tobias Geerinckx-Rice via Guix-patches via @ 2021-09-05 22:18 UTC (permalink / raw) To: iKaSeRo; +Cc: 50375-done [-- Attachment #1: Type: text/plain, Size: 310 bytes --] iKaSeRo, iKaSeRo 写道： > * gnu/packages/terminals.scm (mlterm): New variable. Pushed as commit 53ccbc175570c4fd16b499670d37b36328d30f94. I moved the package somewhere vaguely alphabetical (terminals.scm isn't) and expanded the description slightly based on the man page. Thanks! T G-R [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 247 bytes --] ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-05 22:21 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2021-09-04 16:42 [bug#50375] [PATCH] gnu: Add mlterm iKaSeRo 2021-09-04 19:50 ` Xinglu Chen 2021-09-05 11:31 ` [bug#50375] [PATCH v2] " iKaSeRo 2021-09-05 18:43 ` Xinglu Chen 2021-09-05 22:18 ` bug#50375: " Tobias Geerinckx-Rice via Guix-patches via
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/guix.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).