From: "Ludovic Courtès" <ludo@gnu.org>
To: Andrew Whatson <whatson@gmail.com>
Cc: 50133@debbugs.gnu.org
Subject: [bug#50133] [PATCH 0/6] Add lxd package and service.
Date: Tue, 28 Sep 2021 15:42:04 +0200 [thread overview]
Message-ID: <87ee98akb7.fsf_-_@gnu.org> (raw)
In-Reply-To: <20210820124524.117090-6-whatson@gmail.com> (Andrew Whatson's message of "Fri, 20 Aug 2021 22:45:24 +1000")
Hi Andrew,
The whole series LGTM and I’ve already applied patch 1–5.
Some comments below about the service:
Andrew Whatson <whatson@gmail.com> skribis:
> * gnu/services/virtualization.scm (lxd-configuration): New type.
> (%lxd-accounts, lxd-service-type): New variables.
> (%lxd-activation, lxd-shepherd-service): New procedures.
> * gnu/system/file-systems.scm (%elogind-file-systems): Add
> "/sys/fs/cgroup/systemd" file-system.
[...]
> +(define lxd-service-type
> + (service-type
> + (name 'lxd)
> + (extensions
> + (list (service-extension activation-service-type
> + %lxd-activation)
> + (service-extension shepherd-root-service-type
> + lxd-shepherd-service)
> + (service-extension account-service-type
> + (const %lxd-accounts))))
> + (default-value (lxd-configuration))))
Please add a ‘description’ field.
> index b9eda80958..7c3777298b 100644
> --- a/gnu/system/file-systems.scm
> +++ b/gnu/system/file-systems.scm
> @@ -499,6 +499,17 @@ TARGET in the other system."
> (check? #f)
> (options "none,name=elogind")
> (create-mount-point? #t)
> + (dependencies (list (car %control-groups))))
> + ;; The systemd cgroup needs to exist to run systemd inside linux
> + ;; containers (eg. via LXD). This is *not* required for elogind, but
> + ;; keeping it with the other systemd hacks seemed sensible, for now.
> + (file-system
> + (device "cgroup")
> + (mount-point "/sys/fs/cgroup/systemd")
> + (type "cgroup")
> + (check? #f)
> + (options "none,name=systemd")
> + (create-mount-point? #t)
> (dependencies (list (car %control-groups)))))
> %control-groups))
Instead of adding it here, how about extending
‘file-system-service-type’ instead, similar to what
‘qemu-binfmt-service-type’ does? That way, the extra requirement would
be limited to LXD.
Two other things, could you add:
1. documentation in the manual under “Virtualization Services”, with a
commented config example?
2. (ideally) a system test to ensure that the basics of the service
are working?
TIA!
Ludo’.
next prev parent reply other threads:[~2021-09-28 13:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 12:43 [bug#50133] [PATCH 0/6] Add lxd package and service Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 1/6] gnu: libraft: Update to 0.11.2 Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 2/6] gnu: libdqlite: Update to 1.9.0 Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 3/6] gnu: lxc: Update to 4.0.10 Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 4/6] gnu: lxcfs: Update to 4.0.9 Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 5/6] gnu: Add lxd Andrew Whatson
2021-08-20 12:45 ` [bug#50133] [PATCH 6/6] services: Add lxd-service-type Andrew Whatson
2021-09-28 13:42 ` Ludovic Courtès [this message]
2023-09-02 6:01 ` [bug#50133] [PATCH 0/6] Add lxd package and service Vagrant Cascadian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee98akb7.fsf_-_@gnu.org \
--to=ludo@gnu.org \
--cc=50133@debbugs.gnu.org \
--cc=whatson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).