From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id oGzVDsirZmELwgAAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 11:50:00 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id sDOACsirZmHragAAB5/wlQ (envelope-from ) for ; Wed, 13 Oct 2021 09:50:00 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8E7D178E7 for ; Wed, 13 Oct 2021 11:49:59 +0200 (CEST) Received: from localhost ([::1]:49326 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maata-0002Q7-Ms for larch@yhetil.org; Wed, 13 Oct 2021 05:49:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34206) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maari-00061F-K6 for guix-patches@gnu.org; Wed, 13 Oct 2021 05:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46858) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1maarh-00019x-N5 for guix-patches@gnu.org; Wed, 13 Oct 2021 05:48:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1maarh-0007c4-JI for guix-patches@gnu.org; Wed, 13 Oct 2021 05:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51022] [PATCH] Update direnv to 2.28.0 Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 13 Oct 2021 09:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51022 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Artem Chernyak Cc: 51022@debbugs.gnu.org Received: via spool by 51022-submit@debbugs.gnu.org id=B51022.163411846629238 (code B ref 51022); Wed, 13 Oct 2021 09:48:01 +0000 Received: (at 51022) by debbugs.gnu.org; 13 Oct 2021 09:47:46 +0000 Received: from localhost ([127.0.0.1]:58404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maarS-0007bS-43 for submit@debbugs.gnu.org; Wed, 13 Oct 2021 05:47:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1maarO-0007af-Ch for 51022@debbugs.gnu.org; Wed, 13 Oct 2021 05:47:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51382) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1maarI-0000o6-8u; Wed, 13 Oct 2021 05:47:37 -0400 Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:57686 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1maarH-00063i-VX; Wed, 13 Oct 2021 05:47:36 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: Date: Wed, 13 Oct 2021 11:47:33 +0200 In-Reply-To: (Artem Chernyak's message of "Mon, 4 Oct 2021 21:23:25 -0500") Message-ID: <87ee8pqmru.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634118599; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=1+bD+J1ZYzq5qkyfz3fY6Q4+RrPAg6MFefT90OaHUvM=; b=S8A4CbYqIi8SX/T087gXFat1S7GW7I4FTIxDgW7aiFLJ4LynYO8SQv/cTiycsruZsN12Mh eLZJmDUrcZW7GXYFXc2fNneunVQDRlSTXoKKWHfWlluQKCpHEcVxBzGBnf3xhSmUVqwLgv wb3+Y4y1roVFq8xeggti6jKV3g1NOaGQNvBIYQTxO8BSXnILEHe6V0GdnaMXul5/spJCqv NfoosB5crzYf0sI8SKW9PEs6Niuv8Ms1SaeKmfkRAde1IgbX8efcHBDYxtMH6enC+qyQeu j6PlKEkp9GsC0XEXFJUym9uN9j6tcD+2xg40YqC1Ex1q1IA3NGYKt+3iwga5PQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634118599; a=rsa-sha256; cv=none; b=SI4IQxBDo1e3HjzINgjHi90uzeKmvRI5rhTG9givJSRnOu2C6znaPbGZnjfHvMmiSHwBg9 UpPoxwJDOFja+XtWThi2HAeZxsRsDn2nGZllNNBdT3dqU0obPbt1MWMVQBsJQhR/A3Fv1z hBfie8nYN9m8d5MvJGJKKgmEyxdRpXOwUq9DlzpIw1kvXL9qJUMeOGn9dX4Rs9RfxKhZVc 1Ls61kDr+G/mzO40Kz8r/dOVzZWbL71PzzuzFttYVHwAgQZyeywhHXOstjPPyZ9d/inqEl ipNh/bBWlj5ZVKqgaGHK3qMSah+sdCR8pLYSWxf//wx0tZYYdlnQiVh9oYCHTw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.71 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8E7D178E7 X-Spam-Score: -3.71 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5D/tBxoCx525 Hi Artem, Artem Chernyak skribis: > This patch includes an update to direnv. As part of the updated a few > From ced4b50ad1dda92e7ba58bebbe702b9dd7a3dae9 Mon Sep 17 00:00:00 2001 > From: hackeryarn > Date: Mon, 4 Oct 2021 21:08:46 -0500 > Subject: [PATCH] Update direnv to 2.28.0 > > --- > gnu/packages/golang.scm | 37 +++++++++++++++++++++++++++++++++++++ > gnu/packages/shellutils.scm | 13 +++++-------- > 2 files changed, 42 insertions(+), 8 deletions(-) > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > index a96f743f68..3e4e691631 100644 > --- a/gnu/packages/golang.scm > +++ b/gnu/packages/golang.scm > @@ -2669,6 +2669,43 @@ time.") > (home-page "https://godoc.org/golang.org/x/xerrors") > (license license:bsd-3)))) >=20=20 > +(define-public go-golang-org-x-mod > + (let ((commit "0f08993efd8a8ec67e75bcccf86b0e1569b0ab0a") > + (revision "0")) I=E2=80=99ve added this as a separate commit and tweaked the description an= d the commit log according to our conventions: https://guix.gnu.org/manual/devel/en/html_node/Submitting-Patches.html I noticed that source code has disappeared upstream and is instead being fetched from Software Heritage: --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix build go-golang-org-x-mod -S --check The following derivation will be built: /gnu/store/9rb03xwbdkkvi1zjivilpl011pxw5hwv-go-golang-org-x-mod-0.5.0-0.= 0f08993-checkout.drv building /gnu/store/9rb03xwbdkkvi1zjivilpl011pxw5hwv-go-golang-org-x-mod-0.= 5.0-0.0f08993-checkout.drv... guile: warning: failed to install locale environment variable `PATH' set to `/gnu/store/378zjf2kgajcfd7mfr98jn5xyc5w= a3qv-gzip-1.10/bin:/gnu/store/sf3rbvb6iqcphgm1afbplcs72hsywg25-tar-1.32/bin' hint: Using 'master' as the name for the initial branch. This default branc= h name hint: is subject to change. To configure the initial branch name to use in = all hint: of your new repositories, which will suppress this warning, call: hint:=20 hint: git config --global init.defaultBranch hint:=20 hint: Names commonly chosen instead of 'master' are 'main', 'trunk' and hint: 'development'. The just-created branch can be renamed via this comman= d: hint:=20 hint: git branch -m Initialized empty Git repository in /gnu/store/yyy7l1i2g769fsbwb97a9m8i4as5= 49nd-go-golang-org-x-mod-0.5.0-0.0f08993-checkout/.git/ fatal: remote error: Git repository not found Failed to do a shallow fetch; retrying a full fetch... fatal: remote error: Git repository not found git-fetch: '/gnu/store/5vai7bfrfkzv22dx13bxpszjrqyi78x6-git-minimal-2.33.0/= bin/git fetch origin' failed with exit code 128 Trying content-addressed mirror at berlin.guix.gnu.org... Trying content-addressed mirror at berlin.guix.gnu.org... Trying to download from Software Heritage... SWH: found revision 0f08993efd8a8ec67e75bcccf86b0e1569b0ab0a with directory= at 'https://archive.softwareheritage.org/api/1/directory/0a72c9a9750b33048= 3f510b8224732ecadc1547f/' swh:1:dir:0a72c9a9750b330483f510b8224732ecadc1547f/ swh:1:dir:0a72c9a9750b330483f510b8224732ecadc1547f/LICENSE [=E2=80=A6] --8<---------------cut here---------------end--------------->8--- Is there another URL we should use? (No big deal since it=E2=80=99s archiv= ed on Software Heritage anyway.) > +++ b/gnu/packages/shellutils.scm > @@ -239,7 +239,7 @@ are already there.") > (define-public direnv > (package > (name "direnv") > - (version "2.15.2") > + (version "2.28.0") > (source > (origin (method git-fetch) > (uri (git-reference > @@ -248,18 +248,13 @@ are already there.") > (file-name (git-file-name name version)) > (sha256 > (base32 > - "1y18619pmhfl0vrf4w0h75ybkkwgi9wcb7d9kv4n8drg1xp4aw4w")))) > + "0yk53jn7wafklixclka17wyjjs2g5giigjr2bd0xzy10nrzwp7c9")))) > (build-system go-build-system) > (arguments > '(#:import-path "github.com/direnv/direnv" > + #:tests? #f ;; TODO fix tests Not confidence-inspiring. :-) Could you take a closer look to get an understanding of why tests are failing? Based on that we=E2=80=99ll either fix whatever problem leads to failures, = or selectively disable the offending test(s), and only as a last resort disable tests altogether, with a comment explaining what the problem is. TIA! Ludo=E2=80=99.