unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#53154] [PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.
@ 2022-01-10  5:58 Arun Isaac
       [not found] ` <handler.53154.B.16417943169689.ack@debbugs.gnu.org>
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2022-01-10  5:58 UTC (permalink / raw)
  To: 53154; +Cc: Arun Isaac, Christopher Baines

Earlier, the bind-rpc field of <laminar-configuration> was not used at
all. This was a bug.

* gnu/services/ci.scm (laminar-shepherd-service): Use bind-rpc to set
LAMINAR_BIND_RPC environment variable.
---
 gnu/services/ci.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/services/ci.scm b/gnu/services/ci.scm
index 0c3566bcaf..172f85fe8e 100644
--- a/gnu/services/ci.scm
+++ b/gnu/services/ci.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2018, 2019, 2020, 2021 Christopher Baines <mail@cbaines.net>
-;;; Copyright © 2021 Arun Isaac <arunisaac@systemreboot.net>
+;;; Copyright © 2021, 2022 Arun Isaac <arunisaac@systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -84,6 +84,8 @@ (define laminar-shepherd-service
                                         #$home-directory)
                         ,(string-append "LAMINAR_BIND_HTTP="
                                         #$bind-http)
+                        ,(string-append "LAMINAR_BIND_RPC="
+                                        #$bind-rpc)
                         ,(string-append "LAMINAR_TITLE="
                                         #$title)
                         ,(string-append "LAMINAR_KEEP_RUNDIRS="
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [bug#53154] Acknowledgement ([PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.)
       [not found] ` <handler.53154.B.16417943169689.ack@debbugs.gnu.org>
@ 2022-01-10  6:01   ` Arun Isaac
  2022-01-10  8:57     ` Christopher Baines
  0 siblings, 1 reply; 4+ messages in thread
From: Arun Isaac @ 2022-01-10  6:01 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 53154

[-- Attachment #1: Type: text/plain, Size: 138 bytes --]


Hi Chris,

I have CCed you on this issue, since you wrote the laminar service and
might be able to review this patch easily.

Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug#53154] Acknowledgement ([PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.)
  2022-01-10  6:01   ` [bug#53154] Acknowledgement ([PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.) Arun Isaac
@ 2022-01-10  8:57     ` Christopher Baines
  2022-01-11  6:56       ` bug#53154: " Arun Isaac
  0 siblings, 1 reply; 4+ messages in thread
From: Christopher Baines @ 2022-01-10  8:57 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 53154

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]


Arun Isaac <arunisaac@systemreboot.net> writes:

> Hi Chris,
>
> I have CCed you on this issue, since you wrote the laminar service and
> might be able to review this patch easily.
>
> Thank you!

It looks like a good change to me, please push!

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#53154: Acknowledgement ([PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.)
  2022-01-10  8:57     ` Christopher Baines
@ 2022-01-11  6:56       ` Arun Isaac
  0 siblings, 0 replies; 4+ messages in thread
From: Arun Isaac @ 2022-01-11  6:56 UTC (permalink / raw)
  To: Christopher Baines; +Cc: 53154-done

[-- Attachment #1: Type: text/plain, Size: 17 bytes --]


Pushed, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 524 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-11  6:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-10  5:58 [bug#53154] [PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable Arun Isaac
     [not found] ` <handler.53154.B.16417943169689.ack@debbugs.gnu.org>
2022-01-10  6:01   ` [bug#53154] Acknowledgement ([PATCH] services: laminar: Set LAMINAR_BIND_RPC environment variable.) Arun Isaac
2022-01-10  8:57     ` Christopher Baines
2022-01-11  6:56       ` bug#53154: " Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).