From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iEwJMZiZ3mHOxQAAgWs5BA (envelope-from ) for ; Wed, 12 Jan 2022 10:04:24 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id IBJtLpiZ3mGWYgEA9RJhRA (envelope-from ) for ; Wed, 12 Jan 2022 10:04:24 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6757145A02 for ; Wed, 12 Jan 2022 10:04:24 +0100 (CET) Received: from localhost ([::1]:42830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7ZYN-0004nF-Fa for larch@yhetil.org; Wed, 12 Jan 2022 04:04:23 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51326) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7ZMV-0001oH-20 for guix-patches@gnu.org; Wed, 12 Jan 2022 03:52:08 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:35079) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7ZMP-0005bY-Vh for guix-patches@gnu.org; Wed, 12 Jan 2022 03:52:06 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7ZMP-0003rd-Qd for guix-patches@gnu.org; Wed, 12 Jan 2022 03:52:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#48735] [PATCH] gnu: Add clojure-tools. References: <87o8ct6kfe.fsf@reilysiegel.com> In-Reply-To: <87o8ct6kfe.fsf@reilysiegel.com> Resent-From: Ricardo Wurmus Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Jan 2022 08:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48735 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 48735@debbugs.gnu.org Received: via spool by 48735-submit@debbugs.gnu.org id=B48735.164197749914813 (code B ref 48735); Wed, 12 Jan 2022 08:52:01 +0000 Received: (at 48735) by debbugs.gnu.org; 12 Jan 2022 08:51:39 +0000 Received: from localhost ([127.0.0.1]:56215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7ZM2-0003qq-Rh for submit@debbugs.gnu.org; Wed, 12 Jan 2022 03:51:39 -0500 Received: from sender4-of-o51.zoho.com ([136.143.188.51]:21116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7ZLz-0003qa-6x for 48735@debbugs.gnu.org; Wed, 12 Jan 2022 03:51:37 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1641977492; cv=none; d=zohomail.com; s=zohoarc; b=MXzI6yZxrYIJLfOi+H3IdnCDEikUatLyhN8RqnKge8fsH2mo1UF2T0Nw7AiWceH6YMMcecxYgOgAC/Kl7DCc/aHyAwsDBh2snOPsWQUc+pqpZO0308Ye8LCYnlFzhd5cdSLrZV1hRLKTa+neXh+tccs3NFdPLOTcEsHPFvu/BnE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641977492; h=Content-Type:Content-Transfer-Encoding:Date:From:MIME-Version:Message-ID:Subject:To; bh=pVuK8ZfGIVNIu+R6qsshkL1ykinFdCDaxPqI3KtJmUA=; b=BY7FmD1XBHKugZsp397Vq0t9pmsAUo6r8A7Xipy+yfHBVka8CKETeXngMMTT0vKNeJQg5PiMrDIR+lIpcmfLm0bBXCzsmPphthhsY9EzsAk5qeUutiYLtxdjPhnZQX7MyqvQ/DfrkGRtY8g9oK1uyvH9ItIG479KhUHTkG0HuUU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=elephly.net; spf=pass smtp.mailfrom=rekado@elephly.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1641977492; s=zoho; d=elephly.net; i=rekado@elephly.net; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; bh=pVuK8ZfGIVNIu+R6qsshkL1ykinFdCDaxPqI3KtJmUA=; b=RIBCoq4u76mDHDJcJ3yS9JuRW/Ktvxu/Gw7P596w4mFKNmO7pywu1B5MFFaxO8uf qR7JyVNvmVQdcfQNs8E2FBtoDJd4m3IAtQGg1159PVHGqAP4mIH+yUyHK88F00snzup APgnl5CN9ityP9yk2KC9vbii0yB/9X35JtNMHpA0= Received: from localhost (p54ad4f4c.dip0.t-ipconnect.de [84.173.79.76]) by mx.zohomail.com with SMTPS id 1641977488496117.80674008785934; Wed, 12 Jan 2022 00:51:28 -0800 (PST) User-agent: mu4e 1.6.10; emacs 27.2 From: Ricardo Wurmus Date: Wed, 12 Jan 2022 09:45:02 +0100 X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Message-ID: <87ee5d5oc3.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641978264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=pVuK8ZfGIVNIu+R6qsshkL1ykinFdCDaxPqI3KtJmUA=; b=qCVl/rGUOjN/QYNVXJ4lbTLWXVtcFKTAMcdLClxafJ0hmbTro9nxxni/TQXXVX99uQ8mSu AOvV0ZBaMsJgE3iRqSwLU4DnzNqfmZ7G1V+JQNHgkNS3Y0evhcnlIMMJDd7AbpNG0rqj8C 49nnvEfQSeQFDWfxBHfrVcx0dls0TEZKHHr1QdiHZ33elhpSu+JJTmGci0R3rSs47h/LXx plO/zxRNdmwQg3jN6P7W1mnfaYCHO2JZcHxAxg8rNN0wQoRiBsrPAe0bVBO92kl79krwz8 vbUxgyaqYW+hTf8/G47vIQmTTh+U3nIzSu8miAgXmt1gpwKWxrYnyOilI6fdQw== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1641978264; a=rsa-sha256; cv=fail; b=jKK9tc1NaFnlPA9VcHu/ekHAiSXbPJgxqoylgmfvlIMvIRgZ9/cKw4VvztGmtL4vAGYxhu FV+vZSErXY8IR627e4rq8/lCFrsyIut+WT+iHFlTztwOlxer2hXJvyAzkEPUc4RyZRllOH ycyzwlLHPIdvph4VG6TJc5nt4IkW6RFgxG0F5FUYffSYZOp6YMxdhWG6h0jKdfOD+JP7VB 7iMK0u4baeZ/wAWmyegjYtSPjEZGm3MNeN58xb6PJSWYOyRwY9Ab7LRgYhq/DW/rYGUwIj UE9ZbNLE+zBz7gjhq9/TOLey2/YBsaXJA7mqzgDBF18l1e/1adElLt+1wcy5tQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=RIBCoq4u; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.12 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=elephly.net header.s=zoho header.b=RIBCoq4u; arc=reject ("signature check failed: fail, {[1] = sig:zohomail.com:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 6757145A02 X-Spam-Score: -1.12 X-Migadu-Scanner: scn1.migadu.com X-TUID: eZcY4fhqbcXW Hi Reily, this new patch set looks good. Thank you very much! I just have a few minor comments/questions: - build phases and snippets no longer need to end on #t or #true - nitpick: I=E2=80=99m not a fan of the somewhat unusual location of the =E2=80=9Chome-page=E2=80=9D field, but I understand that you=E2=80=99re r= eusing the URL. My personal preference is not to do that and to move the =E2=80=9Chome-page= =E2=80=9D field above the =E2=80=9Csynopsis=E2=80=9D field. - some packages have disabled tests; it would be good to add a comment as to why the tests are disabled - some descriptions are not complete sentences. If you can tell me about these disabled tests (e.g. in clojure-tools-deps-alpha), I can add comments and make the changes I suggested above when applying the patches. (You don=E2=80=99t need to send= new patches.) Thanks again! --=20 Ricardo