From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6M5oK1ay7mGvVQAAgWs5BA (envelope-from ) for ; Mon, 24 Jan 2022 15:06:14 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aNuyJ1ay7mEpCwEAauVa8A (envelope-from ) for ; Mon, 24 Jan 2022 15:06:14 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5B7B53B396 for ; Mon, 24 Jan 2022 15:06:14 +0100 (CET) Received: from localhost ([::1]:53550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBzz3-0008Cn-2J for larch@yhetil.org; Mon, 24 Jan 2022 09:06:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBzys-00084o-Kg for guix-patches@gnu.org; Mon, 24 Jan 2022 09:06:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49721) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBzys-0003BW-Ba for guix-patches@gnu.org; Mon, 24 Jan 2022 09:06:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBzys-0003KE-7X for guix-patches@gnu.org; Mon, 24 Jan 2022 09:06:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53395] Fix pypi import for flake8-array-spacing Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 24 Jan 2022 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53395 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Vivien Kraus Cc: 53395@debbugs.gnu.org Received: via spool by 53395-submit@debbugs.gnu.org id=B53395.164303315712763 (code B ref 53395); Mon, 24 Jan 2022 14:06:02 +0000 Received: (at 53395) by debbugs.gnu.org; 24 Jan 2022 14:05:57 +0000 Received: from localhost ([127.0.0.1]:42623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBzyn-0003Jn-1V for submit@debbugs.gnu.org; Mon, 24 Jan 2022 09:05:57 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:48788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBzyk-0003JU-1E for 53395@debbugs.gnu.org; Mon, 24 Jan 2022 09:05:55 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 5291B2D9; Mon, 24 Jan 2022 15:05:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id shBBr2w2YQyb; Mon, 24 Jan 2022 15:05:48 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id AC9068B; Mon, 24 Jan 2022 15:05:47 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87czkmi434.fsf@planete-kraus.eu> Date: Mon, 24 Jan 2022 15:05:47 +0100 In-Reply-To: <87czkmi434.fsf@planete-kraus.eu> (Vivien Kraus's message of "Thu, 20 Jan 2022 20:45:19 +0100") Message-ID: <87ee4xut38.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 5291B2D9 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1643033174; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=9+9yS+rGBc2nvSRwmJNWdqYvKuVTFwXMf2IUVsa7hug=; b=f9PNouak8yF0XkeH8FY7fQUe18iHzcOFRdFrKpbo2OvghozvJFIoBBeYNmiOs2GvNpA++k s3PhV9kBqYNaQJXWxIYjydvsr7V8tNQmvyt31s8LojV20DbhhoJ/knSzUr5Bj5qUtRqcYx RSxGdn8Rgs5H8op8qL3N7pVIF2iAFuIpLlWDiUmA5k7lO60lRaou+oWEvJe7MpKtEoDsYF VDowpJi4F7yoHicEaFJynSuEkv/h9T0iAV17pvPrgLiM9ufXcmmETI1aErB+h1l4aYJFmW Miqoj7TA6hzd3gArkaYJnsKeIcpUnNWOJJ/jfi0RTHG47CyolKy61ZgA2lAgPg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1643033174; a=rsa-sha256; cv=none; b=FJwVh+JBLYjwcS74btkljBAJWD/YdKaJHmkz1hCpPBHJJokHiTGuo9vv/nVhu8UbgTM06S rZu4BzYkpct5yaA3NFSXwupx0OS1KLtMJ3Sv/JzFO61q4+awMswgLFSxroRTM90ay4AQxV H6Zr97vJe2/+uMhq/aaqW4l/KICsr4rQvsdTydxyHa04mk7xzAebqrYhNDgUpkUQQrdqCf G5MxMTmzLcDws0ivi5p8nRkdwHKRoFpemGFMTYxQzBUqjDJ/J9ZOcQJjXMibftt9RzBiF1 Pmr6iMNNnNvENEAc297CvOF85jOna37XDUw+uAVQcTKXCgTKcQfjAJXPWGpFdA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.13 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5B7B53B396 X-Spam-Score: -4.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: UvZvvvQ+mqOt Hello! Vivien Kraus skribis: > From d8923c394fbe2e8eedf6fa548455d398f0caa022 Mon Sep 17 00:00:00 2001 > From: Vivien Kraus > Date: Thu, 20 Jan 2022 20:11:56 +0100 > Subject: [PATCH] pypi importer: Convert - to _ in pypi urls if needed. > > * guix/import/pypi.scm (find-project-url): New function. > (make-pypi-sexp): Use find-project-url. [...] > +(define (find-project-url name pypi-url) > + "Try different project name substitution until the result is found in > +pypi-url. Downcase is required for \"Deprecated\" and \"uWSGI\", and > +underscores are required for flake8-array-spacing." > + (or (find (cut string-contains pypi-url <>) > + (list name > + (string-downcase name) > + (string-replace-substring name "-" "_"))) > + (begin > + (warning (G_ "The project name `~a' does not appear in the pypi = URL; you might need to fix the pypi-url declaration in the generated packag= e. The URL is: ~a~%") > + name pypi-url) > + name))) As a rule of thumb, warnings are one-line messages (not sentences) describing the problem. Here you could emit such a warning, followed by a call to =E2=80=98display-hint=E2=80=99, which accepts Texinfo markup. Could you adjust accordingly? Also, what about adding a unit test? Thanks, Ludo=E2=80=99.