From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jai Vetrivelan <jaivetrivelan@gmail.com>
Cc: 53852@debbugs.gnu.org
Subject: [bug#53852] [PATCH] gnu: Add emacs-volatile-highlights.
Date: Mon, 07 Feb 2022 19:34:57 +0100 [thread overview]
Message-ID: <87ee4eed9q.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87k0e663x8.fsf@gmail.com> (Jai Vetrivelan's message of "Mon, 07 Feb 2022 21:54:03 +0530")
Hello,
Jai Vetrivelan <jaivetrivelan@gmail.com> writes:
> Subject: [PATCH] gnu: Add emacs-volatile-highlights.
Thank you.
> +(define-public emacs-volatile-highlights
> + (let ((commit "9a20091f0ce7fc0a6b3e641a6a46d5f3ac4d8392")
> + (revision "0"))
> + (package
> + (name "emacs-volatile-highlights")
> + (version (git-version "1.15" revision commit))
The commit used matches the version bump. Therefore you can drop
revision and `git-version', and add a comment explaining this.
> + (synopsis "Minor mode for visual feedback on editing operations")
Maybe: Emacs minor mode for visual…
> + (description "This package provides minor mode
> +@command{volatile-highlights-mode}, which brings visual feedback to some
> +operations by highlighting portions relating to the operations. All of
> +highlights made by this library will be removed when any new operation is
> +executed.")
I would start with:
Volatile Highlights minor mode brings visual feedback to…
Otherwise LGTM.
Could you send an updated patch?
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-02-07 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:24 [bug#53852] [PATCH] gnu: Add emacs-volatile-highlights Jai Vetrivelan
2022-02-07 18:34 ` Nicolas Goaziou [this message]
2022-02-07 23:48 ` [bug#53852] [PATCH v2] " Jai Vetrivelan
2022-02-08 0:04 ` bug#53852: " Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee4eed9q.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=53852@debbugs.gnu.org \
--cc=jaivetrivelan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).