unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Paul A. Patience" <paul@apatience.com>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55067@debbugs.gnu.org
Subject: [bug#55067] [PATCH] gnu: nomad-optimizer: Disable failing test.
Date: Fri, 22 Apr 2022 19:02:34 +0000	[thread overview]
Message-ID: <87ee1pne56.fsf@apatience.com> (raw)
In-Reply-To: <3fca716b728e196be715326f84c51d2e90e29eef.camel@telenet.be>


On 2022-04-22 13:25:20-04:00, Maxime Devos wrote:
>> It turns out the PSDMads test fails randomly.
>
> Sounds like a bug, preferably it would 100% reliably report the
> underlying problem, whatever it is.

I agree with you, and I have already reported the issue to the
developers (along with some other issues that I addressed in the package
definition).

>> I've disabled it.
>
> I don't think this is a good reason to disable the test.
> Disabling tests whenever they fail defeats the point of tests.

This test failure wasn't getting detected in the past due to a missing
"set -o pipefail" in the test runner, which could explain why it was
missed by the developers.
I don't know enough to fix the bug myself, but I have a suspicion it is
a bug in the test rather than in the library.

Best regards,
Paul





  reply	other threads:[~2022-04-22 19:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22 16:20 [bug#55067] [PATCH] gnu: nomad-optimizer: Disable failing test Paul A. Patience
2022-04-22 16:30 ` [bug#55067] [PATCH v2] " Paul A. Patience
2022-04-22 17:25 ` [bug#55067] [PATCH] " Maxime Devos
2022-04-22 19:02   ` Paul A. Patience [this message]
2022-04-22 21:37     ` Maxime Devos
2022-04-25 19:10 ` [bug#55067] [PATCH v3] " Paul A. Patience
2022-04-26  8:45   ` bug#55067: [PATCH] " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee1pne56.fsf@apatience.com \
    --to=paul@apatience.com \
    --cc=55067@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).