From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id kMgQBQnKtGI1AQAAbAwnHQ (envelope-from ) for ; Thu, 23 Jun 2022 22:16:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id ME2/BAnKtGIyXQEAauVa8A (envelope-from ) for ; Thu, 23 Jun 2022 22:16:09 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BBBF38694 for ; Thu, 23 Jun 2022 22:16:08 +0200 (CEST) Received: from localhost ([::1]:45426 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o4TFH-0005bQ-Tt for larch@yhetil.org; Thu, 23 Jun 2022 16:16:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TFC-0005bH-TN for guix-patches@gnu.org; Thu, 23 Jun 2022 16:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46098) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o4TFC-0002mX-L3 for guix-patches@gnu.org; Thu, 23 Jun 2022 16:16:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o4TFC-0005lw-Hi for guix-patches@gnu.org; Thu, 23 Jun 2022 16:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#55958] [PATCH 1/9] gnu: Add node-buffer-crc32. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 23 Jun 2022 20:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55958 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 55958@debbugs.gnu.org Cc: Nicolas Graves X-Debbugs-Original-To: Nicolas Graves via Guix-patches via , 55958@debbugs.gnu.org Received: via spool by 55958-submit@debbugs.gnu.org id=B55958.165601535022158 (code B ref 55958); Thu, 23 Jun 2022 20:16:02 +0000 Received: (at 55958) by debbugs.gnu.org; 23 Jun 2022 20:15:50 +0000 Received: from localhost ([127.0.0.1]:39994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TEz-0005lK-Jv for submit@debbugs.gnu.org; Thu, 23 Jun 2022 16:15:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o4TEx-0005ku-Ub for 55958@debbugs.gnu.org; Thu, 23 Jun 2022 16:15:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48686) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TEr-0002ho-FU; Thu, 23 Jun 2022 16:15:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=ruIxYJQelnPAPAFgr9cNff2CjuCw2cpY1EfGpIr/Axk=; b=pAYAnDXFMFi5pse8xA8q HEwiMkMxLNYjHNC81PiHZ5CI6BiE4D7uAL6+N4rMoJx2+KIZEvIo1cH9Qaa16dSuaKQPgfrPHmE9I B9m49ZjQRKGWxKyGszVwPknl8WhQroRMC2gKRTKjr64+F7Ifdv3y43NqABb4hRahvS3K0BTZm8AHG EvULTpTc4QKTus/XoEdr4IwyTCULoaUmtzIz8Kcl+dHWBNV1YM+W2MJ5X4/0IOmtYK+vuRqxA8XYO FjbCFhEAEBGajvdg+u/lJLbnXz67soKxHfls1I9I94FkjnmX+Nej6QiH/I0GuLNzB0wFsKrXTdJ1a WuM2TDqzwgUw4Q==; Received: from host-37-191-236-102.lynet.no ([37.191.236.102]:57824 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o4TEr-0008TO-0I; Thu, 23 Jun 2022 16:15:41 -0400 From: Marius Bakke In-Reply-To: <20220614094954.15197-1-ngraves@ngraves.fr> References: <20220614094954.15197-1-ngraves@ngraves.fr> Date: Thu, 23 Jun 2022 22:15:39 +0200 Message-ID: <87edzfrv9w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1656015368; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ruIxYJQelnPAPAFgr9cNff2CjuCw2cpY1EfGpIr/Axk=; b=a2sCGkd+k58kmFwSwwtS53bYzrdNTASeqsW9nEUF2D4eOwAc8ilqwchBjA3F/7rEtw6OrO i1OUnhABJMRgmocAa4Rej7IaObOnZzL5fduriJ2QjH9BX4y1a/7IwrndtfleeXnKNhVhL0 Nr3GZoRLZBT7rD2YMOJf4RIOGjdxDXpR1aWY/B21tpb7UupXrBuAQYYYjKbn9s/NbsfmeX qjpi3RxY9F7QAqd1F3HLDkFoV4wzlA29gpx0BId17ZPmB5bVxzq7SEgZmnKNA5NyBZOO5S YNAT9KxUvb4IeCClHySfAuIK9wKaKZL+R19fVs7VD6qfxrxwuMIzwV09gwYGOg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1656015368; a=rsa-sha256; cv=none; b=Ml/NDREcHaU4+/kuT/e1zW7ncDci4zrZ2EXo9SOsN7YKjzsP29dXjfXatfHeisu6r66Doo NYVCRyL1v3yCVw7OvTOUUsGOQCb4INHYsG52WJXxrmR/sWialaHVaHivF9mS5zZDT+PVas xTdaqnJOrrMQQCONkax9SAQeo+dgcUzeyHsz3vMCQecQOT8ceoyadND1BSjbI3dgzWVctK dG5qkhNI58jZuUjUY516u8W+m5bFXmM23uovPtmr3r5unVJ9pNumbk9uvuXXpgrXKAoK4w ppatncyafgAN9XyW2KVtLW7nBtViVJHmhtcBUbqyN6LjQNPbkBiD0scsN2+9Rg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pAYAnDXF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -6.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=pAYAnDXF; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BBBF38694 X-Spam-Score: -6.76 X-Migadu-Scanner: scn0.migadu.com X-TUID: sNdj/2MrbDWp --=-=-= Content-Type: text/plain Nicolas Graves via Guix-patches via skriver: > * gnu/packages/node-xyz.scm (node-buffer-crc32): New variable. [...] > + (arguments > + '(#:phases > + (modify-phases %standard-phases > + (delete 'check) Use #:tests? #f instead of deleting the phase. > + (replace 'configure > + (lambda* (#:key inputs #:allow-other-keys) > + (invoke (string-append (assoc-ref inputs "node") "/bin/npm") > + "--offline" "--ignore-scripts" "install" "--production") Use (search-input-file inputs "/bin/npm") instead of (assoc-ref inputs ...). Although in this case I think you don't need the absolute file name as "npm" should already be on PATH, so you can just (invoke "npm" ...). > + #t))))) There is no need to end phases on #t any more. > + (home-page "https://github.com/brianloveswords/buffer-crc32") > + (synopsis "crc32 that works with binary data and fancy character sets, > +outputs buffer, signed or unsigned data and has tests.") Try to keep synopses short, and avoid duplicating the description. Maybe something like "CRC32 implementation in JavaScript"? > + (description "This package provides crc32 that works with binary data and s/crc32/a CRC32 algorithm/ > +fancy character sets, outputs buffer, signed or unsigned data and has tests, for I don't understand what "outputs buffer" means here, can you elaborate? Otherwise LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYrTJ6w8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHearQD/UN+RzfTh3NNy1OYtJgrgVaY7IMFBNAPK1C4O nq/KM+sBAMwlTqz8YVIB8/wnymr7pVn+1snHGB+fccDjfAgnFwcF =WA9o -----END PGP SIGNATURE----- --=-=-=--