From: Remco van 't Veer <remco@remworks.net>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55891@debbugs.gnu.org
Subject: [bug#55891] [PATCH] gnu: Add iec16022
Date: Sat, 25 Jun 2022 16:53:19 +0200 [thread overview]
Message-ID: <87edzceqw0.fsf@remworks.net> (raw)
In-Reply-To: <87mtejhe1d.fsf@remworks.net>
2022/06/10 23:47, Maxime Devos:
> I think it's ok, _if_ the bugs are eventually at least reported
> upstream if we (i.e., you) cannot fix them timely (needs some
> contrived circumstances to trigger the bug).
The maintainer's stance on not checking malloc response (from
https://github.com/rdoeffinger/iec16022/pull/17#issuecomment-1152892833):
> > I'll open an issue for the unchecked [mc]alloc and write calls
> > instead if you do and maybe have another stab at fixing these issues
> > when my C-programming skills have improved.
>
> I agree on the unchecked writes. For the unchecked [mc]alloc I am more
> tempted towards removing the existing checks, since I am not convinced
> checking won't always do more harm than good for those.
He elaborated on this at:
https://github.com/rdoeffinger/iec16022/pull/17#issuecomment-1153103749
Boiling down to: when memory is that low exiting with a proper error
messages and doing cleanup probably won't work anyway and the OOM killer
will have swept in before the situation exists. Which makes sense,
IMHO, but I am no expert.
I've created an issue for the unchecked writes:
https://github.com/rdoeffinger/iec16022/issues/18
HTH,
Remco
next prev parent reply other threads:[~2022-06-25 14:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 15:04 [bug#55891] [PATCH] gnu: Add iec16022 Remco van 't Veer
2022-06-10 15:42 ` Maxime Devos
2022-06-10 17:36 ` Remco van 't Veer
2022-06-10 15:45 ` Maxime Devos
2022-06-10 17:37 ` Remco van 't Veer
2022-06-10 15:47 ` Maxime Devos
2022-06-10 17:38 ` Remco van 't Veer
2022-06-10 15:55 ` Maxime Devos
2022-06-10 17:39 ` Remco van 't Veer
2022-06-10 21:47 ` Maxime Devos
2022-06-11 7:09 ` Remco van 't Veer
2022-06-25 14:53 ` Remco van 't Veer [this message]
2022-07-01 6:58 ` Remco van 't Veer
2022-07-30 23:48 ` Maxime Devos
2022-08-14 7:57 ` Remco van 't Veer
2022-06-10 17:35 ` [bug#55891] [PATCH v2] " Remco van 't Veer
2022-06-10 17:45 ` [bug#55891] [PATCH v3] " Remco van 't Veer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edzceqw0.fsf@remworks.net \
--to=remco@remworks.net \
--cc=55891@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).