unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: jgart <jgart@dismail.de>
Cc: 53825-done@debbugs.gnu.org, Xinglu Chen <public@yoctocell.xyz>
Subject: bug#53825: [PATCH] gnu: Add sbase.
Date: Thu, 07 Jul 2022 15:57:12 -0400	[thread overview]
Message-ID: <87edywy9uv.fsf_-_@gmail.com> (raw)
In-Reply-To: <20220209175709.5954-1-jgart@dismail.de> (jgart@dismail.de's message of "Wed, 9 Feb 2022 12:57:10 -0500")

Hi,

jgart <jgart@dismail.de> writes:

> * gnu/packages/suckless.scm (sbase): New variable.
> ---
>
> Hi, 
>
> Here is version 3 with the fix Xinglu mentioned.
>
> I haven't tested all the binaries.
>
> all best,
>
> jgart
>
> https://whereiseveryone.srht.site/
> gemini://whereiseveryone.srht.site/

I've adjusted it like so:

--8<---------------cut here---------------start------------->8---
modified   gnu/packages/suckless.scm
@@ -12,6 +12,7 @@
 ;;; Copyright © 2021 Alexandru-Sergiu Marton <brown121407@posteo.ro>
 ;;; Copyright © 2021 Nikolay Korotkiy <sikmir@disroot.org>
 ;;; Copyright © 2022 Jai Vetrivelan <jaivetrivelan@gmail.com>
+;;; Copyright © 2022 jgart <jgart@dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1011,19 +1012,19 @@ (define-public sbase
           (base32 "119v1lpgsx8bx9h57wg454ddhzz2awqavl3wrn35a704vifg28g0"))))
       (build-system gnu-build-system)
       (arguments
-       `(#:tests? #f ; There are no tests.
-         #:make-flags
-         ,#~(list (string-append "CC=" #$(cc-for-target))
-                  (string-append "PREFIX=" #$output))
-         #:phases
-         (modify-phases %standard-phases
-           (delete 'configure))))
+       (list
+        #:tests? #f                     ;no test suite
+        #:make-flags #~(list (string-append "CC=" #$(cc-for-target))
+                             (string-append "PREFIX=" #$output))
+        #:phases
+        #~(modify-phases %standard-phases
+            (delete 'configure))))
       (home-page "https://core.suckless.org/sbase/")
-      (synopsis "Collection of Unix tools that are portable across unix-systems")
-      (description
-  "@command{sbase} is a collection of Unix tools that are portable across
-  Unix-systems.")
-      (license license:x11))))
+      (synopsis "Collection of UNIX tools")
+      (description "@command{sbase} is a collection of UNIX tools similar to those of GNU
+Coreutils, containing utilities commands such as @command{grep}, @command{cp},
+@command{rm}, etc.")
+      (license license:expat))))
 
 (define-public scron
   (package
--8<---------------cut here---------------end--------------->8---

Reverting the license to Expat as pointed by Maxime, fully capitalizing
UNIX, using a gexp for the phases and adding a few commands to the
description to give a better idea.  I've also removed the bits "portable
across UNIX systems" as on Guix that's not useful (the tools are as
portable as Guix itself is).

Pushed as 5299628b90.

Thanks!

Maxim




  reply	other threads:[~2022-07-07 19:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 17:56 [bug#53825] [PATCH] gnu: Add sbase jgart via Guix-patches via
2022-02-06 18:24 ` Xinglu Chen
2022-02-07  2:17 ` [bug#53825] [PATCH v2] " jgart via Guix-patches via
2022-02-09 13:37   ` Xinglu Chen
2022-02-09 17:57 ` [bug#53825] [PATCH v3] " jgart via Guix-patches via
2022-07-07 19:57   ` Maxim Cournoyer [this message]
2022-03-20 15:21 ` [bug#53825] [PATCH] " Maxime Devos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edywy9uv.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=53825-done@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).