From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id eOBfGp4aVmPucgEAbAwnHQ (envelope-from ) for ; Mon, 24 Oct 2022 06:54:54 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GOY9GZ4aVmOlDQEAG6o9tA (envelope-from ) for ; Mon, 24 Oct 2022 06:54:54 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 09C622A541 for ; Mon, 24 Oct 2022 06:54:54 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omjAV-0005uU-UT for larch@yhetil.org; Sun, 23 Oct 2022 18:10:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omJpm-0007k8-G4 for guix-patches@gnu.org; Sat, 22 Oct 2022 15:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omJpm-0002T0-94 for guix-patches@gnu.org; Sat, 22 Oct 2022 15:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omJpl-0003Fz-VJ for guix-patches@gnu.org; Sat, 22 Oct 2022 15:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#58587] [PATCH 00/14] Introducing pyproject-build-system. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Oct 2022 19:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58587 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: zimoun , 58587@debbugs.gnu.org Cc: Lars-Dominik Braun , Maxim Cournoyer Received: via spool by 58587-submit@debbugs.gnu.org id=B58587.166646560412488 (code B ref 58587); Sat, 22 Oct 2022 19:07:01 +0000 Received: (at 58587) by debbugs.gnu.org; 22 Oct 2022 19:06:44 +0000 Received: from localhost ([127.0.0.1]:42342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omJpT-0003FM-Oe for submit@debbugs.gnu.org; Sat, 22 Oct 2022 15:06:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33194) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omJpQ-0003F8-G7 for 58587@debbugs.gnu.org; Sat, 22 Oct 2022 15:06:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omJpK-0002OU-3a; Sat, 22 Oct 2022 15:06:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=X5KeGVsJzSaFdMmvLEQArVCvxICfv4MnSvyaBImMXLg=; b=lZpT5y5aCQBlt8uPdltB wmP451B++pBjEhcC5hkYwuYwYkbKQi0sxYZjHM8VMadK68dgaBz+NAnCsu86hPEta1A1+8Y3/pg7a naLAWcrddzERhxiPxoVxwslacDzhKyM5EkYw2QfpEweCbCTZDbfJd7DCYE0xXt0mqOakyRlfjO6jv BbBQhutA0UD7txKixXKG/6WBUbIUX8F3p8KJyzm/SPn823dKkRj4QaSxzyUIlpmwC1RHNURYQ+tDw iwXz4VJayaZ1sSM/Z/Ijcl51o4mOTUi0XxUIETL611HDXjZzmqxNAOYQ3bo/QXAdtH3/wF2FFa4Ed l9xSsKJ4w8gVgQ==; Received: from [185.80.180.134] (helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omJpJ-0003Yf-8y; Sat, 22 Oct 2022 15:06:33 -0400 From: Marius Bakke In-Reply-To: <87v8oekjcs.fsf@gmail.com> References: <20221017200624.4076-1-marius@gnu.org> <86sfjlzdbn.fsf@gmail.com> <877d0wvlzg.fsf@gnu.org> <86ilkgp2hx.fsf@gmail.com> <871qr3v26i.fsf@gnu.org> <87v8oekjcs.fsf@gmail.com> Date: Sat, 22 Oct 2022 21:06:25 +0200 Message-ID: <87eduzu18u.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1666587294; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=X5KeGVsJzSaFdMmvLEQArVCvxICfv4MnSvyaBImMXLg=; b=XG8kjOm4jVZSSYPd6Mnm7kDREEMPA9ooyaai6GsC0oZcdsxwsl/6FsVG6ZIk3R9f2cZWXj J70cDWnIuUSosB3eQZf5o/RU6BtZZ7tuCS/iBz4Yg8WXkTZv3WQudP6DXZFwafNymmrTeg O4aNoSIZhYpBtwPtNE2KARsxoikyy45VmP2oSgPd9QEy8K4Twy9Foc6+La10VscWo8+d3O oyxySS+j9i8pmujSOsA3o8OfRB70UFXb3IfrSJxavKYy+3J7eLU1RpZBSEPzjOZYQzD7g0 sKK1siIzBDmGTd4m2/4/u9aZSsSf1m7xEbs9BPbE88W13/fcJOX5YSBL1VirTQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1666587294; a=rsa-sha256; cv=none; b=UiaAV43RRANT/P3W1/Gk8SM6CHeyeeGDv12ZUk6DaRzz9RTcft2b52D1Cs35BfQGKAgzS0 X7AMMdqe0T4/M1pHZyZSBfnWFqWTLFnZb042Lp2eUD+4un2MER4uowsB8o39D4FxNXE7ZW lT0GQk8neYlCN6OnTMoXKstOmanCZMUzkK9q5Arl4H2sDEQi/I29dGx8zBWOd3hk0gt83Q jMdFlOTmQ0DeTeROELJ9l4Xa+YbvEqFtcSH6FpyaBoRaNNXbsNhdal17z/i3d347f2cFkV GV2u+Hc59slPN1YUtuTLHcN5L0v4Qou7q8XIjh7ZQw8ifs7yPoMTAWfMmkFbeA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lZpT5y5a; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.51 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=lZpT5y5a; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 09C622A541 X-Spam-Score: -2.51 X-Migadu-Scanner: scn0.migadu.com X-TUID: xEeyqpvcMTIp --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable zimoun skriver: > Hi Marius, > > On jeu., 20 oct. 2022 at 01:11, Marius Bakke wrote: > >> diff --git a/doc/contributing.texi b/doc/contributing.texi >> index b9260267fa..d12daa7ec3 100644 >> --- a/doc/contributing.texi >> +++ b/doc/contributing.texi >> @@ -786,6 +786,21 @@ for instance, the module python-dateutil is package= d under the names >> starts with @code{py} (e.g.@: @code{pytz}), we keep it and prefix it as >> described above. >>=20=20 >> +@quotation Note >> +Currently there are two different build systems for Python packages in = Guix: >> +@var{python-build-system} and @var{pyproject-build-system}. For the >> +longest time, Python packages were built from an informally specified >> +@file{setup.py} file. That worked amazingly well, considering Pythons > ^ > typo? Right, I've adjusted it! >> +success, but was difficult to build tooling around. As a result, a host >> +of alternative build systems emerged and the community eventually settl= ed on a >> +@url{https://peps.python.org/pep-0517/, formal standard} for specifying= build >> +requirements. @var{pyproject-build-system} is Guix's implementation of= this >> +standard. It is considered ``experimental'' in that it does not yet su= pport >> +all the various PEP-517 @emph{build backends}, but you are encouraged t= o try >> +it for new Python packages and report any problems. It will eventually= be >> +deprecated and merged into @var{python-build-system}. >> +@end quotation > > LTGM.=20=20 Thanks for checking. I've now added a section in the manual about API changes and stability, and removed more duplicate code from pyproject-build-system. I also added a news entry. I think this is now ready for merge, but have some concerns: * The python-toolchain package is a union that includes setuptools, wheel and others. Packages that pick up a reference to the build-time Python will needlessly include those other packages. It could be worked around by propagating instead of using a union. * Overriding #:test-flags means having to add back the implicit defaults for verbose output. We could add them even when #:test-flags is present so users don't need to add "-vv" manually. Thoughts? I will merge this in a few days if there are no further comments. It can still be tweaked directly on 'master' if necessary. Updated patches follow shortly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCY1Q/MQ8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHfQ4wEAhu39WBo+JB2Z0JklcriZDXP9csXYK0peReOL g7REZ8EBAJtHa0KzEs0dub7SsrCVt2VceUE4ci0cu26iVw8OzTsM =ahPo -----END PGP SIGNATURE----- --=-=-=--