unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 59048@debbugs.gnu.org
Subject: [bug#59048] [PATCH] guix: modify-input: Recommend prepend instead of append.
Date: Sat, 05 Nov 2022 20:17:28 +0100	[thread overview]
Message-ID: <87eduhgqgj.fsf@cbaines.net> (raw)
In-Reply-To: <7c0fbbe321c736a5757c637b33bf3a9909a6f63e.camel@planete-kraus.eu>

[-- Attachment #1: Type: text/plain, Size: 642 bytes --]


Vivien Kraus via Guix-patches via <guix-patches@gnu.org> writes:

> * doc/guix.texi (Defining Package Variants): Document the "prepend" clause of
> modify-inputs first.
> * guix/packages.scm (modify-inputs): use "prepend" in the docstring.
> ---
>  doc/guix.texi     | 12 ++++++------
>  guix/packages.scm |  4 ++--
>  2 files changed, 8 insertions(+), 8 deletions(-)

This seems OK, but it would be good to know why you're wanting to change
this? In other words, how does this make things better?

This information would be good to have in the commit message (I usually
just write a sentance/paragraph above the changelog).

Thanks,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  parent reply	other threads:[~2022-11-05 19:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-05 11:59 [bug#59048] [PATCH] guix: modify-input: Recommend prepend instead of append Vivien Kraus via Guix-patches via
2022-11-05 11:59 ` [bug#59048] [PATCH v2] " Vivien Kraus via Guix-patches via
2022-11-21 14:36   ` bug#59048: " Christopher Baines
2022-11-05 12:06 ` [bug#59048] [PATCH] " ( via Guix-patches via
2022-11-05 19:17 ` Christopher Baines [this message]
2022-11-05 19:47   ` Vivien Kraus via Guix-patches via
2022-11-05 19:51     ` ( via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eduhgqgj.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=59048@debbugs.gnu.org \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).