From: "pelzflorian (Florian Pelz)" <pelzflorian@pelzflorian.de>
To: "(" <paren@disroot.org>
Cc: 59822@debbugs.gnu.org
Subject: [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button.
Date: Sun, 04 Dec 2022 22:50:26 +0100 [thread overview]
Message-ID: <87edterg7x.fsf@pelzflorian.de> (raw)
In-Reply-To: <20221204195007.20997-1-paren@disroot.org> (guix-patches@gnu.org's message of "Sun, 4 Dec 2022 19:50:07 +0000")
Hello (
"( via Guix-patches" via <guix-patches@gnu.org> writes:
> * website/apps/base/templates/home.scm (home-t)[#:content]: Add a
> 'DOWNLOAD LATEST' button.
Good idea.
Would you add a copyright line or copyright disclaimer line and send an
updated patch?
> #:label (apply string-append
> (C_ "button" `("DOWNLOAD v" ,(latest-guix-version) "")))
> […]
> " " ; A space for readability in non-CSS browsers.
> + ,(button-big
> + #:label (apply string-append
> + (C_ "button" `("DOWNLOAD LATEST")))
In the DOWNLOAD LATEST button, could you remove the (apply string-append
and its now unmatched parenthesis?
It is a trick to concatenate the translations for "DOWNLOAD v", the
latest-guix-version and the translation for "". But for "DOWNLOAD
LATEST", it is unneeded.
And maybe untabify the lines you change.
Other than that, LGTM, thank you!
Regards,
Florian
next prev parent reply other threads:[~2022-12-04 21:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-04 19:50 [bug#59822] [PATCH guix-artwork] website: base: home: Add 'DOWNLOAD LATEST' button ( via Guix-patches via
2022-12-04 21:50 ` pelzflorian (Florian Pelz) [this message]
2022-12-04 21:58 ` pelzflorian (Florian Pelz)
2022-12-04 22:03 ` pelzflorian (Florian Pelz)
2022-12-05 7:02 ` ( via Guix-patches via
2022-12-05 8:00 ` pelzflorian (Florian Pelz)
2022-12-05 9:00 ` zimoun
2022-12-05 17:06 ` pelzflorian (Florian Pelz)
2022-12-05 17:41 ` pelzflorian (Florian Pelz)
2022-12-06 11:22 ` zimoun
2022-12-06 16:33 ` pelzflorian (Florian Pelz)
2022-12-06 17:45 ` zimoun
2022-12-07 14:26 ` pelzflorian (Florian Pelz)
2022-12-08 9:36 ` pelzflorian (Florian Pelz)
2022-12-08 10:12 ` zimoun
2022-12-08 11:50 ` bug#59822: " pelzflorian (Florian Pelz)
2022-12-08 15:49 ` [bug#59822] " ( via Guix-patches via
2022-12-05 16:51 ` ( via Guix-patches via
2022-12-08 16:44 ` pelzflorian (Florian Pelz)
2022-12-08 16:46 ` ( via Guix-patches via
2022-12-08 18:10 ` zimoun
2022-12-08 19:44 ` pelzflorian (Florian Pelz)
2022-12-21 13:40 ` Ludovic Courtès
2022-12-30 12:21 ` zimoun
2022-12-31 15:43 ` pelzflorian (Florian Pelz)
2023-01-06 22:53 ` Ludovic Courtès
2023-01-07 7:29 ` pelzflorian (Florian Pelz)
2023-01-09 10:13 ` Simon Tournier
2023-01-09 19:35 ` pelzflorian (Florian Pelz)
2023-01-11 16:11 ` Simon Tournier
2023-01-12 17:56 ` pelzflorian (Florian Pelz)
2022-12-05 7:01 ` ( via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edterg7x.fsf@pelzflorian.de \
--to=pelzflorian@pelzflorian.de \
--cc=59822@debbugs.gnu.org \
--cc=paren@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).