From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id iM5IFc0w4WPpzwAAbAwnHQ (envelope-from ) for ; Mon, 06 Feb 2023 17:54:37 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AFgaFc0w4WOu8wAA9RJhRA (envelope-from ) for ; Mon, 06 Feb 2023 17:54:37 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D46D82FE18 for ; Mon, 6 Feb 2023 17:54:36 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pP4kl-0001Z0-VX; Mon, 06 Feb 2023 11:54:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pP4kk-0001Yl-9y for guix-patches@gnu.org; Mon, 06 Feb 2023 11:54:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pP4kk-0005mV-1g for guix-patches@gnu.org; Mon, 06 Feb 2023 11:54:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pP4kj-0005s0-R8 for guix-patches@gnu.org; Mon, 06 Feb 2023 11:54:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#60899] Request for review of: [bug#60899] [PATCH 00/25] gnu: golang: Add gopls Resent-From: Katherine Cox-Buday Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Feb 2023 16:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60899 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 60899@debbugs.gnu.org Cc: Guix Devel Received: via spool by 60899-submit@debbugs.gnu.org id=B60899.167570243622539 (code B ref 60899); Mon, 06 Feb 2023 16:54:01 +0000 Received: (at 60899) by debbugs.gnu.org; 6 Feb 2023 16:53:56 +0000 Received: from localhost ([127.0.0.1]:49738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4kd-0005rS-RW for submit@debbugs.gnu.org; Mon, 06 Feb 2023 11:53:56 -0500 Received: from mail-io1-f49.google.com ([209.85.166.49]:39762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4kb-0005rG-Tc for 60899@debbugs.gnu.org; Mon, 06 Feb 2023 11:53:54 -0500 Received: by mail-io1-f49.google.com with SMTP id y7so4661227iob.6 for <60899@debbugs.gnu.org>; Mon, 06 Feb 2023 08:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=iG2Fts2asHD+qwXTfLCeAde2rG99eTPoF5JeF02ozH4=; b=LG4p9ASAaFB7S6yBM7VxRNB2w2mgrcE4DY/1/hqFWVDIFvgn9p2KT3YERDiGCf+/9r VFrdTkXSdMcfC6SMhj5kztpG2uB/6YoRGV8reIdJtZF8XppwWvkgNp5o2qj9SFbc3yPz ogZxc9N1SrAay6M73mCIrwO7dPaqMYcuxBnYTH4Qk+ed9XFsff/PIj4WYJyK28D6OYan eig7Su0cKAXigQTR9N3kbPev1hgIUG01gtB5GXgi5tVywsfpwl21sEh+vg95fQj4KHpA tvn0neGDuTEjkntZwKgDSJDPpXNwaAyjOlkPDHH5GeJee9P6vOi8Br5PQWoIBGIfhgFF L15w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iG2Fts2asHD+qwXTfLCeAde2rG99eTPoF5JeF02ozH4=; b=dFRIIC+FUboI+NkSAaXBguTHrG6f/+1T1n9CpWJc0OTIOZoie/B4iyUsEny+W5VOn6 VEBDnsu5ZcdW5hVZtx6f2GLo+x0jZzrKER6DJ180Wnj3Oift32lVGG5lmP0PYAOmR/Bg ce9rCkMni0scEO3MjYLFpG13RXIGkWgjLW3kZ0jb81KF4F9+Sbxo0ANsBOBJJ0/hH46z 1uz0ec6oFSq8kIC25by+wUOpK2Hgr0dWL49wJ8kcuQR/wyaGRYtnQxKgpIUQFF0yXeF0 XQvOYe206RPgDWq7qt7y9Ve7P0GGTHSrN/6qM8aVHIhmlJtUOJPd9s9Y86GRqXb1MWNH OYrg== X-Gm-Message-State: AO0yUKVd6BRPdp5CayEbzELEcjVxJ2t730i/uzJ8dL9P8bO0662XmQu4 ca1Se5JlwliPzXZdvu44tNoQQW6ESU3K5A== X-Google-Smtp-Source: AK7set8GnonB8f9JYmYbfAA0eUFvJS3Y+Vm5ww+g0wEovdmTuOb4ogyvQz8WFe2NKCJp2z2soxp/Fw== X-Received: by 2002:a05:6602:2253:b0:712:8099:bdfe with SMTP id o19-20020a056602225300b007128099bdfemr14157190ioo.13.1675702428219; Mon, 06 Feb 2023 08:53:48 -0800 (PST) Received: from washu-v4 (c-174-51-139-101.hsd1.co.comcast.net. [174.51.139.101]) by smtp.gmail.com with ESMTPSA id y15-20020a6bd80f000000b00704c767ead9sm3278517iob.28.2023.02.06.08.53.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 08:53:47 -0800 (PST) From: Katherine Cox-Buday References: <20230118014510.19320-1-cox.katherine.e@gmail.com> <878rhkyney.fsf@gmail.com> Date: Mon, 06 Feb 2023 09:53:46 -0700 In-Reply-To: <878rhkyney.fsf@gmail.com> (Katherine Cox-Buday's message of "Mon, 30 Jan 2023 09:53:09 -0700") Message-ID: <87edr2zqed.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1675702477; a=rsa-sha256; cv=none; b=Msnzr2QLrYh01S2Yw/GcLNJaSTjrqLuTdFibjLtaXPqeFLcyXdCHqQcErDSaHemdnPyqqC wpxueFYWYB37Xk/1wUlV063KM+J0DxH3DbaV1gE0Wv+G9l70Nu3GBL18yQj9XYvDGyp8rn oHTwVZBfW/xyoNynpfwZB8RmaJN44JKjmMCKZuF4o4uJqxRSrLNuxYIee03VTIyPDbKbAA eMiwFZfobmhvrzIcWD3kUhdBdA26ZTHKiqlZGujFl7UTb4/ltZBrUMGXWxrpkZiswArnvn KITN/5XDyTQZZkX6iAc18y7WP1gscL3nHGmYHZGAZVlo0p1eR+Ym06BNqPZ3TA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LG4p9ASA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1675702477; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=iG2Fts2asHD+qwXTfLCeAde2rG99eTPoF5JeF02ozH4=; b=IYl4Haze6F3nXbifFrIT7b/q2/vs0emTUEO8Dtgu8I6h+jT1c/udpFjXWl5HIoG4dP+x10 X9GU4Wqp+BFzw+PCNvQXUeIR0NKDomnUjgFcoJDYEouKxDN83wo/Kzb5k2T21k00zVq9Pn LpB7xPHF3gfbU7wW+ozvn+PnoqVU79i5gJyG75lBgPFhkqN8yN107IySTeM/1kaQk7VhMs yBZJcSb+DkUAw4TJ71NKcBvxq29ogbMPHLnV6gVZIi6t99xIdCdn9oGH6oewcV0FPlLSnL c2s9JVzvCFBgtlSsVMJSQY3ZjCQ72e9xKC9SHoyJ6o9lcM7iUImtpvmt7fjIbw== Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=LG4p9ASA; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-Migadu-Spam-Score: -0.49 X-Spam-Score: -0.49 X-Migadu-Queue-Id: D46D82FE18 X-TUID: 3kx39UStCxUN Katherine Cox-Buday writes: > Katherine Cox-Buday writes: > >> This is a patch series to add the gopls package. >> >> I haven't contributed to many projects which use the e-mail flow, so >> hopefully I'm doing this correctly. Please feel free to make >> suggestions if not! >> >> Some of the diffs are a little busier than I'd like for version bumps. >> This is due to running `guix style` over everything. >> >> For all of the packages I have: >> >> . Run guix style >> . Run guix lint >> . Built 2x >> . Checked that the change is in the correct branch >> . Built all dependencies >> . Built the repository >> >> Katherine Cox-Buday (25): >> gnu: go-golang-org-x-sync: Update to 0.1.0-1.8fcdb60. >> gnu: go-golang-org-x-mod: Update to 0.7.0. >> gnu: Add go-golang-org-x-exp. >> gnu: Add go-github-com-jba-printsrc. >> gnu: Add go-github-com-google-safehtml. >> gnu: Add go-github-com-jba-templatecheck. >> gnu: go-github-com-google-go-cmp-cmp: Update to 0.5.9. >> gnu: go-github-com-pkg-diff: Update to >> 0.0.0-20210226163009-20ebb0f2a09e. >> gnu: go-github-com-rogpeppe-go-internal: Update to 1.9.0. >> gnu: gopkg-in-errgo-fmt-errors: Rename package to >> go-gopkg-in-errgo-fmt-errors. >> gnu: go-golang-org-x-tools: Update to 0.5.0. >> gnu: Add xurls. >> gnu: Add go-mvdan-cc-xurls. >> gnu: Add misspell. >> gnu: Add go-github-com-client9-misspell. >> gnu: Add go-github-com-google-go-cmdtest. >> gnu: Add unparam. >> gnu: Add go-mvdan-cc-unparam. >> gnu: Add govulncheck. >> gnu: Add go-golang-org-x-vuln. >> gnu: go-github-com-burntsushi-toml: Update to 1.2.1. >> gnu: go-honnef-co-go-tools: Update to 0.3.3. >> gnu: Add gofumpt. >> gnu: Add go-mvdan-cc-gofumpt. >> gnu: Add gopls. >> >> gnu/packages/configuration-management.scm | 2 +- >> gnu/packages/golang.scm | 695 ++++++++++++++++++---- >> 2 files changed, 578 insertions(+), 119 deletions(-) >> >> >> base-commit: 5c921977179489caef4a9e54ada6696fc86d2f0b > > Hello Guix! Acknowledging that everyone are volunteers, and busy (guilty > myself), this is a humble request for a review of this patch-series I > made two weeks ago so that it doesn't bit-rot. > > I have a `gopls` home service[1] waiting to be proposed after this > patch-series is merged. > > Thank you very much! > > [1] > https://github.com/kat-co/guix-channels/blob/upstream-staging/upstream/home/services/gopls.scm > > P.S. I think I am following etiquette for review reminders (i.e. waiting > long enough, bringing this over to guix-devel), but I was having trouble > finding examples. If I haven't waited long enough, or have reminded in > the wrong way, please give me feedback. Hello, this is another humble request for review :) It looks like QA is passing, and I think I did a pretty thorough job of making sure things follow standards and will apply cleanly. -- Katherine