From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id WKFmDk8eGGQicwEASxT56A (envelope-from ) for ; Mon, 20 Mar 2023 09:50:23 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id eKFzDk8eGGQGDQAA9RJhRA (envelope-from ) for ; Mon, 20 Mar 2023 09:50:23 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E72A1FD4A for ; Mon, 20 Mar 2023 09:50:22 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peBDR-0002zr-21; Mon, 20 Mar 2023 04:50:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peBDO-0002zb-VQ for guix-patches@gnu.org; Mon, 20 Mar 2023 04:50:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peBDO-0002vr-Jk for guix-patches@gnu.org; Mon, 20 Mar 2023 04:50:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peBDO-0002Up-AC for guix-patches@gnu.org; Mon, 20 Mar 2023 04:50:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62243] [PATCH] gnu: guile-3.0-latest: Add patch for invalid unicode handling. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 20 Mar 2023 08:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62243 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines Cc: 62243@debbugs.gnu.org Received: via spool by 62243-submit@debbugs.gnu.org id=B62243.16793021519532 (code B ref 62243); Mon, 20 Mar 2023 08:50:02 +0000 Received: (at 62243) by debbugs.gnu.org; 20 Mar 2023 08:49:11 +0000 Received: from localhost ([127.0.0.1]:53646 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peBCY-0002Tg-JB for submit@debbugs.gnu.org; Mon, 20 Mar 2023 04:49:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peBCW-0002TU-ND for 62243@debbugs.gnu.org; Mon, 20 Mar 2023 04:49:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peBCP-0001xs-TR; Mon, 20 Mar 2023 04:49:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=cnZ57mHDgYED0/2GpfI3HPLw3hVKFp9MNxYRNDwO75M=; b=Xb7wvhwFJ3susKs3b85L W8kslqLHZnke5liL4WuMYplkbps0E0O0AjP1q7XAvYFClBjBsQYpMuWKRXqOCbZkLMhBrITOCMb8Z pSiAzTlaDJ52LmdCrGmzeZIN7DC9zDKpchVjPOajhTA+WCxBN4+w/Sx+ntIdKwTidBL+VmAnWx0GI Lpm+UQrljD8pjcLIGvxQEwvMlQIQUAP/6GYRKSMZBFz/a3PG44UzVbkYbOxD4afjNLweAI32FmDTG iFo8DpHURckvc8ty6VoXdDFaoDQ8hQR7Vxk65ZaAy7PUmp9CvdMIrp5G9z2IHdzS1eeOS2IvwDTSJ z7KQqgVTtLrVpQ==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peBCP-0002CL-7f; Mon, 20 Mar 2023 04:49:01 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20230317145828.20404-1-mail@cbaines.net> Date: Mon, 20 Mar 2023 09:48:59 +0100 In-Reply-To: <20230317145828.20404-1-mail@cbaines.net> (Christopher Baines's message of "Fri, 17 Mar 2023 14:58:28 +0000") Message-ID: <87edpjq03o.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Xb7wvhwF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679302223; a=rsa-sha256; cv=none; b=nfcc8dvwRxHp69FIg1a/B2klNTSCPrJw+n0hYJWIoifJ+pg4FY6YeDI0ebGjHgY0npEDnD Tj4CLUlovoADJLKqa7aBc1UN4SYSbu9c3dQ1jdqXZIQh2HvxTPRAw2LpSCUWPX8ZOTTPsO +iHX/rqiUukEEe7HY/lDK9pFtwag3oaCiA2iJxuaocNmciKI119aS/tIUWaa+nYIPhBH// yxggJ72mozN42Ha2ih9FdKB8PLKcSdVoK0eTKwbOkJbRrbWy786F5e+zhXCRSliHc1SO8O h2TT165RptdZSk7WYDOE94OLenRo/pboyeClQqIrxsY/Nj9HNqnKDEPGHA984Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679302223; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cnZ57mHDgYED0/2GpfI3HPLw3hVKFp9MNxYRNDwO75M=; b=Q9GHieXw2NrbpxW6aARFeYqXy34MJUlKl7S1Hx2pOkDyVGxCPvxybgcAb1xX1IcUmlGkVi pYU+Aqr6Ir7tQexwFUPwh6ArIhJGiASgJ0VKoaupFhN6SNBGWrkbYM4ZtY0JiiHb6r3YPM 9USjfqtcsaBU5150wJ4VPdD6h50w2JBM9qYzJtnJ1XJmNMOBoYDe874DmGarKI1S5hOKUY ZZQrrRAL8iGLUTFz19RV1ds3yApXMjaPbdWcf41XvBCDK6FmGHFF8gXaUjbgdUo43e+vpM sBxm8e3wBWV2gZIdZPp/8OLdBbSmHKj0hOVAaGy7lqrd6MrYGmSrrrYE73cSCg== X-Migadu-Spam-Score: -4.15 X-Spam-Score: -4.15 X-Migadu-Queue-Id: 3E72A1FD4A X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=Xb7wvhwF; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org X-TUID: JvBHS/zgNB4S Hi Chris, Christopher Baines skribis: > This patch fixes handling of invalid unicode when using suspendable ports. > > As the build coordinator agents use suspendable ports, this will fix issu= es > with building things where the log output contains invalid unicode. > > * gnu/packages/patches/guile-fix-invalid-unicode-handling.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/guile.scm (guile-3.0-latest)[source]: Use it. [...] > +From 31a1c3c4783e8e66b93500737f23f209d8115f77 Mon Sep 17 00:00:00 2001 > +From: Christopher Baines > +Date: Fri, 17 Mar 2023 12:48:39 +0000 > +Subject: [PATCH] Fix some invalid unicode handling issues with suspendab= le > + ports. > + > +Based on the implementation in ports.c. I don't understand what this > +code is really doing, but the suspendable ports implementation differs > +from the similar C code for a couple of inequalities. > + > +* module/ice-9/suspendable-ports.scm (decode-utf8, bad-utf8-len): Flip a > +couple of inequalities. > +* test-suite/tests/ports.test ("string ports"): Add additional invalid > +UTF-8 test case. Good catch! Could you please submit it to bug-guile@gnu.org first, perhaps with a higher-level example based on what you have in showing how to reproduce the issue? Then ideally we=E2=80=99d use the new release in Guix; if that would be inconvenient, for instance because of delays, that would at least allow us to refer to the upstream commit/issue in Guix. Don=E2=80=99t hesitate to ping me on IRC to make sure this doesn=E2=80=99t = stall. Thanks! Ludo=E2=80=99.