From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id aPCmHiFfGmQsVgEASxT56A (envelope-from ) for ; Wed, 22 Mar 2023 02:51:29 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 4CZxHiFfGmQQhQAAauVa8A (envelope-from ) for ; Wed, 22 Mar 2023 02:51:29 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 380A06592 for ; Wed, 22 Mar 2023 02:51:29 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pend3-0005Ap-FQ; Tue, 21 Mar 2023 21:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pend1-00059z-Eh for guix-patches@gnu.org; Tue, 21 Mar 2023 21:51:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pend1-0003IN-5c for guix-patches@gnu.org; Tue, 21 Mar 2023 21:51:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pend1-0004BM-15 for guix-patches@gnu.org; Tue, 21 Mar 2023 21:51:03 -0400 Subject: bug#61018: [PATCH 0/2] Add pcsc-tools, and missing dependency perl-pcsc Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Wed, 22 Mar 2023 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61018 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jake Leporte Cc: 61018-done@debbugs.gnu.org Mail-Followup-To: 61018@debbugs.gnu.org, maxim.cournoyer@gmail.com, jakeleporte@outlook.com Received: via spool by 61018-done@debbugs.gnu.org id=D61018.167944982715987 (code D ref 61018); Wed, 22 Mar 2023 01:51:02 +0000 Received: (at 61018-done) by debbugs.gnu.org; 22 Mar 2023 01:50:27 +0000 Received: from localhost ([127.0.0.1]:33036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pencQ-00049l-G8 for submit@debbugs.gnu.org; Tue, 21 Mar 2023 21:50:26 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:41709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pencO-00049X-Gt for 61018-done@debbugs.gnu.org; Tue, 21 Mar 2023 21:50:25 -0400 Received: by mail-qt1-f169.google.com with SMTP id t9so21046472qtx.8 for <61018-done@debbugs.gnu.org>; Tue, 21 Mar 2023 18:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679449819; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=hCt9ICU1JFHCOrFKfYShCgkS8t9hGcr7ZYwPfgkv36A=; b=mn3ubp5ZtPY4+mskZNOLObBWcBjgCveGgX3VxADiE4ZPmDsC1oh5y0dL7y8Ur0N99J fhOW8ZtGB/J7n9IdAQW1Th/WbXqHlOIN1mz9+8hWXjWzQ6FtHX/DEKsaEu4Ds0AfSN1d bydDUe/DTkey/64Wf4At23nvx3dNwhURggjFUlScL0gtrICRnZN+ukZihMo9bW61E32h zBvH8HPiKLc7ApC2JFN3liZIHeoY+tWH9U0mMQIvDVNtVW0FOPCMiBJYIGeZLu6q1GzI oMs7Js1nUZcRuvvH+0ZYSX2pBmlEMlFG6icMTl0Ij/ni9x5MlJkuEgaIIBdL5fbREJuG e3pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679449819; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hCt9ICU1JFHCOrFKfYShCgkS8t9hGcr7ZYwPfgkv36A=; b=2nKzpseMVoHUhJQ9/UeeBEp20SXvpFuN/tpBGabquju5caP70w3Gdp74rlVwjmNUWF z/xwgErU5Opf1VOTGbb28DYiMm6dc/Ckv33/MKwYIv6mwXZIvy/vz8/qcqtnArqm7pbA Epcxq0Mm7r/IQ6EcUMv14U/oDwD61SjUIqPZju1Dq8d2Dsq9sAM168lw3/hRwNHviLFM a9mqyI44GWznMTmt4mVsIZPoxAO6UDOiRjfT7XPBFwNcYEuF3BRT8J9PN9tv/FVg/EOy 6U8UXQUUa6GGOlAp50lAk7TgbBY+waD+aOPDzK1XP4s3ct0oZk+5tgsGYuZXxzhCMZbD atjQ== X-Gm-Message-State: AO0yUKWYlai/d8g4KPX/pJx5+SUBU7J8mKIV8PtiQas4UvTBDI/BjkXl UL2LCLPdUWZWgqcMRgD5IT8/WAT6sE8d9A== X-Google-Smtp-Source: AK7set9qt/nD7E6RhXIf+yZ1dsPqlZACW3E3q1rxOWHkoskosiMc6mTZ5sajGo0Nf5YpGdLmUTTCMQ== X-Received: by 2002:a05:622a:146:b0:3a7:e2df:e868 with SMTP id v6-20020a05622a014600b003a7e2dfe868mr3909459qtw.41.1679449818767; Tue, 21 Mar 2023 18:50:18 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id b126-20020ae9eb84000000b007468b183a65sm4735144qkg.30.2023.03.21.18.50.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 18:50:18 -0700 (PDT) From: Maxim Cournoyer References: Date: Tue, 21 Mar 2023 21:50:17 -0400 In-Reply-To: (Jake Leporte's message of "Sun, 5 Mar 2023 19:30:26 -0600") Message-ID: <87edphk10m.fsf_-_@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679449889; a=rsa-sha256; cv=none; b=BPzr06Kdx+5mfmnxiFYYLehX1CHejrBvlcpFEKjLHbR3qAz8CGILNTNjX0NDY7WluNLoaL YsHPsszfNyGlLa/z4jjnYtTJ2Yz8JRsG70mKNiUhWpvH0E9Dvu62UcPcc1pBHmWIuggPCV E5yyn2+TgtgS178KMy61ZpHOcTha/zW8SbXaX5iqXekLkGOnBRXSR4hnno6InXFDdSHFzm MgGtF2OMIDvQ+2Xl/MqxBsDF+LhsACsY4CTmHWdv2h4S5TOn6V89lX/boOgy6ziqAXW+1A ZPPDv7zun1XNLLYx0SZal9kRd8/HcAllIlkpgRzFmUZwEI+tWeS0/ong5AXACw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mn3ubp5Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679449889; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=hCt9ICU1JFHCOrFKfYShCgkS8t9hGcr7ZYwPfgkv36A=; b=qe6jy1mP2Jktu9FeyYbJtky1+vYka4Lxpu+Qjv7pKDkVexLx+5pekJbEksGJ54nGZB9RwK bPMxnTrmSp0doFDOo8MpypZNlYezVdru0kTwh/7TuqPDP9kaJCyFPdt0GoxoC9fjUmdOrj KJ7bzQZ47MrmgSLl7jaxAxa6BkA6rp6SuHWYjrqzd1u0vFRr+NGGR2UcTzS3hI2OaUL4ON NdeWvGK4vShvMz4MeCohDXHAkPvOIKmvfKfXjS6Lvpw29RtJ417pkFzT2Jf+bwN3bX1wUc fI1jvQ/kb4XOu/IP337F94isCWOFp4Aqa/V6QhOhbuHYA9o09DoP6iPV2RMJ0A== X-Migadu-Spam-Score: 5.75 X-Spam-Score: 5.75 X-Migadu-Queue-Id: 380A06592 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=mn3ubp5Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: +zfUQ07BgtfB Hello, Jake Leporte writes: > * gnu/packages/perl.scm (perl-pcsc): New variable. > --- > gnu/packages/perl.scm | 36 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm > index b6fb81e..a1a9983 100644 > --- a/gnu/packages/perl.scm > +++ b/gnu/packages/perl.scm > @@ -86,6 +86,7 @@ (define-module (gnu packages perl) > #:use-module (gnu packages python) > #:use-module (gnu packages readline) > #:use-module (gnu packages sdl) > + #:use-module (gnu packages security-token) > #:use-module (gnu packages textutils) > #:use-module (gnu packages video) > #:use-module (gnu packages web) > @@ -12269,6 +12270,41 @@ (define-public perl-path-iterator-rule > arduous to type for one-liners.") > (license license:asl2.0))) >=20=20 > +(define-public perl-pcsc > + (package > + (name "perl-pcsc") > + (version "1.4.14") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "mirror://cpan/authors/id/W/WH/WHOM/pcsc-perl-" vers= ion > + ".tar.bz2")) > + (sha256 > + (base32 > + "17f6i16jv6ci6459vh6y3sz94vgcvykjjszcl4xsykryakjvf8i7"))= )) > + (build-system perl-build-system) > + (arguments > + (list > + ;; The tests for this package require access to a > + ;; card reader with a card inserted, so they won't be > + ;; possible to run in the build environment > + #:tests? #f > + #:phases #~(modify-phases %standard-phases > + (add-after 'unpack 'patch-dlopen > + (lambda* (#:key inputs #:allow-other-keys) > + (substitute* "PCSCperl.h" > + (("libpcsclite.so.1") > + (search-input-file inputs > + "/lib/libpcsclite.so.1= ")))))))) > + (native-inputs (list pkg-config)) > + (inputs (list pcsc-lite)) > + (synopsis "Perl library for PC/SC") > + (description > + "This library allows communication with a smart card using PC/SC fr= om a Perl > +script.") > + (home-page "https://pcsc-perl.apdu.fr/") > + (license license:gpl2+))) > + I've also installed this one with the following changes: modified gnu/packages/security-token.scm @@ -17,6 +17,7 @@ ;;; Copyright =C2=A9 2022 John Kehayias ;;; Copyright =C2=A9 2022 Petr Hodina ;;; Copyright =C2=A9 2022 Denis 'GNUtoo' Carikli +;;; Copyright =C2=A9 2023 Jake Leporte ;;; ;;; This file is part of GNU Guix. ;;; @@ -278,13 +279,12 @@ (define-public pcsc-tools "\"/usr/local/pcsc/smartcard_list.txt\", " "\"/usr/share/pcsc/smartcard_list.txt\", " "\"/usr/local/share/pcsc/smartcard_list.txt\"")) - (string-append "\"" - #$output + (string-append "\"" #$output "/share/pcsc/smartcard_list.txt\""))) (substitute* "ATR_analysis.1p" - (("^([.]IR [.]/) ,\n$" _ cwd) + (("^(\\.IR \\./) ,\n$" _ cwd) (string-append cwd "\n")) - (("^[.]I /usr/local/pcsc/\n$") + (("^\\.I /usr/local/pcsc/\n$") "") Because \\. is more widespread (conventional) than [.] in the guix code base. (("/usr/share/pcsc/\n$") (string-append #$output "/share/pcsc/\n"))))) @@ -292,26 +292,22 @@ (define-public pcsc-tools (lambda _ (for-each (lambda (prog) - (wrap-program (string-append #$output - "/bin/" - prog) - `("PERL5LIB" =3D - (,(getenv "PERL5LIB"))))) + (wrap-program (string-append #$output "/bin/" prog) + `("PERL5LIB" =3D (,(getenv "PERL5LIB"))))) '("ATR_analysis" "gscriptor" "scriptor")) - (wrap-program (string-append #$output - "/bin/gscriptor") - `("GI_TYPELIB_PATH" =3D - (,(getenv "GI_TYPELIB_PATH"))))))))) + (wrap-program (string-append #$output "/bin/gscriptor") + `("GI_TYPELIB_PATH" =3D (,(getenv "GI_TYPELIB_PATH"))= ))))))) Tightened the indentation a bit (I guess this was 'guix style', which doesn't always produce perfect results). (native-inputs (list autoconf automake libtool gnu-gettext pkg-config)) - (inputs (list bash-minimal ;for wrap-program + (inputs (list bash-minimal ;for wrap-program perl - perl-pcsc perl-gtk3 - pcsc-lite)) - (synopsis "Tools for use with smart cards and PC/SC") - (description - "This package provides @code{pcsc_scan}, @code{ATR_analysis}, @code{s= criptor}, -and @code{gscriptor}.") + pcsc-lite + perl-pcsc)) + (synopsis "Smart cards and PC/SC tools") I streamlined the synopsis a bit, + (description "This package provides the @command{pcsc_scan}, +@command{ATR_analysis}, @command{scriptor}, and @command{gscriptor} comman= ds, +which are useful tools to test a PC/SC driver, card or reader or send comm= ands +in a friendly environment (text or graphical user interface).") (home-page "https://pcsc-tools.apdu.fr/") and expounded the description, changing @code to @command. Thank you! --=20 Maxim