From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sAp+CAtuPWRojQAASxT56A (envelope-from ) for ; Mon, 17 Apr 2023 18:04:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oACOCAtuPWTnbwEA9RJhRA (envelope-from ) for ; Mon, 17 Apr 2023 18:04:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8C6B0836C for ; Mon, 17 Apr 2023 18:04:26 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1poRKn-00076w-9V; Mon, 17 Apr 2023 12:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1poRKl-00076O-8p for guix-patches@gnu.org; Mon, 17 Apr 2023 12:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1poRKl-0001aM-0H for guix-patches@gnu.org; Mon, 17 Apr 2023 12:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1poRKj-0002Xi-Rf for guix-patches@gnu.org; Mon, 17 Apr 2023 12:04:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#59188] [PATCH v7 16/20] gnu: emacs-nodejs-repl: Build with node-lts. Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 17 Apr 2023 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59188 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , 59188@debbugs.gnu.org Cc: Andrew Tropin Received: via spool by 59188-submit@debbugs.gnu.org id=B59188.16817474139728 (code B ref 59188); Mon, 17 Apr 2023 16:04:01 +0000 Received: (at 59188) by debbugs.gnu.org; 17 Apr 2023 16:03:33 +0000 Received: from localhost ([127.0.0.1]:55874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poRKH-0002Wq-1Z for submit@debbugs.gnu.org; Mon, 17 Apr 2023 12:03:33 -0400 Received: from mail1.fsfe.org ([217.69.89.151]:51474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poRKF-0002Wb-2r for 59188@debbugs.gnu.org; Mon, 17 Apr 2023 12:03:31 -0400 From: Jelle Licht DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fsfe.org; s=2021100501; t=1681747407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5EepZtILDsMrVGzFZL0MiCi4REbedW6pIYXICournn8=; b=uvmibGJ8G30KlQT8YfagOJt6mOvIzjgIXgzpKM54WcDCk4OhUNcELF/8AoX80ni9K0CBiN A2evPXvf42raI2flPmNrFa2dTd8lYfJMOrlm+70P7kdqiArbGbwP2w1ph43L+R5nG4QhgY EOiLfnQiwJckL28T2Ld3WJjv/mU67D0= In-Reply-To: <9a1f88d3c90e7518a91fe7f76569b43be84bddfc.camel@gmail.com> References: <4809ad315243309fdef56f2860032e8f2573c6ec.1681742871.git.jlicht@fsfe.org> <9a1f88d3c90e7518a91fe7f76569b43be84bddfc.camel@gmail.com> Date: Mon, 17 Apr 2023 18:03:26 +0200 Message-ID: <87edoiv6lt.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=uvmibGJ8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1681747466; a=rsa-sha256; cv=none; b=apWg7Mg0uEBK4/+9/3JS5jtSaoRJ/mV1KaLmXgmVxWfYhwFz/Hg9fsFsuWN0wybvO6Tb+H wCWvpt/rLIDNp8MstH+A3/N045ywMNLH8yXh25j/yeX4VfeKTPgK0DNqGLQYNp247ZqpTV vJ8ELAMe2vfiLm1K2blzPDJiH49PPRbceigV7103U1R8VxiF8V2+RV7fTQ7a9+Lndb7k1+ aO2jignRVpRuYgRLnMD4zE+u3QQrdve3TMZ+M7S8WK5j58xo/Np/43HRIAHf520CN9ZN8T Q4XJQqtRiCUHoWNMnXO26jYGuPHjyd87D7faUKFoXVip1W1MWPm1P/AHWbZsHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1681747466; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=5EepZtILDsMrVGzFZL0MiCi4REbedW6pIYXICournn8=; b=Xc7jcwc+p3coCwmkxXdYZMq5pd7McuCB7Y2ktFM6wpjwDPeih/OT0csyRctDAUxlcrPSWM 7UpuZPVX3a5dLGDvNcwb1iBSt0H+F+kivkHO1cjnOVj8HDyjMsTx9Mx8CzyDMkPbD8N8nn ibR8nqEUDgG1jWNF9tzybvmGBWpIwJSX8sDTHYufbfMckrEr8d030NiuXmy8jXKl2cOyxy jXqrfjT5rCJrQJuS5D8f8oUlPd4OnDQmJrFCXj7rACnhS1mnUWVLp2Xp4bykTKZlOWkLvm NVfAqy/vNXbJYzjGszte020Zt8Ff3sTX/yDdnDvP9iBHI3hzs/eqAzV4a2cRWg== X-Migadu-Spam-Score: 5.49 X-Spam-Score: 5.49 X-Migadu-Queue-Id: 8C6B0836C Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fsfe.org header.s=2021100501 header.b=uvmibGJ8; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fsfe.org (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn0.migadu.com X-TUID: m52wtehR+30H Liliana Marie Prikler writes: > Am Montag, dem 17.04.2023 um 16:51 +0200 schrieb jlicht@fsfe.org: >> From: Jelle Licht >>=20 >> * gnu/packages/emacs-xyz.scm (emacs-nodejs-repl)[inputs]: Replace >> NODE by NODE-LTS. > I think lowercase would be better. Addressed locally, and will take into account when applying.=20 > >> --- >>=20 >> (no changes since v1) > Where is v1? There is no v1. This blurb is generated by patman, I do not know how to disable this. Tips very much welcome. Since I started using patman, I've listed changes in each cover letter instead, as that's much easier to manage. >> =C2=A0gnu/packages/emacs-xyz.scm | 2 +- >> =C2=A01 file changed, 1 insertion(+), 1 deletion(-) >>=20 >> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm >> index c1748e7f36..7282c03dfe 100644 >> --- a/gnu/packages/emacs-xyz.scm >> +++ b/gnu/packages/emacs-xyz.scm >> @@ -12803,7 +12803,7 @@ (define-public emacs-nodejs-repl >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 >> "0a5mmg3cmdi73giblp07ksl06xzl9nb2m3f96ny4r3rv0ar3v1bx")))) >> =C2=A0=C2=A0=C2=A0=C2=A0 (build-system emacs-build-system) >> =C2=A0=C2=A0=C2=A0=C2=A0 (inputs >> -=C2=A0=C2=A0=C2=A0=C2=A0 (list node)) >> +=C2=A0=C2=A0=C2=A0=C2=A0 (list node-lts)) > LGTM, I guess. Is it expected that node-lts will see fewer rebuilds > than the other node package going forward? No, if anything the hope is that there will be more going on with the node-lts package :-). Our current "node" package should not be used, as it's an ancient (and unsupported) version. Restructuring the node/node-lts/node-bootstrap triad (and making sure older versions are not exposed to users) will be my next node-related venture. > Cheers Thanks for the review! - Jelle