From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id OP8MNGr0Q2S0GgEASxT56A (envelope-from ) for ; Sat, 22 Apr 2023 16:51:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uIfXM2r0Q2SdeAAAauVa8A (envelope-from ) for ; Sat, 22 Apr 2023 16:51:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A9AC39727 for ; Sat, 22 Apr 2023 16:51:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqEZt-0006Sh-6U; Sat, 22 Apr 2023 10:51:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqEZq-0006SH-VQ for guix-patches@gnu.org; Sat, 22 Apr 2023 10:51:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqEZq-0002Tr-HI for guix-patches@gnu.org; Sat, 22 Apr 2023 10:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqEZp-0005QP-RM for guix-patches@gnu.org; Sat, 22 Apr 2023 10:51:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#63015] [PATCH] gnu: Add emacs-gemini. Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Apr 2023 14:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63015 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Evgeny Pisemsky Cc: 63015@debbugs.gnu.org Received: via spool by 63015-submit@debbugs.gnu.org id=B63015.168217501320696 (code B ref 63015); Sat, 22 Apr 2023 14:51:01 +0000 Received: (at 63015) by debbugs.gnu.org; 22 Apr 2023 14:50:13 +0000 Received: from localhost ([127.0.0.1]:43797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqEZ3-0005Nk-Df for submit@debbugs.gnu.org; Sat, 22 Apr 2023 10:50:13 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqEZ0-0005NP-9u for 63015@debbugs.gnu.org; Sat, 22 Apr 2023 10:50:11 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 3A99A60006; Sat, 22 Apr 2023 14:50:02 +0000 (UTC) From: Nicolas Goaziou References: <87h6t83x2c.fsf@pisemsky.com> Date: Sat, 22 Apr 2023 16:50:01 +0200 In-Reply-To: <87h6t83x2c.fsf@pisemsky.com> (Evgeny Pisemsky's message of "Sat, 22 Apr 2023 15:45:15 +0300") Message-ID: <87edoc0y5i.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682175082; a=rsa-sha256; cv=none; b=RmBzX2atoqs7/9Eu8+y0+M/60njTkYgt8FTJ+MZm/61jrksBuq+y1x65APhEK1RvHFsrJl K/YxNGxwpP3e1Byd0gVOfFmLA35pn5gWOYiGE5AQ19gTQr9+zbPw/UcMLD+SJFT2BACenO 0DldDzaTSfRp94172IghkFV7nlHM7Brn6NWJO1BC9QazZ9Vt3Xvdex6LRs3/pCvBYeDPDm GJb/U07PH1cHbPEKbe8kr6X7Blhz1Ky7XpK0iGz3hirZXARKmptnP1yzhL5o0W2a7uRiiL YkA4QZr5pISEzX6CYco2zx4BTybyPQMW2E/I0FL27k7IFNj1M6uE+uUGiYFtvA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682175082; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=PdCOusLiSEhq2qW5XHnXz8T8FpE2q51W/VZxf1G/ZXo=; b=UUN96l1Xb3GjWER8cwNbmdYnSp6eMcX7fojn+RH4JJ6WuSG9sGSydVV9PnXTFagBLIN8hb SZU2jzj7tyMeTqdkslxOrFLOlriUUk80y0V4mB5wqXhWDWklEHrK6H6JtKvlnEtycOBax4 kLoAj1oCKuL/tpGgb727ISyqSJyvf27or6R41TOPSzuS34eyySJjeoHBJ48UuzVMKSm45L ZJNdiX+YnA+uVcue4R2cIDblHXSWZ8/6maZCZT5Aer0tF+wjXMw4gtQYnkmprC3X+ig96x K9rKB0dSQL3qOcJKyZtE0pBgdH+hvX5jIRp9mR4fLAk9G6GdMY/T7/Q9Nu+efg== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.31 X-Spam-Score: -3.31 X-Migadu-Queue-Id: A9AC39727 X-TUID: BZpPniuoMgR8 Hello, Evgeny Pisemsky writes: > From 7c2de9e0137927140df056f20cb8de635c8aa4ce Mon Sep 17 00:00:00 2001 > From: Evgeny Pisemsky > Date: Sat, 22 Apr 2023 15:00:00 +0300 > Subject: [PATCH] gnu: Add emacs-gemini. > > * gnu/packages/emacs-xyz.scm (emacs-gemini): New variable. Thank you. Some comments follow. > +(define-public emacs-gemini > + (let ((version "1.2.0") > + (revision "0") > + (commit "a7dd7c6ea4e036d0d5ecc4a5d284874c400f10ba")) This particular commit you're using is actually a version bump. Since upstream does not tag such bumps, I suggest to make it the exact "1.2.0" version, instead of "1.2.0-0.a7dd7c6". IOW, you can drop revision binding, and version too. > + (package > + (name "emacs-gemini") > + (version (git-version version revision commit)) Here (version "1.2.0") is enough. > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.carcosa.net/jmcbray/gemini.el.git") Nitpick: I suggest to drop the ".git" suffix for consistency with other packages. > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1pvlk56mhh4xh4gwzqldfk79jsjbcpivv5scd9811pv3afc30gsx")))) > + (build-system emacs-build-system) > + (home-page "https://git.carcosa.net/jmcbray/gemini.el") > + (synopsis "Syntax highlighting for text/gemini") > + (description > + "This is a very simple syntax-highlighting mode for text/gemini documents. > +Currently, support is not complete, but it should be enough to help with basic > +documents.") > + (license license:agpl3+)))) Otherwise LGTM. Could you send an updated patch? Regards, -- Nicolas Goaziou