From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +EeoOgjzYWS9rgAASxT56A (envelope-from ) for ; Mon, 15 May 2023 10:53:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6FafOgjzYWQn5gAA9RJhRA (envelope-from ) for ; Mon, 15 May 2023 10:53:28 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CAF73208ED for ; Mon, 15 May 2023 10:53:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyTxF-0002fC-LU; Mon, 15 May 2023 04:53:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyTx1-0001oq-8c for guix-patches@gnu.org; Mon, 15 May 2023 04:53:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyTx0-00068D-SW for guix-patches@gnu.org; Mon, 15 May 2023 04:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyTx0-0005Nn-Oh for guix-patches@gnu.org; Mon, 15 May 2023 04:53:02 -0400 Subject: bug#63416: [PATCH 0/2] Fix more derivation builder gexp issues. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Mon, 15 May 2023 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 63416 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 63416-done@debbugs.gnu.org Mail-Followup-To: 63416@debbugs.gnu.org, mail@cbaines.net, mail@cbaines.net Received: via spool by 63416-done@debbugs.gnu.org id=D63416.168414073520596 (code D ref 63416); Mon, 15 May 2023 08:53:02 +0000 Received: (at 63416-done) by debbugs.gnu.org; 15 May 2023 08:52:15 +0000 Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyTwE-0005M8-Hp for submit@debbugs.gnu.org; Mon, 15 May 2023 04:52:14 -0400 Received: from mira.cbaines.net ([212.71.252.8]:42536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyTwD-0005M0-6o for 63416-done@debbugs.gnu.org; Mon, 15 May 2023 04:52:13 -0400 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 810C227BBE2 for <63416-done@debbugs.gnu.org>; Mon, 15 May 2023 09:52:11 +0100 (BST) Received: from felis (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id 96409541 for <63416-done@debbugs.gnu.org>; Mon, 15 May 2023 08:52:10 +0000 (UTC) References: <87o7ms1if5.fsf@cbaines.net> <87fs835eqn.fsf_-_@gnu.org> <87h6sizzgp.fsf@cbaines.net> User-agent: mu4e 1.8.13; emacs 28.2 From: Christopher Baines Date: Mon, 15 May 2023 09:51:19 +0100 In-reply-to: <87h6sizzgp.fsf@cbaines.net> Message-ID: <87ednif03s.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684140808; a=rsa-sha256; cv=none; b=j+hQxiiiqu414shQK7Cwm463jxXGww8lSw+8aUNOvm6AIrGxOXOgIvAqkZD8eBr9bOOHeP 8y+PSVJgh/bTReZsnvIFAf0d91sWDFpxfs1Bd4uAVkh2+HExtTAkpAInYPWUb7AwfAqSaO FS4PEHMSO6AFo7T1Npp0reYoWbw+knTCfTgEX+Ek67q+Ncudv+pM4Eir9s34Q0CC7poJLM gC5sa2pi8xjt7PdDutAFr+Ig69aOsjXi7FKB5+QvXkNx18JgDzbpvazfaq9TQI1kZwHCWI p4yTQ9I7ERXQNf7XtifyrApo0E8c5jrw+WamPZN3uXixDgV2Eb6px4FqevNTIg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684140808; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-to:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=ZUZWKrEmRHtRI6aI3L41Fu0qP1orR1jLw8k4zwzLJ7I=; b=Kzxma4f0tBYHkaX+Ve2rISjTnLHYEpUrh1pHxzG2S/gYjeiA4i+71e1pYc1kiDOMNvhhcq WrBqpVMaz2RK3n6CALI3m7SGVoqS2M0/ZhWfUWWH5zGPSnDeHwRUR3D8EhnFfEilppgLya tAMNIkNhO77P+eXXyS+m5IRifWolB5MwTxqGfV5hsnkrpzGxKM0ZQk9928Uf+ZKS4kSgD/ xxxHMMVQ4hHRSU/aL9kfhEh0/duPkUubautj3JfCU1XmoSdFu/JjyaURACsl4v87m6VlF3 HJjUMj40hT3SSvCZrfRjj3XI01ErTohfRPjneNfAStcE5KvuOuIVftM2H1INGA== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -5.29 X-Spam-Score: -5.29 X-Migadu-Queue-Id: CAF73208ED X-TUID: ctV4sRvlhGzJ --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Christopher Baines writes: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> As this seems to be generating broken derivations for i586-gnu otherwis= e. >> >> =E2=80=9CSeems=E2=80=9D isn=E2=80=99t confidence-inspiring. ;-) >> >> Here=E2=80=99s one: >> >> $ ./pre-inst-env guix build gccgo -s i586-gnu -d=20 >> /gnu/store/yzlmgxq20bk9xcbksi7q1f839056wzhr-gccgo-12.3.0.drv >> $ guix gc --references /gnu/store/yzlmgxq20bk9xcbksi7q1f839056wzhr-gccgo= -12.3.0.drv |grep builder >> /gnu/store/jizw9gjvzb21jm7q7xlm71pw6fr24hhv-gccgo-12.3.0-builder >> $ grep -q '#<' /gnu/store/jizw9gjvzb21jm7q7xlm71pw6fr24hhv-gccgo-12.3.0-= builder ; echo $? >> 0 >> >>> * gnu/packages/gcc.scm (custom-gcc): Use gexp's for the generated packa= ge >>> arguments. >> >> [...] >> >>> As otherwise this seems to generate broken derivations for i586-gnu. >>> >>> * gnu/packages/gcc.scm (make-gccgo): Use gexp's for the package argumen= ts. >> >> >> [...] >> >>> +++ b/gnu/packages/gcc.scm >>> @@ -1156,34 +1156,34 @@ (define (make-gccgo gcc) >>> (arguments >>> (substitute-keyword-arguments (package-arguments gccgo) >>> ((#:phases phases) >>> - `(modify-phases ,phases >>> - (add-after 'install 'wrap-go-with-tool-path >> >> If =E2=80=98phases=E2=80=99 might be a gexp, then this should be a gexp = as well. >> >> Put differently, if one of the gcc* packages starts using gexps, then >> all those that inherit from it should switch as well. >> >> Since =E2=80=98gcc-11=E2=80=99 uses gexps (only when targeting the Hurd)= , all the other >> ones should use gexps. That probably includes all those in gcc.scm and >> all those in commencement.scm. > > Yep, I think these changes were sufficient, but I missed replacing a few > unquote bits with ungexp, so as QA shows this affected a bunch of > derivations for all systems. > > I've fixed those bits now and sent a v2. v2 looked good in QA, so I pushed this to master as 70986f052a2b60ccb5f3bd5da520f9cdf5ea60ad. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmRh8rdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XcclA//fyBBHLcYnyZTYgeOEutnDZGjbzxC9B3O 1o70dDoH+aZhb5DsYckh1Be120m5/EKfB7AHYpJ4R3KQIOce67Jgm/eQ9HujW0A4 987azQVmWdKlrt6eM55YTGfSe2trpUGsCbuCdBdxFlfUlgbCzmWCiIsVcrqwSDrU rhvYv27s7vfAURsEZUyPGeheZIPbrnlLbotD86qyeM+oVwQnHxrQ3XdK75wzzqkD R65aFP4MBNKQcKSP8rc9MzkC1J5OAyi5kqQBZcziuoclfspMhzU/MCvBwMW0QGZH Z2zLoogWRm9NKmm0VrcMpRR/DkkXq2j+NTxnIgPCvuFxlRP5hGiwgDQuEN+csKLb YWEwdYBSW5nYWmD3Ksyj8vljoXQOrnnfm/HO0gcMcMj7Xo98NHHqqz7byBzAVBRH XN+tyDlU8VcRIYPrtV8Sj9Qwr4ZwmdKnnurDgqMwMh3ae2PUSwxPNOGliwZjexuV 4UZcREMibPDvbmYm2riXYbqatlSgnI459kJY5cv+cRLW+7XaC53pX78GY5zsRQmt 7fZPaxz0xHi68InBxpBVO5Q98VrYUFkXixkMYE19kGYv6J+zedaQtRmvLR5kMvvx qzypVWDf82aoEuqoMq8rG5Nxs8FSA7T8DHgURgtME1V1YIORTFdDP2B4RSJ4k/pD rosOIl8Nwi4= =DCcu -----END PGP SIGNATURE----- --=-=-=--