unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Zongyuan Li <zongyuan.li@c0x0o.me>
Cc: 61682-done@debbugs.gnu.org, liliana.prikler@gmail.com
Subject: bug#61682: [PATCH] gnu: buildah: Add 'buildah' package
Date: Thu, 08 Jun 2023 23:27:39 +0200	[thread overview]
Message-ID: <87edmlzltg.fsf_-_@gnu.org> (raw)
In-Reply-To: <e526a59655eadcf95343fd7030c3157b867f7261.1679739400.git.zongyuan.li@c0x0o.me> (Zongyuan Li's message of "Sat, 25 Mar 2023 10:25:05 +0000")

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

Hi,

Zongyuan Li <zongyuan.li@c0x0o.me> skribis:

> gnu: buildah: Add 'buildah' package
>
> Introduce new 'buildah' package
>
> * gnu/packages/containers.scm: New 'buildah' package

Finally applied with the changes below, most of which were suggested by
Liliana.

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 2647 bytes --]

diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
index 839d81cd0e..eb7699c505 100644
--- a/gnu/packages/containers.scm
+++ b/gnu/packages/containers.scm
@@ -414,8 +414,10 @@ (define-public buildah
     (arguments
      (list #:import-path "github.com/containers/buildah/cmd/buildah"
            #:unpack-path "github.com/containers/buildah"
-            ; Some dependencies require go-1.18 to build
+
+           ;; Some dependencies require go-1.18 to build.
            #:go go-1.18
+
            #:tests? #f
            #:install-source? #f
            #:phases
@@ -433,14 +435,12 @@ (define-public buildah
                      (("/usr/local") (string-append #$output)))))
                (add-after 'build 'build-docs
                  (lambda* (#:key unpack-path #:allow-other-keys)
-                    (let*
-                      ((doc-path (string-append "src/" unpack-path "/docs")))
-                      (invoke "make" "-C" doc-path))))
+                   (let ((doc (string-append "src/" unpack-path "/docs")))
+                     (invoke "make" "-C" doc))))
                (add-after 'install 'install-docs
                  (lambda* (#:key unpack-path #:allow-other-keys)
-                    (let*
-                      ((doc-path (string-append "src/" unpack-path "/docs")))
-                      (invoke "make" "-C" doc-path "install")))))))
+                   (let ((doc (string-append "src/" unpack-path "/docs")))
+                     (invoke "make" "-C" doc "install")))))))
     (inputs (list btrfs-progs
                   cni-plugins
                   conmon
@@ -455,10 +455,23 @@ (define-public buildah
      (list go-github-com-go-md2man
            gnu-make
            pkg-config))
-    (synopsis
-     "Build Open Container Initiative images")
+    (synopsis "Build @acronym{OCI, Open Container Initiative} images")
     (description
-     "Buildah is used to build Open Container Initiative
-@acronym{OCI, Open Container Initiative} compatible containers.")
+     "Buildah is a command-line tool to build @acronym{OCI, Open Container
+Initiative} container images.  More generally, it can be used to:
+
+@itemize
+@item
+create a working container, either from scratch or using an image as a
+starting point;
+@item
+create an image, either from a working container or via the instructions
+in a @file{Dockerfile};
+@item
+mount a working container's root filesystem for manipulation;
+@item
+use the updated contents of a container's root filesystem as a filesystem
+layer to create a new image.
+@end itemize")
     (home-page "https://buildah.io")
     (license license:asl2.0)))

      parent reply	other threads:[~2023-06-08 21:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-21 14:35 [bug#61682] [PATCH] gnu: buildah: Add 'buildah' package Zongyuan Li via Guix-patches via
2023-02-23  7:04 ` [bug#61682] [PATCH v2] " Zongyuan Li via Guix-patches via
2023-02-23 11:31 ` Zongyuan Li via Guix-patches via
2023-02-23 12:26 ` Zongyuan Li via Guix-patches via
2023-02-24  5:20   ` Liliana Marie Prikler
2023-02-24  7:12     ` Zongyuan Li via Guix-patches via
2023-02-23 12:50 ` Zongyuan Li via Guix-patches via
2023-03-24 10:14 ` [bug#61682] [PATCH v3 0/1] " Zongyuan Li via Guix-patches via
2023-03-24 10:14   ` [bug#61682] [PATCH v3 1/1] " Zongyuan Li via Guix-patches via
2023-03-24 18:00     ` Liliana Marie Prikler
2023-03-25  9:15       ` Zongyuan Li via Guix-patches via
2023-03-25 10:46         ` Liliana Marie Prikler
2023-03-25 11:02           ` Zongyuan Li via Guix-patches via
2023-03-25 10:23 ` [bug#61682] [PATCH v4 0/1] " Zongyuan Li via Guix-patches via
2023-03-25 10:25   ` [bug#61682] [PATCH v4 1/1] " Zongyuan Li via Guix-patches via
2023-03-25 11:09     ` Liliana Marie Prikler
2023-06-08 21:27     ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edmlzltg.fsf_-_@gnu.org \
    --to=ludo@gnu.org \
    --cc=61682-done@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    --cc=zongyuan.li@c0x0o.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).