From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qNJhBbv76mQvGAAAauVa8A:P1 (envelope-from ) for ; Sun, 27 Aug 2023 09:31:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id qNJhBbv76mQvGAAAauVa8A (envelope-from ) for ; Sun, 27 Aug 2023 09:31:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4B5C55BE8A for ; Sun, 27 Aug 2023 09:31:05 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=aIck9dph; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1693121466; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=SZ57JiwzrZvomWc8pkEbtwv/9NtSufgtCGzQiRyEU24=; b=XuYvBORNSgG2HNDQwHDy/jRdSOU9v8fmp7eTevGpPgWEXx3syV/tuC3MNgidFp2ZwOJZ3e HKdRXenKizbl3VzOt2naJLIbb9auOGLx9pGvpZCWp3609SyqfSDIj+8NVZSN/2KfGwu0gG xMSvF+my1j1Z3vSRFXJhMm1pwJ3vXVcdGuId30CaHnuUDd3jRpnRDbw+N+E0N7w5pOR454 LxBQI4KMTHzypv/po8BWH/mDWSqZC+Worm155l8BPCdnW3qoWEVi5OjCWALtbjm6im4VzW I4zQr8fJdUsmb/vtpBDoWAeYbiOV6Wu3Ji7krgcg8OgTd2J5qb7eT2Kj3l3LJA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=envs.net header.s=modoboa header.b=aIck9dph; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1693121466; a=rsa-sha256; cv=none; b=a9ZpP9E41e6fWioPUCo2S9+rp/HWa2YFdS57MqHahlpOe+FiBC9LRws8ArXMloNercaLFa dg97Njqg4VCPhI1VE5JNLW8BupRdgiapxwHROgLuW3J37T8SQJbRiGBjIZpq7gg1pag3zq xJKOX3XzEmSGoR/S3k8ujt/3HfVtyxW2doq4afrUnXpQuP9G7cPMDosTLOTzurFQ0PZ1pU 9At049wUwwwyGw301a1NUKcksNvFz8irr+qx3zw7lDh/cRLyfBI7mPdmYatshoBgoXJzzl BPfjn86TYuosUWGySZxsEhXru56Cr3Y8ysNAdvWU0v4G9lR1SXkNNqjFO1gSnw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qaAEe-0006MF-9J; Sun, 27 Aug 2023 03:31:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qaAEa-0006Ja-Q1 for guix-patches@gnu.org; Sun, 27 Aug 2023 03:30:57 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qaAEa-0006vK-Hl for guix-patches@gnu.org; Sun, 27 Aug 2023 03:30:56 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qaAEg-0001xh-4C for guix-patches@gnu.org; Sun, 27 Aug 2023 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65550] [PATCH] profiles: Don't propagate inputs for non-development packages. Resent-From: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 27 Aug 2023 07:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65550 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: 65550@debbugs.gnu.org, =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= Received: via spool by 65550-submit@debbugs.gnu.org id=B65550.169312140330269 (code B ref 65550); Sun, 27 Aug 2023 07:31:02 +0000 Received: (at 65550) by debbugs.gnu.org; 27 Aug 2023 07:30:03 +0000 Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaADh-0007rx-UZ for submit@debbugs.gnu.org; Sun, 27 Aug 2023 03:30:02 -0400 Received: from mail.envs.net ([5.199.136.28]:55002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qaADe-0007rT-Rt for 65550@debbugs.gnu.org; Sun, 27 Aug 2023 03:30:00 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id D70F138A0135; Sun, 27 Aug 2023 07:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1693121390; bh=SZ57JiwzrZvomWc8pkEbtwv/9NtSufgtCGzQiRyEU24=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=aIck9dph8qwtgqUaV4irE+CskZqFZmpbO+zcXkmzTrnHbG1qYlraPN2WBvE/4/1dA dFJaEx7RAFfzhFyNJYo3El24398dbedNz7tAo+r/joHxDvhxuFkdF8AKuccz+OwU0z 5sUSMuqg5qUSDq4SfjMxixJ3rw2PX+CRIYTGXt5qld9+m04d2HZVURpA+c4d2GKlM4 aswqiqsyassOEC+3LhOzboQ1lfszs1hglOtYm+DJwatTdGfqxuQWg7dvIYlCBGddUV d1RJnJYQ0VTg/B1bupnXoGEpmxtCKYiv02JYvLhhjKjrpvFldV0n37wuOU9un5nfiM rl3K05wx9hgjeb2839aRHppJ828NG018XCbEflV6PDEs+2YLmTQ6NXPUl8EqXv5Wh7 5ha2ARSp9gd6kPswoXWnB+Nv4q0hvTkCt1MGWnRhM2HH55LfSCyxKAAt/87ocWVg4F d0FnKKiGW8EMWNv8SpcpIoclgOyX2O1kfDSdbHl7o2eOhJ+dUFts5PlPKT/zvFJPd7 BBJxgs1hHfD0yGw8FrHQCLS9NNhuEIox6cUv4hc0OMQpvQ3UUvFTEBC1NPMVUZnMlH efY6Gi4iVdWuGAqDB+5j3V2zhL34G7gwa3ULu9Kl/wgeLmU0j5W4XYaAaOxQPse1ic ALREff0ieOA9owNoY0boLY8A= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id NTFL6EhsNUnK; Sun, 27 Aug 2023 07:29:45 +0000 (UTC) Received: from localhost (unknown [36.170.44.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Sun, 27 Aug 2023 07:29:45 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 789c694a; Sun, 27 Aug 2023 07:30:05 +0000 (UTC) References: <1f7f85189b17ebddb6d0e26afd7c5fad88c997e9.1693057951.git.iyzsong@member.fsf.org> <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> Date: Sun, 27 Aug 2023 15:30:05 +0800 In-Reply-To: <851f008ab9e989badb8bcb10f4b7eee5bc5616c0.camel@gmail.com> (Liliana Marie Prikler's message of "Sat, 26 Aug 2023 16:21:34 +0200") Message-ID: <87edjpaqo2.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: =?UTF-8?Q?=E5=AE=8B=E6=96=87=E6=AD=A6?= X-ACL-Warn: , =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= From: =?utf-8?b?5a6L5paH5q2mIHZpYSBHdWl4LXBhdGNoZXM=?= via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -6.71 X-Spam-Score: -6.71 X-Migadu-Queue-Id: 4B5C55BE8A X-TUID: mG4HlozeotE8 Liliana Marie Prikler writes: > Am Samstag, dem 26.08.2023 um 21:53 +0800 schrieb iyzsong@envs.net: >> From: =E5=AE=8B=E6=96=87=E6=AD=A6 >>=20 >> * guix/profiles.scm (package->manifest-entry): Only include >> propagated inputs from a package for its "dev" output, or its "out" >> output if the package doesn't have a "dev" one. >> --- > I think this patch misses the most obvious use case of the out:lib > split. I also think that hardcoding this list is bound to fail. Ah, that's true. We currently put both headers and pkgconfig files in the "lib" output, I think we should put those files into "dev" instead, only leave shared libraries in "lib" (then we don't need propagated it anymore). And I did a test to find packages with "lib" and propagated-inputs: --8<---------------cut here---------------start------------->8--- (use-modules (gnu packages) (guix packages) (srfi srfi-1) (ice-9 pretty-print)) (define x (delete-duplicates (fold-packages (lambda (package result) (if (and (member "lib" (package-outputs package)) (not (null? (package-propagated-inputs package)))) (cons (package-name package) result) result)) '()))) (pretty-print x) --8<---------------cut here---------------end--------------->8--- Only hwloc and apache-arrow, and 24 packages (uniqued by name) have a "lib" output, seems doable. > Instead, we could for the time being solve this with yet another > package property. > '((propagate-inputs-from "lib")) ; but not out > '((propagate-inputs-from . ("lib"))) ; same meaning, different style > '((propagate-inputs-from "out" "lib")) ; but not doc > If the property is missing, we still propagate from all outputs, as is > currently done. > > WDYT? Yes, a property is more flexible here, haven't think about it. Well I wishful think if we always follow a good convention (put development files in "dev" or "out"), then maybe we can saving some bytes in code? I'd like to split more packages with multiple outputs with "dev" to see how the convention works out. If not then we could take this 'property' way. Thanks!