From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: nathan <nathan_mail@nborghese.com>
Cc: 64576-done@debbugs.gnu.org
Subject: bug#64576: [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
Date: Wed, 06 Sep 2023 00:01:01 -0400 [thread overview]
Message-ID: <87edjc9chu.fsf@gmail.com> (raw)
In-Reply-To: <87fs5ume85.fsf@nborghese.com> (nathan's message of "Tue, 11 Jul 2023 15:34:00 -0400")
Hi,
nathan <nathan_mail@nborghese.com> writes:
> fix bug#64409
> In libusb-compat-0.1.8/libusb/libusb-dload.h, dlopen is used to load libusb.
> We need to specify an absolute path.
> With this fix, teensy_loader_cli doesn't immediately fail with a missing library error.
> ./pre-inst-env guix shell teensy-loader-cli -- teensy_loader_cli
> If you merge the patch from bug#64563 first, you can't test this patch with teensy_loader_cli.
>
>>From c0a8ecea0ce6f3954061a3d061a3243fa65c6cfb Mon Sep 17 00:00:00 2001
> From: nathan <nathan_mail@nborghese.com>
> Date: Mon, 10 Jul 2023 23:22:48 -0400
> Subject: [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so
>
> * gnu/packages/libusb.scm (libusb) [configure-flags]: Provide full path of
> libusb-1.0.so so dlopen works.
> ---
> gnu/packages/libusb.scm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
> index d0837c8a91..39586147ba 100644
> --- a/gnu/packages/libusb.scm
> +++ b/gnu/packages/libusb.scm
> @@ -101,7 +101,10 @@ (define-public libusb-compat
> (build-system gnu-build-system)
> (arguments
> (list #:configure-flags
> - #~(list "--disable-static")))
> + #~(list "--disable-static"
> + (string-append "LIBUSB_1_0_SONAME="
> + #$(this-package-input "libusb")
> + "/lib/libusb-1.0.so"))))
> (native-inputs
> (list autoconf automake libtool pkg-config))
> (inputs
Interesting! I fixed this independently with ddd8bb104, using a RUNPATH
approach. Yours is a better solution, now applied :-).
--
Thanks,
Maxim
prev parent reply other threads:[~2023-09-06 4:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 19:34 [bug#64576] [PATCH] gnu: libusb-compat: Compile with full path of libusb-1.0.so nathan via Guix-patches via
2023-09-06 4:01 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edjc9chu.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=64576-done@debbugs.gnu.org \
--cc=nathan_mail@nborghese.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).