From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id qJTPJS9IEWWHFwEA9RJhRA:P1 (envelope-from ) for ; Mon, 25 Sep 2023 10:43:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id qJTPJS9IEWWHFwEA9RJhRA (envelope-from ) for ; Mon, 25 Sep 2023 10:43:27 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4D7AD54629 for ; Mon, 25 Sep 2023 10:43:27 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=IMGxRJNM; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695631407; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=XjP9SZTDm+8QhGSODKIH3+xx0ng6cc7UfGZv44cPEa0=; b=lc+kuBfbxUPtWUyoOpeDRN73QrtR2mSg2Fz556nanAgU/MAiUOIC4/drAedJknpAA3qKcd O6ZcwP6Y9T5cdK2hZhDBRWT+tmV1JlzquvG75x2RP4rAXHlPW3/e5Ric4atTwmD2I9pLaO Yq/4JnuvttCEcdD6DUwiotdLT4+XFaBRsR+gxrayHH7mMA6F8rCaBW75jG1zmRNXxQevY4 I96+zRkKCetKANK4sXIA5lJ6HD5ReyqT8ud7Gd6+aIZKhy8wuHIpordyHM0L0vGsDvaW0m U6SHRlLQ/DjLVKljPvvJbzMo696SUpR6wU+1J6BDC60DmdUZBBpZ552uujd4yg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695631407; a=rsa-sha256; cv=none; b=EIK+4CigbCBSuQXDQx1Mm9kZL3tKwSu5Nohqyj9Z4l/yOdLKZMk9Uxq19ATPEcBN0SijqI EGcJT9lJQVy5xq6C0znnReiawtAJw5+xd9Liyet+Q4xDvzHe1SUiIYj4g+OKMg7oG/JBBO yEqBdS0hCWUuqTUmwTYr4xSCnR6EvPegOHAJ8mGMYCAvzoWi4DxSAEsTwmaJE0P0JqCSd1 Z/7gE9sU16bt91jFtewlifd8WYNfKuCj3N20ajlOIVoE9WmnVO9tPFBv6PrpCVOWx176Bg UZTfPD2Un+wMiDfw85nc71zVANBCZ/2N+UdGtwHqbXQ1F3RN018jWiGxM2rAaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=IMGxRJNM; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkhBD-0005Fm-Pl; Mon, 25 Sep 2023 04:42:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkhB5-0005Cw-2Z for guix-patches@gnu.org; Mon, 25 Sep 2023 04:42:52 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkhB4-00089q-QK for guix-patches@gnu.org; Mon, 25 Sep 2023 04:42:50 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkhBH-0007H7-2K for guix-patches@gnu.org; Mon, 25 Sep 2023 04:43:03 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#65866] [PATCH v2 1/8] git-download: Move fallback code to (guix build git). Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Sep 2023 08:43:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65866 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 65866@debbugs.gnu.org Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Ricardo Wurmus , Christopher Baines Received: via spool by 65866-submit@debbugs.gnu.org id=B65866.169563135127896 (code B ref 65866); Mon, 25 Sep 2023 08:43:03 +0000 Received: (at 65866) by debbugs.gnu.org; 25 Sep 2023 08:42:31 +0000 Received: from localhost ([127.0.0.1]:44122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhAl-0007Fr-Gt for submit@debbugs.gnu.org; Mon, 25 Sep 2023 04:42:31 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:40393) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkhAj-0007FB-UA for 65866@debbugs.gnu.org; Mon, 25 Sep 2023 04:42:30 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-32163c3ece5so584898f8f.1 for <65866@debbugs.gnu.org>; Mon, 25 Sep 2023 01:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695631332; x=1696236132; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=XjP9SZTDm+8QhGSODKIH3+xx0ng6cc7UfGZv44cPEa0=; b=IMGxRJNMHrYGeLiUGP5BQJyEH3isK3hmMGChND87cnLAQuftwV6NVVQZmH4l29RyNF MbqQvorGHlkEAVhjhqV2NY6u2ThLcIle0Q2sy9mxi97+Na6l42cEdYpwLufoOg+OLHXV 47NG6+15WJ5Y/klrYaTGLmN+iOPC+mYf02v2W5eoRkidnbA9sbd4RHIEn0xFZiJgg+SP tF+lxfvadvisCo03S+mbOoVBMQrzDowarWgIrQZHx9acSfho5r5aYcJjO6j9To8BSBll DVGjfnw6BTUVyt1WVYmkUuXIO7iwaSu+pDWMynFN0Bsw8FdyBPWWAsyBQ2+7xsJ6wyHE K0+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695631332; x=1696236132; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XjP9SZTDm+8QhGSODKIH3+xx0ng6cc7UfGZv44cPEa0=; b=i683GiCkYV7RFAeKNuDUwtRwulJxK3FSU1cl9qMyJQIyN+NpTaPVZQkv6DKwIwg4Ix xsAVfJDSltN+qpeH8HgF49WqbbK47nsB9C81C8D7cxZ3dk8AbbWGkIlKIHdd2tIbqP67 HK0Ok0JGMnSXITWnTzPh0mUkli3O5WnE3ZbeMCvthUJ7jMv+mPBsrOAX3qVDs51/eS4X Ekp3XXgKLXTmqCB068QjMcZYkW/0WvCu74UDwv+/ynUwbq55uq8+AWV3IzG7SgfImk7i VWcigvCQ5qoCW2okZvRxdVvYSD0NtqAfqgKiMYnW/fIpC3tuNKrerumFrwpPmtPDo52z W5mw== X-Gm-Message-State: AOJu0YwTKROV8Fyh4xmlab2rAVxMf1uQLf+UpE72fnfbOWtIr4zcc7b8 EPqrvXJJjGZNr0KctcZn5LK0mGXEbXQ= X-Google-Smtp-Source: AGHT+IGID9KNTAYk1iisJ2JKzqS6ZbR4of7pgbUugXIHVB2y/PQ6Jkvxj+sX7XKLlDo5TELIlUmVzQ== X-Received: by 2002:a5d:46d0:0:b0:316:ef5f:7d8f with SMTP id g16-20020a5d46d0000000b00316ef5f7d8fmr5052197wrs.3.1695631331744; Mon, 25 Sep 2023 01:42:11 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id n11-20020a5d4c4b000000b0031fbbe347ebsm11141843wrt.22.2023.09.25.01.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 01:42:11 -0700 (PDT) From: Simon Tournier In-Reply-To: <765792320d841e1e33a11f119ad687094ca2766f.1695421391.git.ludo@gnu.org> References: <87o7hwas61.fsf@gnu.org> <765792320d841e1e33a11f119ad687094ca2766f.1695421391.git.ludo@gnu.org> Date: Mon, 25 Sep 2023 10:15:21 +0200 Message-ID: <87edim7jom.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -4.95 X-Spam-Score: -4.95 X-Migadu-Queue-Id: 4D7AD54629 X-TUID: 5Wab1SzfrTSd Hi Ludo, On Sat, 23 Sep 2023 at 00:27, Ludovic Court=C3=A8s wrote: > + ;; XXX: Currently recursive checkouts are not supported. > + (and (not recursive?) Naively, and similarly as Maxim=E2=80=99s remark, maybe we could raise a wa= rning when the case is not supported instead of silently return #f. If raising a warning here is not appropriate, maybe document in the docstring the returned value as #f. =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20 > - (with-extensions (list guile-json gnutls ;for (guix swh) > + (with-extensions (list guile-json gnutls ;for (guix swh) Nitpick: Since the change is complex, I would suggest to avoid this cosmetic. Cheers, simon