From: Nicolas Graves via Guix-patches via <guix-patches@gnu.org>
To: jlicht@fsfe.org, 62375@debbugs.gnu.org
Cc: dev@jpoiret.xyz, mail@cbaines.net, zimon.toutoune@gmail.com,
othacehe@gnu.org, ludo@gnu.org, me@tobias.gr, rekado@elephly.net,
Jelle Licht <jlicht@fsfe.org>
Subject: [bug#62375] [PATCH 0/1] npm binary importer
Date: Thu, 08 Feb 2024 01:59:16 +0100 [thread overview]
Message-ID: <87eddn4vq3.fsf@ngraves.fr> (raw)
In-Reply-To: <cover.1679484068.git.jlicht@fsfe.org>
On 2023-03-22 12:25, jlicht@fsfe.org wrote:
> From: Jelle Licht <jlicht@fsfe.org>
>
> Folks,
>
> Here a revised patch to add the npm binary importer. To give some context,
> 'binary' here refers to the fact that this downloads archives straight from
> the npm registry at https://registry.npmjs.org. Some of these downloaded
> archives may not contain the original sources, so unless properly vetted the
> output of this importer does not allow one to easily generate package
> expressions for inclusion in guix's collection of packages.
>
> It should work as-is for most simple NPM packages. As noted in an inline
> comment somewhere, the way both npm and our very own node-build-system treats
> peer dependencies may require some manual intervention from time to time to
> hook in the right dependency at the right spot. The upside here is that when
> this happens, it's either trivial for a human to spot and fix, or wholly
> incompatible with our current approach so not fixable without writing a custom
> build system to deal with dependency cycles :-).
>
> Please test and review, let us get this merged as it might be useful to many
> people for building out their personal channels and/or package expressions.
>
> Special thanks to Timothy Sample and Lars-Dominik Braun for involvement in
> realising this, way too long ago.
>
>
> Jelle Licht (1):
> import: Add binary npm importer.
>
> Makefile.am | 2 +
> guix/import/npm-binary.scm | 269 +++++++++++++++++++++++++++++
> guix/scripts/import.scm | 2 +-
> guix/scripts/import/npm-binary.scm | 113 ++++++++++++
> 4 files changed, 385 insertions(+), 1 deletion(-)
> create mode 100644 guix/import/npm-binary.scm
> create mode 100644 guix/scripts/import/npm-binary.scm
Hey Jelle,
Just to understand, is there a reason why you didn't went further with
the sucrase approach?
--
Best regards,
Nicolas Graves
next prev parent reply other threads:[~2024-02-08 1:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:25 [bug#62375] [PATCH 0/1] npm binary importer jlicht
2023-03-22 11:27 ` [bug#62375] [PATCH] import: Add binary npm importer jlicht
2023-03-28 15:49 ` Ludovic Courtès
2023-04-08 18:29 ` Jelle Licht
2023-04-17 21:14 ` [bug#62375] [PATCH 0/1] npm binary importer Ludovic Courtès
2023-06-18 21:03 ` Ludovic Courtès
2023-06-22 9:39 ` Jelle Licht
2024-02-08 0:59 ` Nicolas Graves via Guix-patches via [this message]
2024-03-24 14:54 ` [bug#62375] Continue the npm-binary importer Pablo Zamora
2024-03-31 19:57 ` Jelle Licht
2024-03-31 22:03 ` Pablo Zamora
2024-03-31 19:46 ` [bug#62375] [PATCH v2] import: Add binary npm importer jlicht
2024-03-31 20:37 ` [bug#62375] [PATCH v3] " jlicht
2024-04-01 20:41 ` Ludovic Courtès
2024-04-02 14:12 ` Jelle Licht
2024-04-01 22:01 ` [bug#62375] [PATCH 0/1] npm binary importer Jonathan Brielmaier via Guix-patches via
2024-04-02 14:16 ` Jelle Licht
2024-04-02 14:13 ` [bug#62375] [PATCH v4] import: Add binary npm importer jlicht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eddn4vq3.fsf@ngraves.fr \
--to=guix-patches@gnu.org \
--cc=62375@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=jlicht@fsfe.org \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=ngraves@ngraves.fr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).