From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id oLsNAJdL2GWoSQAAqHPOHw:P1 (envelope-from ) for ; Fri, 23 Feb 2024 08:39:03 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id oLsNAJdL2GWoSQAAqHPOHw (envelope-from ) for ; Fri, 23 Feb 2024 08:39:03 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=G2YSZcqi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1708673942; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lyGwO61mLiKv0L/xO6WoOeL35XnN0C44ci+nOd9jIk4=; b=NSIlpzJEB5V/PiZBemvLwYdaLyXtERbxhbqbQrMXKIg+iNbc3v5yPcZ9wUR4Jvl1R72QQ0 FPqVdoI2OmvfvKi4Un1fBjzgZId6W6QpF+DwUTGC2rWF8hKffw3lCbeiRoq7jHBlDxNDdc 0NhQh7sF+MoqtdL26LoVIvt7LWFxGhVJYMSxgwY0yTeuyp3UPhOgfmp4E/zV0A/t7yVipI bUG4+6rE+EaqBXIfxv0gPucir+NktkFCOpDR0nVouSF6HtuHqbK1WF6qCQ6snSARFTEDOp nG3y9kaSrUXc5V7GpD5kKL+2amRGHrOMR4QYsAoSzbYBnTMr3MxkT0gsRpQHXQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=nicolasgoaziou.fr header.s=mailo header.b=G2YSZcqi; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1708673942; a=rsa-sha256; cv=none; b=sCA+6+8VrEfCoTa3oRvOhxVr9QrJFVvkCFez0MIwAPf5h0D1+MsjMZnrAmypRq2F5DNiGB xuvnfLxaxHJmFThOpCgtxgeu24lvt5tko2GZqUz832b6rg1CtDfeO5+NuP9tWf3DWfhahn hwXly2GRdGqTDBxhKHdT7x1rYBPpb1gES9tOBh51QHXPA23vBX9K1MoYlcUSUa6zAqbj3Y XBULOD42dliRwWCOeoQ3c3Uk8iJn+qLnozQk+w/GCNNaPOgZrDgd2cc8zUoGPHCTbFRSeJ jkNKXsWqNDnZJqikAgTI7frEpxnABgT2IP/SZnf/RzWu1usdYcvPwW/d6QVbMw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 839736822B for ; Fri, 23 Feb 2024 08:39:02 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdQ8n-0007Km-Nv; Fri, 23 Feb 2024 02:38:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdQ8l-0007KU-Sb for guix-patches@gnu.org; Fri, 23 Feb 2024 02:38:39 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdQ8l-0003kR-Kd for guix-patches@gnu.org; Fri, 23 Feb 2024 02:38:39 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdQ98-0001ly-DI for guix-patches@gnu.org; Fri, 23 Feb 2024 02:39:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#69313] [PATCH v2 0/2] gnu: tlpui: Fix location for "defaults.conf". Resent-From: Nicolas Goaziou Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Feb 2024 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69313 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Juliana Sims Cc: 69313@debbugs.gnu.org, Tobias Geerinckx-Rice , Wilko Meyer , Leo Famulari Received: via spool by 69313-submit@debbugs.gnu.org id=B69313.17086739066719 (code B ref 69313); Fri, 23 Feb 2024 07:39:02 +0000 Received: (at 69313) by debbugs.gnu.org; 23 Feb 2024 07:38:26 +0000 Received: from localhost ([127.0.0.1]:46597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdQ8Y-0001kJ-0N for submit@debbugs.gnu.org; Fri, 23 Feb 2024 02:38:26 -0500 Received: from msg-1.mailo.com ([213.182.54.11]:42830 helo=mailo.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdQ8W-0001js-Lf for 69313@debbugs.gnu.org; Fri, 23 Feb 2024 02:38:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=nicolasgoaziou.fr; s=mailo; t=1708673874; bh=59l1DK4GtCpsdO0ElQnTljHqIdAhe4MY+TaT67b7MbY=; h=X-EA-Auth:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding; b=G2YSZcqiJiVVHv7yTSQvL6cXKddidWudiXqfpYXDyA18f4G6EBLhbuvRo04Y1ckHO LWadvR8LmnvtN6nw3s4gD+ApGjFD3dN+hsffTiMc0JJXxBZxNJ+FrM92v3bPR/9nZF A8V+XzI82h2q2c9RT6tZpUb49RqF5UlmQ8V2QLAQ= Received: by b221-4.in.mailobj.net [192.168.90.24] with ESMTP via ip-20.mailobj.net [213.182.54.20] Fri, 23 Feb 2024 08:37:54 +0100 (CET) X-EA-Auth: dg4Y6pNPrXzya6r7QGw3p69XaNCOx2Vq+LdCSGrUfr1LKoVIjEqcQoMWxteZ84oysWuBET7mn0E1/O/KjmkMwN8IbEE6cFc3of1SZAk1UjI= In-Reply-To: (Juliana Sims's message of "Thu, 22 Feb 2024 17:56:57 -0500") References: <87il2gcfvm.fsf@nicolasgoaziou.fr> Date: Fri, 23 Feb 2024 08:37:38 +0100 Message-ID: <87edd3d41p.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Nicolas Goaziou X-ACL-Warn: , Nicolas Goaziou via Guix-patches From: Nicolas Goaziou via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -6.77 X-Spam-Score: -6.77 X-Migadu-Queue-Id: 839736822B X-Migadu-Scanner: mx11.migadu.com X-TUID: W+Z7pl6j4rhc Juliana Sims writes: >> how does this relate to other changes in the patch (lsusb and lspci)? > > It doesn't! I meant to split these into separate commits but was very tir= ed. > Don't code sleepy, kids! :) >> I'm a bit puzzled here: how does >> >> (search-input-file inputs "/share/tlp/defaults.conf") >> >> differ from >> >> #$(file-append tlp "/share/tlp/defaults.conf") > > The latter directly accesses the input in question then joins its path wi= th the > provided string and inserts the result where the `file-append` form was i= n the > code. The former searches each input's store directory at build time to f= ind a > matching file. In other words, since we know exactly where to find these = files > ahead of time, we simply tell the build d=C3=A6mon where they are rather = than making > it look for them. > > Because this is a quite minor performance improvement and code modernizat= ion, > rather than a requirement for the package to build, I've split it into a = second > patch to be applied at the discretion of a commiter. I understand the performance improvement, but I'm dubious about the "code modernization" part. I've been out of the loop for a while, but I think using `search-input-file' is still the way to go. IIUC, the `file-append' way makes it more difficult to use package transformations, since you basically bind the executables to a fixed package. I let the issue open for you and others to comment about this. Meanwhile, I applied the first patch. tlpui, even outdated, now builds again! Thanks!