From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id OFmmGHFjM2awsAAA62LTzQ:P1 (envelope-from ) for ; Thu, 02 May 2024 11:57:05 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id OFmmGHFjM2awsAAA62LTzQ (envelope-from ) for ; Thu, 02 May 2024 11:57:05 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BQxiQa93; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714643825; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=7AO6Ro7tP9oTQtxTNuG7It7+LxDs6GE8N7/S9zY/d0U=; b=o3zzlJnu2XkO7K2VMOxV+YQo84htOOTa8CcPpzIHq//bJfJcc3y88/c7w0kUJl3QWIi1qK zmgd9StXmuh7hBMEjcuSQ8uNPSgMIBo995DSveOU87Lv0c4HAezxjIuds/FZMXyyUlf3ND Q35tbap+95H7OPEQq9Zq86ljFpLHYT6FCY95qSF7mPbrAkfu0TOkdpNjULRKMF1k+4B8Af WSO5tKrgcyB8jJsSE2xYvzaxC07yNNg580K700Xcc1tG3Cq0G10Y1+gSDISqT+39Guqucr P2ggFnr65oRevboukAvlk9t6N04pfGt7tKLs3lh4bmt4WeHg+Hd1tynE2v1yIw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=BQxiQa93; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714643825; a=rsa-sha256; cv=none; b=BWKt/VWTNtgaN0q34i/ihZy/Bns5MeBYlekDeXtnDL2E/Jbq5K5e6hY7MLIzmj0QrUDetF CNjlgF3EOEACJ/N7xMomqnA5VIuk38D3W3FTK4eFQNbcdHrOar34f/geyNUE3e+fWrEYxJ TclVkbNA/wm9Xh5R2fJtohvdh66m879vUxRxQWZAWSzsWdW68wDTCjfK78lbF9DNsxRh89 L4otzVnt8KKc89yrDkF5lIN2OFer2PVmxiANd+JiUAmavsOwrWlPXJNyq9tL5bXELFw+zG VVmhHl76PNsRCDQkR04f/VW0B6wEKpbjFhjs2RPfcl2Eeq2HS54tIcH4m+4OmQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 16CC76D1F3 for ; Thu, 2 May 2024 11:57:05 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2TBE-0000Z4-KN; Thu, 02 May 2024 05:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2TBB-0000Xk-2U for guix-patches@gnu.org; Thu, 02 May 2024 05:56:42 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s2TBA-00015c-Qj for guix-patches@gnu.org; Thu, 02 May 2024 05:56:40 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s2TBW-0006NL-GW for guix-patches@gnu.org; Thu, 02 May 2024 05:57:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 02 May 2024 09:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68289 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomas Volf <~@wolfsden.cz> Cc: 68289@debbugs.gnu.org, Fabio Natali Received: via spool by 68289-submit@debbugs.gnu.org id=B68289.171464379824498 (code B ref 68289); Thu, 02 May 2024 09:57:02 +0000 Received: (at 68289) by debbugs.gnu.org; 2 May 2024 09:56:38 +0000 Received: from localhost ([127.0.0.1]:42770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2TB8-0006N3-0e for submit@debbugs.gnu.org; Thu, 02 May 2024 05:56:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s2TB5-0006Mw-Im for 68289@debbugs.gnu.org; Thu, 02 May 2024 05:56:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2TAd-0000xt-Hg; Thu, 02 May 2024 05:56:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=7AO6Ro7tP9oTQtxTNuG7It7+LxDs6GE8N7/S9zY/d0U=; b=BQxiQa93LAPThs+s+vYK HpmwaMCNYRsN9xrKkpVUzV9vXklj8ZoEoOvp7e11lGipIgq25mszPxB501qWYy6mLjlZ39aqm+ASC aD32N1/er3MsVxnFU9fBLUDShakKN/S1qRB70PPn/u5xjcaqbwNGv1oljQgM45pgKRjdBFX+zAfCu WKOdeZGp6E5wFXRl2MNlV67W9zT3vNDSPrBrlSC0MMJEvG2WuGsO/Y7nkCne/HQYzG/e5yQ6L5scn 68nL/2juaH2Pcci5f4vpbIQvySmX4CCt97YtDv+Za6h0YZwStcFuz9pcvmRMvmzSgurBwy48+zuda +qExK+kg4I0DGA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: (Tomas Volf's message of "Wed, 24 Apr 2024 19:43:54 +0200") References: <87o7a9upoq.fsf@fabionatali.com> <87r0f4l4kb.fsf@fabionatali.com> <87zftpedyt.fsf@fabionatali.com> <87le53nf7o.fsf@fabionatali.com> Date: Thu, 02 May 2024 11:55:28 +0200 Message-ID: <87edakzgfj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -7.09 X-Migadu-Queue-Id: 16CC76D1F3 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -7.09 X-TUID: vTVleTjMO1DK Hi! Tomas Volf <~@wolfsden.cz> skribis: > On 2024-04-24 12:59:55 +0100, Fabio Natali wrote: >> On 2024-04-19, 13:25 +0100, Fabio Natali wrote: >> > On 2024-04-18, 23:09 +0200, Tomas Volf <~@wolfsden.cz> wrote: >> >> first, let me thank you for the review, and apologize for somewhat >> >> late response, sadly I have been busy. >> >> Hi Tomas, >> >> Sorry for the slow follow-up. After some further testing and some input >> from other Guix friends, this is my humble feedback on what I'd put in a >> v2 patch. >> >> - Use Guix's 'invoke' instead of a custom 'checked-system*' procedure. >> >> - Where possible, use '#$(file-append foobar "/bin/foo")' instead of >> '(string-append #$foobar "/bin/foo")', so that as much computation as >> possible happens at build time as opposed to run time. It's a >> microscopic difference, but still worth the change I think. >> >> What do you think? Not urgent, but do you think this is something you >> might be interested to include in a v2? No problem if you're busy, but >> let me know if there's anything I can help with. > > All sounds reasonable, will send v2, cannot guarantee when, hopefully thi= s week. I hadn=E2=80=99t seen this patch; having a =E2=80=98startx=E2=80=99 command= is something that has often been asked, so I=E2=80=99m glad you=E2=80=99re fixing it! The patch and the suggestions Fabio made look great to me. Perhaps a useful addition would be to add a service so one can write nothing more than: (service startx-command-service-type) to get a =E2=80=98startx=E2=80=99 command? (Not a blocker though.) Ludo=E2=80=99.