From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id SOH/A6zacGYnbAAAqHPOHw:P1 (envelope-from ) for ; Tue, 18 Jun 2024 00:54:04 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id SOH/A6zacGYnbAAAqHPOHw (envelope-from ) for ; Tue, 18 Jun 2024 02:54:04 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=cDc1FO9+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1718672044; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=/nDmAIunAMh822Ab3QlRZ17KhNOEGW2X/qER3ujbBLM=; b=SkxcnLi38NO3sPlleFDdc4hFRk3NNUZd5Qpzfp3Vx83MYtNY1+aLjzzrszEBEJTwX3cr9s zy+bJ8DgLyzIag4OBwuzqPa4TxH+0Ov+MbXhAtCNf81ad5ZzjJbj9nPNm4GaaBnZxLUXVo OgtMBx3/iZEuL0UjRzTim4WgcTpQ6nz0wYrfx3eVYBcvEBHKTx12s0b+vWoMud6sf9kCY+ A5CYVOTfG6aNtyTjTkSbrHsYaC2cykbs/R6akuFWlj01PAmZilOox6LuU4lynN3HssGSXi VwbwoLfeBmbWM+vuxBnTEm+sFfGPFWKvDd3QWOyyU08HZEMylGz/ekuDmUdwnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=freakingpenguin.com header.s=x header.b=cDc1FO9+; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1718672044; a=rsa-sha256; cv=none; b=uWkkjpIVOq9xCInIVMr279f71J9lbV2oYQUPT1uf1unotx8i6rKpzzlDqZlcwbfJilmtZL Ozk1QCA2ZJZkDwhsC005Bs8/N4huWgue47sRHVu/r3Wr/RmLP2Mr/1ekVbCUUhlXc8a0d1 5kLn71DE8ORkk7wEzhynmB4CfAPtfHJ86l7IroFDj+dm3bQwtC4Is48u2gUIpNRWLvjx7t MtOP+tjGYH2koGKSY8RGEP/jIcqPKmiZQjewL8mGqY2RfWIehKUPU/WAiQxMP2bNmG/vTt Vly+0/08tTiS0rPpYwNzEIUgktqZMskv9SxsXLHHtsVKGUr80C83Mrhi9Z8lXA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A51C973371 for ; Tue, 18 Jun 2024 02:54:03 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sJN6n-0004mk-69; Mon, 17 Jun 2024 20:54:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sJN6l-0004mK-Tx for guix-patches@gnu.org; Mon, 17 Jun 2024 20:53:59 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sJN6l-0005Z2-LO for guix-patches@gnu.org; Mon, 17 Jun 2024 20:53:59 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sJN6n-0005IM-Th for guix-patches@gnu.org; Mon, 17 Jun 2024 20:54:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file Resent-From: Richard Sent Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 18 Jun 2024 00:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71561 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 71561@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Florian Pelz , Matthew Trzcinski Received: via spool by 71561-submit@debbugs.gnu.org id=B71561.171867200820293 (code B ref 71561); Tue, 18 Jun 2024 00:54:01 +0000 Received: (at 71561) by debbugs.gnu.org; 18 Jun 2024 00:53:28 +0000 Received: from localhost ([127.0.0.1]:38641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN6G-0005HF-0Z for submit@debbugs.gnu.org; Mon, 17 Jun 2024 20:53:28 -0400 Received: from mail-108-mta248.mxroute.com ([136.175.108.248]:39519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sJN6D-0005H6-Us for 71561@debbugs.gnu.org; Mon, 17 Jun 2024 20:53:26 -0400 Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta248.mxroute.com (ZoneMTA) with ESMTPSA id 19028d5859900017a3.001 for <71561@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 18 Jun 2024 00:53:20 +0000 X-Zone-Loop: f8f562019877892e28f4de307796e4133887e1d146c0 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=freakingpenguin.com; s=x; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/nDmAIunAMh822Ab3QlRZ17KhNOEGW2X/qER3ujbBLM=; b=cDc1FO9+lmy2FZHJfnD9FhXh8d 0Px9utLXjo+myHOjQBPy1q1IPrWBMw2X1uOxJPjj/F7U7CYy6b6tJe+F5egmcI1qQyv1L5iAIgUCa EtVn0ZIkoVCMuwTetY0swH+OcoRssdkzx1JuGbmgUc9Jzs+7MNY16zYaUvH4xW1j/FDwy5l0zSklh /napZj/xzDdoj6q7Du+3UFGtZikDpm7V6Cp1MS0eLTEBqfexynhyaA453wDKgFe2NIMTvALgR049J ZkXmRKsYFqlxcws4pi87WvgtxAsRddj7qGpFtKT6j7z4A4N+M2Vqme1Aa2pJIEcrn24XmJQTPkeys Wh8LuIzQ==; From: Richard Sent In-Reply-To: <87o77zfflt.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 17 Jun 2024 17:01:50 -0400") References: <0888b6afe4003512c452fad2bc88370b007fc0ca.1718387578.git.richard@freakingpenguin.com> <87o77zfflt.fsf@gmail.com> Date: Mon, 17 Jun 2024 20:53:10 -0400 Message-ID: <87ed8vgjgp.fsf@freakingpenguin.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Id: richard@freakingpenguin.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -4.21 X-Migadu-Queue-Id: A51C973371 X-Migadu-Scanner: mx10.migadu.com X-Migadu-Spam-Score: -4.21 X-TUID: 3hiHlj+ji5l4 Hi Maxim, > Nitpick: The file name should be complete, including the extension. > Pressing 'C' on the diff's hunk while authoring a commit message in > Magit (Emacs) creates a ChangeLog entry automatically, if that helps. Huh, I didn't know that. Good to know, thanks. > I'd perhaps reword this to: > > (dhcp-client-configuration) [config-file]: New field. > (dhcp-client-configuration-config-file): New accessor. I believe these comments have been addressed in v2. I also added another commit to prepend "ISC" in references to DHCP client. This way it should be clearer this service is specific to the ISC's implementation. -- Take it easy, Richard Sent Making my computer weirder one commit at a time.