unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Richard Sent <richard@freakingpenguin.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 71561@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>,
	"Florian Pelz" <pelzflorian@pelzflorian.de>,
	"Matthew Trzcinski" <matt@excalamus.com>
Subject: [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file
Date: Mon, 17 Jun 2024 20:53:10 -0400	[thread overview]
Message-ID: <87ed8vgjgp.fsf@freakingpenguin.com> (raw)
In-Reply-To: <87o77zfflt.fsf@gmail.com> (Maxim Cournoyer's message of "Mon, 17 Jun 2024 17:01:50 -0400")

Hi Maxim,

> Nitpick: The file name should be complete, including the extension.
> Pressing 'C' on the diff's hunk while authoring a commit message in
> Magit (Emacs) creates a ChangeLog entry automatically, if that helps.

Huh, I didn't know that. Good to know, thanks.

> I'd perhaps reword this to:
>
> (dhcp-client-configuration) [config-file]: New field.
> (dhcp-client-configuration-config-file): New accessor.

I believe these comments have been addressed in v2. I also added another
commit to prepend "ISC" in references to DHCP client. This way it should
be clearer this service is specific to the ISC's implementation.

-- 
Take it easy,
Richard Sent
Making my computer weirder one commit at a time.




  reply	other threads:[~2024-06-18  0:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-14 17:52 [bug#71561] [PATCH] services: networking: Allow dhcp-client to use a config file Richard Sent
2024-06-17 21:01 ` Maxim Cournoyer
2024-06-18  0:53   ` Richard Sent [this message]
2024-06-18  0:49 ` [bug#71561] [PATCH 1/2] " Richard Sent
2024-06-18  0:49   ` [bug#71561] [PATCH 2/2] doc: Prepend ISC to DHCP client references Richard Sent
2024-06-18 12:12     ` Maxim Cournoyer
2024-06-18 12:12   ` [bug#71561] [PATCH 1/2] services: networking: Allow dhcp-client to use a config file Maxim Cournoyer
2024-06-24  2:15 ` bug#71561: [PATCH] " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed8vgjgp.fsf@freakingpenguin.com \
    --to=richard@freakingpenguin.com \
    --cc=71561@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    --cc=matt@excalamus.com \
    --cc=maxim.cournoyer@gmail.com \
    --cc=pelzflorian@pelzflorian.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).