unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Jelle Licht <jlicht@fsfe.org>
To: Ashvith Shetty <ashvithshetty10@gmail.com>, 71581@debbugs.gnu.org
Cc: Ashvith Shetty <ashvithshetty10@gmail.com>
Subject: [bug#71581] [PATCH 11/11] gnu: Remove node-bootstrap.
Date: Wed, 19 Jun 2024 10:06:04 +0200	[thread overview]
Message-ID: <87ed8tuzkj.fsf@fsfe.org> (raw)
In-Reply-To: <62b68f1e5db41296ba22bbc9f9d91f1519fb9982.1718737412.git.ashvithshetty10@gmail.com>

Hi Ashvith,

Thank you for working on Node.js related things in guix.

My apologies for not looking into your set of contributions earlier, I
have an longer train ride coming up where I can set aside some time for
proper reviews.

Ashvith Shetty <ashvithshetty10@gmail.com> writes:

> * gnu/packages/node.scm (node-bootstrap): Delete variable.

It seems there has been a misunderstanding (not on your side!) about the
construction of the llhttp package.

It is a bunch of javascript that generates code in C, which can
subsequently be compiled by any C compiler. This means that the llhttp
package that is currently included in guix does not meet our packaging
criteria, and should be patched and/or removed. I'll send a bug report
for this separate issue later.

(IMHO this will boil down to it being built like llhttp-bootstrap, but
perhaps using the node package instead of the node-lts package. Either
way, the node-bootstrap and llhttp-bootstrap packages would still be
needed)

Provided I didn't misread the situation, this makes your patches require
rework; perhaps we could discuss a way forward that respects your time
as much as possible. It might make sense to jump up to the latest
Node.js LTS version (20.x.y) instead of the 18 series. I even think we
could patch more modern llhttp versions so that we could still build
them with Node.js 14 (node-bootstrap), in which case we could move
towards the Node.js 22 series.

Kind regards,
Jelle




  reply	other threads:[~2024-06-19  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <361a358ac968efb4148512054e62f0f211abf7f7.1718737412.git.ashvithshetty10@gmail.com>
2024-06-18 19:05 ` [bug#71581] [PATCH 11/11] gnu: Remove node-bootstrap Ashvith Shetty
2024-06-19  8:06   ` Jelle Licht [this message]
2024-06-19 10:52     ` Ashvith Shetty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed8tuzkj.fsf@fsfe.org \
    --to=jlicht@fsfe.org \
    --cc=71581@debbugs.gnu.org \
    --cc=ashvithshetty10@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).