unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Zheng Junjie <zhengjunjie@iscas.ac.cn>
To: "Artyom V. Poptsov" <poptsov.artyom@gmail.com>
Cc: Wilko Meyer <w@wmeyer.eu>,
	72957@debbugs.gnu.org, Leo Famulari <leo@famulari.name>
Subject: [bug#72957] [PATCH] gnu: Add bin-graph.
Date: Wed, 04 Sep 2024 10:43:52 +0800	[thread overview]
Message-ID: <87ed602l5j.fsf@iscas.ac.cn> (raw)
In-Reply-To: <1441b8dd251c1fe66966d807a6f663ca2700f9c6.1725271047.git.poptsov.artyom@gmail.com> (Artyom V. Poptsov's message of "Mon, 2 Sep 2024 12:57:27 +0300")

[-- Attachment #1: Type: text/plain, Size: 2583 bytes --]

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> writes:


maybe gnu/packages/graph.scm better here

> * gnu/packages/linux.scm (bin-graph): New variable.
>
> Change-Id: I7405cbc00e038d024d035fb100473352c9a7b59d
> ---
>  gnu/packages/linux.scm | 37 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
> index 318c6ccf13..38f3d6fc2f 100644
> --- a/gnu/packages/linux.scm
> +++ b/gnu/packages/linux.scm
> @@ -1776,6 +1776,43 @@ (define-public bbswitch-module
>  graphics card on Optimus laptops.")
>        (license license:gpl2))))
>  
> +(define-public bin-graph
> +  ;; XXX: The upstream does not have tags yet.
> +  (let ((commit "1dd42e3e8e123e993d6c287967502c8d4b36f9ba")
> +        (revision "0"))
> +    (package
> +      (name "bin-graph")
> +      (version (git-version "0.0.0" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/8dcc/bin-graph")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1wjkl789r7iys3nnyk813gsdxwwy2ryxgxirx5xw02lzk790dywl"))))
> +      (arguments
> +       (list #:tests? #f                ; no tests
> +             #:make-flags
> +             #~(list (string-append "CC=" #$(cc-for-target))
> +                     (string-append "PREFIX=" #$output))

see https://github.com/8dcc/bin-graph/blob/f5c53c427248d3fe10c1c921ea134f4592fbe8b7/Makefile#L10C1-L10C12

when use (string-append "INSTALL_DIR=" #$output "/bin") , not need to
replace install phase.

> +             #:phases
> +             #~(modify-phases %standard-phases
> +                 (delete 'configure)

please add a comment, ; no configure script

> +                 (replace 'install
> +                   (lambda _
> +                     (install-file "bin-graph"
> +                                   (string-append #$output "/bin")))))))
> +      (build-system gnu-build-system)
> +      (inputs (list libpng))
> +      (home-page "https://github.com/8dcc/bin-graph")
> +      (synopsis "Visualize binary files")
> +      (description
> +       "@code{bin-graph} provides a simple way of visualizing the different regions
> +of a binary file.")
> +      (license license:gpl3))))
> +
>  (define-public ddcci-driver-linux
>    (package
>      (name "ddcci-driver-linux")
>
> base-commit: a977900d76b7585c401222a3ce8bbb82e5f6da45

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  reply	other threads:[~2024-09-04  2:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02  9:57 [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov
2024-09-04  2:43 ` Zheng Junjie [this message]
2024-09-04  7:46   ` Artyom V. Poptsov
2024-09-04  7:40 ` [bug#72957] [PATCH v2] " Artyom V. Poptsov
2024-09-18  8:53 ` [bug#72957] Looks good Andreas Enge
2024-10-13 10:17 ` [bug#72957] [PATCH] gnu: Add bin-graph Artyom V. Poptsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed602l5j.fsf@iscas.ac.cn \
    --to=zhengjunjie@iscas.ac.cn \
    --cc=72957@debbugs.gnu.org \
    --cc=leo@famulari.name \
    --cc=poptsov.artyom@gmail.com \
    --cc=w@wmeyer.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).