* [bug#73796] [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation.
@ 2024-10-13 19:00 Ian Eure
2024-10-15 16:21 ` bug#73796: " Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Ian Eure @ 2024-10-13 19:00 UTC (permalink / raw)
To: 73796; +Cc: Ian Eure
The icons and appdata.xml were getting installed into share/applications, when
they should have gone into share/icons/hicolor and share/metainfo. Put them
in the right place, which allows DEs to find them.
* (jellyfin-mpv-shim): Fix icon & metainfo installation.
Change-Id: Ic6cdae2fe0b348b94285bf8b39c014922baae6c1
---
gnu/packages/video.scm | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 1d2ab5fbeb..92c0acef3c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2830,16 +2830,24 @@ (define-public jellyfin-mpv-shim
(lambda* (#:key outputs #:allow-other-keys)
(let* ((out (assoc-ref outputs "out"))
(apps (string-append out "/share/applications"))
+ (metainfo (string-append out "/share/metainfo"))
+ (icons (string-append out "/share/icons"))
(desktop-base "jellyfin_mpv_shim/integration/")
(package-id
"com.github.iwalton3.jellyfin-mpv-shim"))
(for-each (lambda (size)
- (install-file (format #f
- "~ajellyfin-~a.png"
- desktop-base size) apps))
+ (let ((dir (format
+ #f "~a/hicolor/~ax~a/apps/"
+ icons size size package-id)))
+ (mkdir-p dir)
+ (copy-file
+ (format #f
+ "~ajellyfin-~a.png"
+ desktop-base size)
+ (string-append dir package-id ".png"))))
'(256 128 64 48 32 16))
(install-file (string-append desktop-base package-id
- ".appdata.xml") apps)
+ ".appdata.xml") metainfo)
(install-file (string-append desktop-base package-id
".desktop") apps)))))))
(inputs (list `(,python "tk")
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#73796: [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation.
2024-10-13 19:00 [bug#73796] [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation Ian Eure
@ 2024-10-15 16:21 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2024-10-15 16:21 UTC (permalink / raw)
To: Ian Eure; +Cc: 73796-done
Ian Eure <ian@retrospec.tv> skribis:
> The icons and appdata.xml were getting installed into share/applications, when
> they should have gone into share/icons/hicolor and share/metainfo. Put them
> in the right place, which allows DEs to find them.
>
> * (jellyfin-mpv-shim): Fix icon & metainfo installation.
>
> Change-Id: Ic6cdae2fe0b348b94285bf8b39c014922baae6c1
I tweaked the commit log and applied it, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-15 16:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-13 19:00 [bug#73796] [PATCH] gnu: jellyfin-mpv-shim: Fix icon & metainfo installation Ian Eure
2024-10-15 16:21 ` bug#73796: " Ludovic Courtès
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).