unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 74086-done@debbugs.gnu.org
Subject: bug#74086: [PATCH] guix: import: hackage: Support updating to a specific version.
Date: Thu, 14 Nov 2024 15:52:54 +0100	[thread overview]
Message-ID: <87ed3doojd.fsf@gnu.org> (raw)
In-Reply-To: <20241029135354.17423-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Tue, 29 Oct 2024 14:53:51 +0100")

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]

Hi,

Nicolas Graves <ngraves@ngraves.fr> skribis:

> * gnu/import/hackage.scm
> (hackage-fetch-and-hash, hackage-fetch): Support name and version
> argument.
> (import-release): New variable, formerly known as latest-release.
> Support updating to a specific version.

Nice.  Applied with the fix below (spotted a compiler warning).

Thanks,
Ludo’.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 614 bytes --]

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index e3ed98c089..422887d435 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -357,7 +357,7 @@ (define* (hackage->guix-package package-name #:key
   (let ((cabal-meta cabal-hash
                     (if port
                         (read-cabal-and-hash port)
-                        (hackage-fetch-and-hash package-name))))
+                        (hackage-fetch-and-hash package-name #f))))
     (if cabal-meta
         (hackage-module->sexp (eval-cabal cabal-meta cabal-environment)
                               cabal-hash

  reply	other threads:[~2024-11-14 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 13:53 [bug#74086] [PATCH] guix: import: hackage: Support updating to a specific version Nicolas Graves via Guix-patches via
2024-11-14 14:52 ` Ludovic Courtès [this message]
2024-11-14 17:07   ` Nicolas Graves via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed3doojd.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=74086-done@debbugs.gnu.org \
    --cc=ngraves@ngraves.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).