From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id UPz9Mk97OGeg6QAAe85BDQ:P1 (envelope-from ) for ; Sat, 16 Nov 2024 11:00:32 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id UPz9Mk97OGeg6QAAe85BDQ (envelope-from ) for ; Sat, 16 Nov 2024 12:00:31 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=DiLC33Pn; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="ND2LN/je"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1731754831; a=rsa-sha256; cv=none; b=oljy0DJcLAvMTR0hF+vUZv9eAMKmG8rZryO2h5jwIu2R0QY/7dUdrWM7Q6X4VF9oZX57bu BBhgy33OjX2S9anhrjnYa4kQL1jIbCuazL2oqgGZo2eUpXIGcVWz3PfULSyog+x1geHu7A z6RLsESpmwn1ahnIR+EzRMhT189/rEMdxzNOAdgAuNdsHJaVNLHYkkwUrSHMucV1jFfOF7 NJNaCu7bAen531oNRY7tlULYsc80Z5d+v6zFyR6/kg/te3w2aLR1BHY3UqYhJ8BUn5RSU+ 3PopDYZXgsyWrzWSRY+Ll2Quf3R5uuXXzPkoDZbtUeNPe2NkbPjZNG4XALZQvg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=DiLC33Pn; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="ND2LN/je"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1731754831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=pfBTYr2yLSRLqWRp7tLcN12LfmTSe5vl+C6YehKeTwD2WU/GjI0HrQQCVhb9YHDPCFp7xy NNC928Gu0W1O4QIdI05tnJNxuQEUgFMf1eYnVvZVNRSO6C1BhHZdKoJ10C94RjRZqnkxB2 963BW/vvVZJGDKlG8OA2AdBN2ipFIrs2kPzc/SAbYyx9sJoExkc7s/1+M25AKCb0Z6Jjc6 2ED9cOzo3k7IK6sYvW9AKKEkSakF0M8fq4CtZkR83jAza6DwztUNamsLEQ0DSI7714ZvLk VcuELxEYuA1ZRSmDcxF37TZK3gJQ0jihSH+O2yJ8kX3SEG8FeCEkc/DiSoZSRA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A33861D611 for ; Sat, 16 Nov 2024 12:00:31 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tCGX9-0001n6-0w; Sat, 16 Nov 2024 06:00:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tCGX5-0001k0-N9 for guix-patches@gnu.org; Sat, 16 Nov 2024 06:00:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tCGX5-0002Ow-6c for guix-patches@gnu.org; Sat, 16 Nov 2024 06:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=DiLC33PntqHm+HaiGyAlCVFFINU2h27/COG5vcWD8nAE2NYdSx9+lry2w5UVKq3SsBuQtoa+22DKIqVOLBkVddmheh2rdwVqqV333NYXoiP/lf3rKcbN3Y5cZ66ZozadpJZnUKYuWwMpo1yLn+H3l76Jhp40UJHNe/BOVebB7K+jwoiRqU4sGtbuoApYDoDTw7ggqDW5ovW9bI0v/8fC1aoumaImpxx2frsGwoBUcMkkk9grj3kUqFlu9KEHyCTeKi2QQScZiJ786OuN4fQ8QPhflbn8Zz4muKaK1SoHhz/1TI8HKBGd9du74o9P4xTu1FgcTnE6/l4hmz9eoD2V8w==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tCGX4-0004Li-S4 for guix-patches@gnu.org; Sat, 16 Nov 2024 06:00:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 16 Nov 2024 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74225 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Dariqq , 74225@debbugs.gnu.org Cc: Josselin Poiret , Mathieu Othacehe , Ludovic =?UTF-8?Q?Court=C3=A8s?= , Tobias Geerinckx-Rice , Dariqq , Christopher Baines Received: via spool by 74225-submit@debbugs.gnu.org id=B74225.173175474916557 (code B ref 74225); Sat, 16 Nov 2024 11:00:02 +0000 Received: (at 74225) by debbugs.gnu.org; 16 Nov 2024 10:59:09 +0000 Received: from localhost ([127.0.0.1]:52237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGWC-0004Iy-U4 for submit@debbugs.gnu.org; Sat, 16 Nov 2024 05:59:09 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:49324) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tCGWA-0004Iq-LY for 74225@debbugs.gnu.org; Sat, 16 Nov 2024 05:59:07 -0500 Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20caccadbeeso17045615ad.2 for <74225@debbugs.gnu.org>; Sat, 16 Nov 2024 02:59:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731754686; x=1732359486; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=ND2LN/jewtX/fDwGIYEuuBBGADJwGhjwDoUgSvRQdUHzS3pju2kdl/meyleCh1zv1x QC+x3LbcWSLrINF5kNHX5uIKerdP7FeYTgvzsCH/8cuV+BXfu1E7EeEPL5mSGmtSP3JN U2TN1nx9Ot52sYfQRzWycsclpDl59Y7J5YRu7pZjtAsdt1eCr6tZO5NioFLD1P89d1J7 i+3Wgz2/iX/x+eA+rlRm9lx3t45RNsnqWz0O5EYA5C9DerM5NEeUVw5NOdwofN3BZ2uN G9/7YHXHIKLVkeGSGtyLPCBVGuEZLDeFg4IWUB30PVJfzX6uTOmA7N9QXNr9Z3tMNR7s 4mmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731754686; x=1732359486; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AmXbB0uQigtSCn3fSGRu6n2Sx9nRsUIVQavHRLTxKZE=; b=hkUCg6h1LtHS7evcStkdAauQm5UrVlzlOkaMFrzDdScq5zSJnlcwxFCUbGvx3disWv JNCurpqyDeQq6pg3s8/kwnrGdfJp1GLJJSza9tceIiY3De1mcuXQUOc3s3+umGsMmPpo HXbR0kCv2TjFRWaNd+osgT3rwcg7ccXFH+22cuXean58rgDomh1tUJkPml16hovjB5sJ 3ziC3BLiyLdzSErlSX+qX0DsfLPXGI+agYNwr62vy0oStsMivzVAfeJLEgw5NEZhZFTQ o2ZjpLpFyav/DXYva+wMwwdK66ub7h0hqrZRy4Wpaqa58uuY3e8or8XS+RkU4Bvwb0pP GXHQ== X-Forwarded-Encrypted: i=1; AJvYcCVrfJ5Mp/ZkBvGttvanlaYAzpOWgdEyVufHCXDQ+S8YerSy4vu2DQaOAoAdARRVTOM3q7JLYA==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yx1vRmWH8b9rmdI9/JtzCdMfC4bRCE58w71KG03mbS4+ARhB6US G4qGOXXDRss7Byv2SDKxbbsnPkxSgwLQwBYULZa3jQ1mJZ+zwAo2 X-Google-Smtp-Source: AGHT+IGLU1Ip6pUA/X64Z6gwG4v8KAvZXVskNNKYlFGJUhKi34W71cuii2jdypR/PpE9taAP0bsDNA== X-Received: by 2002:a17:902:da92:b0:20b:5be:a403 with SMTP id d9443c01a7336-211d0d5eafdmr77721865ad.11.1731754685956; Sat, 16 Nov 2024 02:58:05 -0800 (PST) Received: from lili ([147.127.248.1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0ec937esm25690685ad.91.2024.11.16.02.57.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2024 02:58:05 -0800 (PST) From: Simon Tournier In-Reply-To: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> References: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net> Date: Sat, 16 Nov 2024 09:07:54 +0100 Message-ID: <87ed3bbnz9.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.48 X-Spam-Score: -5.48 X-Migadu-Queue-Id: A33861D611 X-Migadu-Scanner: mx12.migadu.com X-TUID: rXzknzOrfcWy Hi, On Wed, 06 Nov 2024 at 10:46, Dariqq wrote: > diff --git a/guix/lint.scm b/guix/lint.scm > index 8c6c20c723..4ba728da33 100644 > --- a/guix/lint.scm > +++ b/guix/lint.scm > @@ -1433,6 +1433,10 @@ (define (check-optional-tests package) > (match delta > (`(replace 'check ,expression) > (check-check-procedure expression)) > + (`(add-after ,_ 'check ,expression) > + (check-check-procedure expression)) > + (`(add-before ,_ 'check ,expression) > + (check-check-procedure expression)) Please note that 'check here is up to packagers. They might pick the symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or whatever else. To my knowledge, there is no real convention. Well, I do not know. Cheers, simon