unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Simon Tournier <zimon.toutoune@gmail.com>
To: Dariqq <dariqq@posteo.net>, 74225@debbugs.gnu.org
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
	"Mathieu Othacehe" <othacehe@gnu.org>,
	"Ludovic Courtès" <ludo@gnu.org>,
	"Tobias Geerinckx-Rice" <me@tobias.gr>,
	Dariqq <dariqq@posteo.net>,
	"Christopher Baines" <guix@cbaines.net>
Subject: [bug#74225] [PATCH] lint: Check for more types of custom 'check phases.
Date: Sat, 16 Nov 2024 09:07:54 +0100	[thread overview]
Message-ID: <87ed3bbnz9.fsf@gmail.com> (raw)
In-Reply-To: <705438b285d013ee05c5ae1d73b1c80aff2aa4fa.1730890007.git.dariqq@posteo.net>

Hi,

On Wed, 06 Nov 2024 at 10:46, Dariqq <dariqq@posteo.net> wrote:

> diff --git a/guix/lint.scm b/guix/lint.scm
> index 8c6c20c723..4ba728da33 100644
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
>      (match delta
>        (`(replace 'check ,expression)
>         (check-check-procedure expression))
> +      (`(add-after ,_ 'check ,expression)
> +       (check-check-procedure expression))
> +      (`(add-before ,_ 'check ,expression)
> +       (check-check-procedure expression))

Please note that 'check here is up to packagers.  They might pick the
symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or
whatever else.  To my knowledge, there is no real convention.

Well, I do not know.

Cheers,
simon




  reply	other threads:[~2024-11-16 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06 10:46 [bug#74225] [PATCH] lint: Check for more types of custom 'check phases Dariqq
2024-11-16  8:07 ` Simon Tournier [this message]
2024-11-19 14:32   ` Dariqq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ed3bbnz9.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=74225@debbugs.gnu.org \
    --cc=dariqq@posteo.net \
    --cc=dev@jpoiret.xyz \
    --cc=guix@cbaines.net \
    --cc=ludo@gnu.org \
    --cc=me@tobias.gr \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).