bug#26462: Fix crashes in programs using system ICU

["Clément Lassieur" <clement@lassieur.org>]

ng0 <contact.ng0@cryptolab.net> writes:
> Clément Lassieur transcribed 0.8K bytes:
>> ng0 <contact.ng0@cryptolab.net> writes:
>> 
>> > Clément Lassieur transcribed 0.1K bytes:
>> >> The first patch fixes system ICU.  This allows Icecat to use system ICU
>> >
>> > Cool :)
>> >
>> >> without crashing, and it also fixes crashes in 0ad, which I'm working
>> >> on.
>> >> 
>> >> 
>> >> 
>> > Woooo. You picked up my 0ad work (or started from scratch)? I was stuck on mozjs38 for an eternity
>> > and gave up.
>> > Do you need further help or something? I unpublished the repo this was
>> > in, so the last progress isn't public.
>> 
>> :-) I picked up your work, of course.  The mozjs issue is fixed (a patch
>> that was applied to the bundled mozjs had to be applied to the system
>> mozjs we use), and with this ICU patch, I can play!  I just played for
>> 5min without a problem.  I just need to cleanup things, to package NVTT
>> (did you do it?), and then I can send the patch.
>
> Wow :) That is so exciting... really. And you only get to add the
> package on top of every package list "0" and "a" once :D

Cool! ;)

> I don't want to sound pushy or anything, I don't even know how much I
> messed up or not, but it would be cool to mention me as co-authored
> depending on the code :)
> If you don't do it, it's fine aswell because I'm so happy you picked it up!

Of course I'll do it!  You did most of the work :)

> No, I left NVTT as "to do". But when I had an github account, I made
> Nvidia publish a new release for NVTT. So it's just a matter of
> packaging the NVTT dependencies. This should not block the 0ad package
> commit in my opinion. As no release happened for a long time - until I requested them to
> do so - every project which makes use of NVTT just bundled a working state of NVTT.

Ok, so I'll let it as is if you think it's fine.