unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* bug#26889: Tests for emacs-clojure-mode
@ 2017-05-11 18:31 Arun Isaac
  2017-05-12 21:48 ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-05-11 18:31 UTC (permalink / raw)
  To: 26889

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]


Please find attached a patch set for adding ert-runner, emacs-ansi,
emacs-commander, and enabling tests for emacs-clojure-mode.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: series.patch --]
[-- Type: text/x-patch, Size: 7971 bytes --]

From 52c39f301978ec7081f43466aec5211185eb43dd Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:23:30 +0530
Subject: [PATCH 1/4] gnu: Add emacs-ansi.

* gnu/packages/emacs.scm (emacs-ansi): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 41fc240e1..a95cf519b 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4646,3 +4646,30 @@ addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
 comment out lines of code in evil mode.  It provides @code{gcc} to comment out
 lines, and @code{gc} to comment out the target of a motion.")
     (license license:gpl3+)))
+
+;; Tests for emacs-ansi have a circular dependency with ert-runner, and
+;; therefore cannot be run
+(define-public emacs-ansi
+  (package
+    (name "emacs-ansi")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/rejeep/ansi.el/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "13jj4vbi98j3p17hs99bmy7g21jd5h4v3wpxk4pkvhylm3bfwjw8"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-s" ,emacs-s)))
+    (home-page "https://github.com/rejeep/ansi.el")
+    (synopsis "Convert strings to ANSI")
+    (description "@code{emacs-ansi} defines functions that turns simple
+strings to ANSI strings.  Turning a string into an ANSI string can be to add
+color to a text, add color in the background of a text or adding a style, such
+as bold, underscore or italic.")
+    (license license:gpl3+)))
-- 
2.12.2

From 75b5e7ae59be84680077dca4942eecca275f7c8c Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:24:43 +0530
Subject: [PATCH 2/4] gnu: Add emacs-commander.

* gnu/packages/emacs.scm (emacs-commander): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a95cf519b..e2dbb12c4 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4673,3 +4673,29 @@ strings to ANSI strings.  Turning a string into an ANSI string can be to add
 color to a text, add color in the background of a text or adding a style, such
 as bold, underscore or italic.")
     (license license:gpl3+)))
+
+;; Tests for emacs-commander have a circular dependency with ert-runner, and
+;; therefore cannot be run
+(define-public emacs-commander
+  (package
+    (name "emacs-commander")
+    (version "0.7.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/rejeep/commander.el/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "196s2i15z7gwxa97l1wkxvjnfmj5n38wwm6d3g4zz15l2vqggc2y"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)))
+    (home-page "https://github.com/rejeep/commander.el")
+    (synopsis "Emacs command line parser")
+    (description "@code{emacs-commander} provides command line parsing for
+Emacs.")
+    (license license:gpl3+)))
-- 
2.12.2

From 77491a17bbbaef34d94bd37732a031988796aa66 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:25:27 +0530
Subject: [PATCH 3/4] gnu: Add ert-runner.

* gnu/packages/emacs.scm (ert-runner): New variable.
---
 gnu/packages/emacs.scm | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e2dbb12c4..e2d2e0786 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4699,3 +4699,57 @@ as bold, underscore or italic.")
     (description "@code{emacs-commander} provides command line parsing for
 Emacs.")
     (license license:gpl3+)))
+
+;; Tests for ert-runner have a circular dependency with ecukes, and therefore
+;; cannot be run
+(define-public ert-runner
+  (let ((dependencies
+         `(("emacs-ansi" ,emacs-ansi)
+           ("emacs-commander" ,emacs-commander)
+           ("emacs-dash" ,emacs-dash)
+           ("emacs-f" ,emacs-f)
+           ("emacs-s" ,emacs-s)
+           ("emacs-shut-up" ,emacs-shut-up))))
+    (package
+      (name "ert-runner")
+      (version "0.7.0")
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append "https://github.com/rejeep/ert-runner.el/archive/v"
+                             version ".tar.gz"))
+         (file-name (string-append name "-" version ".tar.gz"))
+         (sha256
+          (base32
+           "1657nck9i96a4xgl8crfqq0s8gflzp21pkkzwg6m3z5npjxklgwp"))))
+      (build-system emacs-build-system)
+      (inputs dependencies)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'install-executable
+             (lambda* (#:key inputs outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (substitute* "bin/ert-runner"
+                   (("ERT_RUNNER=\"\\$\\(dirname \\$\\(dirname \\$0\\)\\)")
+                    (string-append "ERT_RUNNER=\"" out
+                                   "/share/emacs/site-lisp/guix.d/"
+                                   ,name "-" ,version)))
+                 (install-file "bin/ert-runner" (string-append out "/bin"))
+                 (wrap-program (string-append out "/bin/ert-runner")
+                   (list "EMACSLOADPATH" ":" '=
+                         (append
+                          (map (lambda (name version)
+                                 (string-append
+                                  (assoc-ref inputs name)
+                                  "/share/emacs/site-lisp/guix.d/"
+                                  (substring name 6) "-" version))
+                               ',(map car dependencies)
+                               ',(map (compose package-version cadr) dependencies))
+                          (list ""))))))))))
+      (home-page "https://github.com/rejeep/ert-runner.el")
+      (synopsis "Opinionated Ert testing workflow")
+      (description "@code{ert-runner} is a tool for Emacs projects tested
+using ERT.  It assumes a certain test structure setup and can therefore make
+running tests easier.")
+      (license license:gpl3+))))
-- 
2.12.2

From 8b9bfa1f646d7211514395400adb1abaf4c2369c Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:28:53 +0530
Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests.

* gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase.
[native-inputs]: Add emacs-dash, emacs-s and ert-runner.
---
 gnu/packages/emacs.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index e2d2e0786..e45368cdd 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2882,6 +2882,16 @@ S-expression.")
                (base32
                 "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81"))))
     (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-s" ,emacs-s)
+       ("ert-runner" ,ert-runner)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'check
+           (lambda* (#:key inputs #:allow-other-keys)
+             (zero? (system* "ert-runner")))))))
     (home-page "https://github.com/clojure-emacs/clojure-mode")
     (synopsis "Major mode for Clojure code")
     (description
-- 
2.12.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#26889: Tests for emacs-clojure-mode
  2017-05-11 18:31 bug#26889: Tests for emacs-clojure-mode Arun Isaac
@ 2017-05-12 21:48 ` Ludovic Courtès
  2017-05-13  5:08   ` Arun Isaac
       [not found]   ` <cu7d1bd1gzd.fsf@systemreboot.net>
  0 siblings, 2 replies; 6+ messages in thread
From: Ludovic Courtès @ 2017-05-12 21:48 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 26889

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> skribis:

> From 52c39f301978ec7081f43466aec5211185eb43dd Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 11 May 2017 23:23:30 +0530
> Subject: [PATCH 1/4] gnu: Add emacs-ansi.
>
> * gnu/packages/emacs.scm (emacs-ansi): New variable.

LGTM.

> From 75b5e7ae59be84680077dca4942eecca275f7c8c Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 11 May 2017 23:24:43 +0530
> Subject: [PATCH 2/4] gnu: Add emacs-commander.
>
> * gnu/packages/emacs.scm (emacs-commander): New variable.

LGTM.

> From 77491a17bbbaef34d94bd37732a031988796aa66 Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 11 May 2017 23:25:27 +0530
> Subject: [PATCH 3/4] gnu: Add ert-runner.
>
> * gnu/packages/emacs.scm (ert-runner): New variable.

[...]

> +(define-public ert-runner
> +  (let ((dependencies
> +         `(("emacs-ansi" ,emacs-ansi)
> +           ("emacs-commander" ,emacs-commander)
> +           ("emacs-dash" ,emacs-dash)
> +           ("emacs-f" ,emacs-f)
> +           ("emacs-s" ,emacs-s)
> +           ("emacs-shut-up" ,emacs-shut-up))))

[...]

> +                 (wrap-program (string-append out "/bin/ert-runner")
> +                   (list "EMACSLOADPATH" ":" '=
> +                         (append
> +                          (map (lambda (name version)
> +                                 (string-append
> +                                  (assoc-ref inputs name)
> +                                  "/share/emacs/site-lisp/guix.d/"
> +                                  (substring name 6) "-" version))
> +                               ',(map car dependencies)
> +                               ',(map (compose package-version cadr) dependencies))
> +                          (list ""))))))))))

I’d suggest ‘match’ instead of car/cadr, and ‘string-drop’
instead of ‘substring’.

Also, I think we should avoid relying on the fact that input labels are
equal to the corresponding package name.  For instance, procedures like
‘package-for-guile-2.2’ mechanically rewrite packages and change their
names, but they do not change the labels.

That gives something like

  ,(match dependencies
     (((labels packages) ...)
      `(map (lambda (label package version)
               (string-append (assoc-ref inputs label)
                              "/share/…" (string-drop package 6)
                              "-" version))
            ',labels
            ',(map package-name packages)
            ',(map package-version packages))))

Last thing: this phase should return #t after the call to
‘wrap-program’.

OK with changes along these lines!

> From 8b9bfa1f646d7211514395400adb1abaf4c2369c Mon Sep 17 00:00:00 2001
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 11 May 2017 23:28:53 +0530
> Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests.
>
> * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase.
> [native-inputs]: Add emacs-dash, emacs-s and ert-runner.

LGTM.

Thank you!

Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26889: Tests for emacs-clojure-mode
  2017-05-12 21:48 ` Ludovic Courtès
@ 2017-05-13  5:08   ` Arun Isaac
  2017-05-13  9:25     ` Alex Kost
       [not found]   ` <cu7d1bd1gzd.fsf@systemreboot.net>
  1 sibling, 1 reply; 6+ messages in thread
From: Arun Isaac @ 2017-05-13  5:08 UTC (permalink / raw)
  To: 26889

[-- Attachment #1: Type: text/plain, Size: 72 bytes --]


Here is another patch set with the suggested changes incorporated.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: series.patch --]
[-- Type: text/x-patch, Size: 8681 bytes --]

From 8947eda0984e3d444b0960e37e92ac622fc9ac9a Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:23:30 +0530
Subject: [PATCH 1/4] gnu: Add emacs-ansi.

* gnu/packages/emacs.scm (emacs-ansi): New variable.
---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 21120b331..cab7f8cf8 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4639,3 +4639,30 @@ addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
 comment out lines of code in evil mode.  It provides @code{gcc} to comment out
 lines, and @code{gc} to comment out the target of a motion.")
     (license license:gpl3+)))
+
+;; Tests for emacs-ansi have a circular dependency with ert-runner, and
+;; therefore cannot be run
+(define-public emacs-ansi
+  (package
+    (name "emacs-ansi")
+    (version "0.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/rejeep/ansi.el/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "13jj4vbi98j3p17hs99bmy7g21jd5h4v3wpxk4pkvhylm3bfwjw8"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-s" ,emacs-s)))
+    (home-page "https://github.com/rejeep/ansi.el")
+    (synopsis "Convert strings to ANSI")
+    (description "@code{emacs-ansi} defines functions that turns simple
+strings to ANSI strings.  Turning a string into an ANSI string can be to add
+color to a text, add color in the background of a text or adding a style, such
+as bold, underscore or italic.")
+    (license license:gpl3+)))
-- 
2.12.2

From 60c83587fbccc3ca096f21772c560642c6265678 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:24:43 +0530
Subject: [PATCH 2/4] gnu: Add emacs-commander.

* gnu/packages/emacs.scm (emacs-commander): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index cab7f8cf8..b1896fdba 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4666,3 +4666,29 @@ strings to ANSI strings.  Turning a string into an ANSI string can be to add
 color to a text, add color in the background of a text or adding a style, such
 as bold, underscore or italic.")
     (license license:gpl3+)))
+
+;; Tests for emacs-commander have a circular dependency with ert-runner, and
+;; therefore cannot be run
+(define-public emacs-commander
+  (package
+    (name "emacs-commander")
+    (version "0.7.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/rejeep/commander.el/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "196s2i15z7gwxa97l1wkxvjnfmj5n38wwm6d3g4zz15l2vqggc2y"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-f" ,emacs-f)
+       ("emacs-s" ,emacs-s)))
+    (home-page "https://github.com/rejeep/commander.el")
+    (synopsis "Emacs command line parser")
+    (description "@code{emacs-commander} provides command line parsing for
+Emacs.")
+    (license license:gpl3+)))
-- 
2.12.2

From b4fa1ebbae2b414139fbdfb3bb44439ae6bfdb0c Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:25:27 +0530
Subject: [PATCH 3/4] gnu: Add ert-runner.

* gnu/packages/emacs.scm (ert-runner): New variable.
---
 gnu/packages/emacs.scm | 64 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 63 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index b1896fdba..a9dd3db6c 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -92,7 +92,8 @@
   #:use-module (gnu packages gd)
   #:use-module (gnu packages fontutils)
   #:use-module (guix utils)
-  #:use-module (srfi srfi-1))
+  #:use-module (srfi srfi-1)
+  #:use-module (ice-9 match))
 
 (define-public emacs
   (package
@@ -4692,3 +4693,64 @@ as bold, underscore or italic.")
     (description "@code{emacs-commander} provides command line parsing for
 Emacs.")
     (license license:gpl3+)))
+
+;; Tests for ert-runner have a circular dependency with ecukes, and therefore
+;; cannot be run
+(define-public ert-runner
+  (let ((dependencies
+         `(("emacs-ansi" ,emacs-ansi)
+           ("emacs-commander" ,emacs-commander)
+           ("emacs-dash" ,emacs-dash)
+           ("emacs-f" ,emacs-f)
+           ("emacs-s" ,emacs-s)
+           ("emacs-shut-up" ,emacs-shut-up))))
+    (package
+      (name "ert-runner")
+      (version "0.7.0")
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append "https://github.com/rejeep/ert-runner.el/archive/v"
+                             version ".tar.gz"))
+         (file-name (string-append name "-" version ".tar.gz"))
+         (sha256
+          (base32
+           "1657nck9i96a4xgl8crfqq0s8gflzp21pkkzwg6m3z5npjxklgwp"))))
+      (build-system emacs-build-system)
+      (inputs dependencies)
+      (arguments
+       `(#:phases
+         (modify-phases %standard-phases
+           (add-after 'install 'install-executable
+             (lambda* (#:key inputs outputs #:allow-other-keys)
+               (let ((out (assoc-ref outputs "out")))
+                 (substitute* "bin/ert-runner"
+                   (("ERT_RUNNER=\"\\$\\(dirname \\$\\(dirname \\$0\\)\\)")
+                    (string-append "ERT_RUNNER=\"" out
+                                   "/share/emacs/site-lisp/guix.d/"
+                                   ,name "-" ,version)))
+                 (install-file "bin/ert-runner" (string-append out "/bin"))
+                 (wrap-program (string-append out "/bin/ert-runner")
+                   (list "EMACSLOADPATH" ":" '=
+                         (append
+                          ,(match dependencies
+                             (((labels packages) ...)
+                              `(map (lambda (label package version)
+                                      (string-append (assoc-ref inputs label)
+                                                     "/share/emacs/site-lisp/guix.d/"
+                                                     (string-drop package 6)
+                                                     "-" version))
+                                    ',labels
+                                    ',(map package-name packages)
+                                    ',(map package-version packages))))
+                          ;; empty element to include the default load path as
+                          ;; determined by emacs' standard initialization
+                          ;; procedure
+                          (list ""))))
+                 #t))))))
+      (home-page "https://github.com/rejeep/ert-runner.el")
+      (synopsis "Opinionated Ert testing workflow")
+      (description "@code{ert-runner} is a tool for Emacs projects tested
+using ERT.  It assumes a certain test structure setup and can therefore make
+running tests easier.")
+      (license license:gpl3+))))
-- 
2.12.2

From 8dc79fafe9e3de005a44524b2ad918ca13f75732 Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Thu, 11 May 2017 23:28:53 +0530
Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests.

* gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase.
[native-inputs]: Add emacs-dash, emacs-s and ert-runner.
---
 gnu/packages/emacs.scm | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a9dd3db6c..4f5988b75 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -2876,6 +2876,16 @@ S-expression.")
                (base32
                 "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81"))))
     (build-system emacs-build-system)
+    (native-inputs
+     `(("emacs-dash" ,emacs-dash)
+       ("emacs-s" ,emacs-s)
+       ("ert-runner" ,ert-runner)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'check
+           (lambda* (#:key inputs #:allow-other-keys)
+             (zero? (system* "ert-runner")))))))
     (home-page "https://github.com/clojure-emacs/clojure-mode")
     (synopsis "Major mode for Clojure code")
     (description
-- 
2.12.2


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#26889: Tests for emacs-clojure-mode
  2017-05-13  5:08   ` Arun Isaac
@ 2017-05-13  9:25     ` Alex Kost
  2017-05-13 15:24       ` Arun Isaac
  0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2017-05-13  9:25 UTC (permalink / raw)
  To: Arun Isaac; +Cc: 26889

Arun Isaac (2017-05-13 10:38 +0530) wrote:

> Here is another patch set with the suggested changes incorporated.

I think Ludovic meant you may commit these patches.  One last comment
from me...

[...]
> From: Arun Isaac <arunisaac@systemreboot.net>
> Date: Thu, 11 May 2017 23:28:53 +0530
> Subject: [PATCH 4/4] gnu: emacs-clojure-mode: Enable tests.
>
> * gnu/packages/emacs.scm (emacs-clojure-mode)[arguments]: Add 'check' phase.
> [native-inputs]: Add emacs-dash, emacs-s and ert-runner.
> ---
>  gnu/packages/emacs.scm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index a9dd3db6c..4f5988b75 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -2876,6 +2876,16 @@ S-expression.")
>                 (base32
>                  "117mvjqh4nm8mvmwmmvy4qmkdg23ldlzk08y91g8b8ac8kxwqg81"))))
>      (build-system emacs-build-system)
> +    (native-inputs
> +     `(("emacs-dash" ,emacs-dash)
> +       ("emacs-s" ,emacs-s)
> +       ("ert-runner" ,ert-runner)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'check
> +           (lambda* (#:key inputs #:allow-other-keys)

'inputs' are not used, so just (lambda _ ...) here.

> +             (zero? (system* "ert-runner")))))))
>      (home-page "https://github.com/clojure-emacs/clojure-mode")
>      (synopsis "Major mode for Clojure code")
>      (description

-- 
Alex

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26889: Tests for emacs-clojure-mode
  2017-05-13  9:25     ` Alex Kost
@ 2017-05-13 15:24       ` Arun Isaac
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-05-13 15:24 UTC (permalink / raw)
  To: Alex Kost; +Cc: 26889


Pushed with all changes incorporated!

Alex Kost writes:

> Arun Isaac (2017-05-13 10:38 +0530) wrote:
>
>> Here is another patch set with the suggested changes incorporated.
>
> I think Ludovic meant you may commit these patches.

I guess that's what he meant. I was just being a little extra
careful. If there was no response in about a day, I would have pushed.

> 'inputs' are not used, so just (lambda _ ...) here.

Anyways, I thought I'd be missing something like this. Hence the extra
careful resubmission of the patch set! :-P

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#26889: Tests for emacs-clojure-mode
       [not found]   ` <cu7d1bd1gzd.fsf@systemreboot.net>
@ 2017-05-14 12:09     ` Arun Isaac
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Isaac @ 2017-05-14 12:09 UTC (permalink / raw)
  To: 26889-done


Forgot to close this bug report earlier. Closing now...

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-05-14 12:11 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 18:31 bug#26889: Tests for emacs-clojure-mode Arun Isaac
2017-05-12 21:48 ` Ludovic Courtès
2017-05-13  5:08   ` Arun Isaac
2017-05-13  9:25     ` Alex Kost
2017-05-13 15:24       ` Arun Isaac
     [not found]   ` <cu7d1bd1gzd.fsf@systemreboot.net>
2017-05-14 12:09     ` Arun Isaac

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).