From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51913)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dX3my-0000W7-96
	for guix-patches@gnu.org; Mon, 17 Jul 2017 07:02:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dX3ms-0006WW-HX
	for guix-patches@gnu.org; Mon, 17 Jul 2017 07:02:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:40606)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dX3ms-0006WS-EG
	for guix-patches@gnu.org; Mon, 17 Jul 2017 07:02:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dX3ms-0007Ou-2Y
	for guix-patches@gnu.org; Mon, 17 Jul 2017 07:02:02 -0400
Subject: [bug#27675] [PATCH] gnu: kbd: Recursively search
	$LOADKEYS_KEYMAP_PATH.
Resent-Message-ID: <handler.27675.B27675.150028926428377@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20170713003425.31282-1-me@tobias.gr> <87poczctc8.fsf@gnu.org>
	<383b1065-2c96-4982-2fc1-92b356a50838@tobias.gr>
Date: Mon, 17 Jul 2017 13:00:51 +0200
In-Reply-To: <383b1065-2c96-4982-2fc1-92b356a50838@tobias.gr> (Tobias
	Geerinckx-Rice's message of "Mon, 17 Jul 2017 11:35:42 +0200")
Message-ID: <87d18z9vks.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 27675@debbugs.gnu.org

Heya,

Tobias Geerinckx-Rice <me@tobias.gr> skribis:

> On 17/07/17 11:20, Ludovic Court=C3=A8s wrote:
>> Tobias Geerinckx-Rice <me@tobias.gr> skribis:
>>=20
>>> Fix a regression since commit fd7000fe33d3c4188c241cab97e2b891dd4e1268.
>
> <snip>
>
>> That works if you copy paste the suggested search path in a shell, but
>> not if we pass it to =E2=80=98evaluate-search-paths=E2=80=99 from (guix =
search-paths)
>
> I'm confused. What exactly doesn't work? Here, after this patch,
> LOADKEYS_KEYMAP_PATH contains "**" like it should.

I mean, it works because it turns out that we pass those ** to Bash,
which does the right thing.

However, a search-path specification is supposed to be understandable
internally by =E2=80=98evaluate-search-paths=E2=80=99 (this is what is used=
 in build
environments, when generating =E2=80=98etc/profile=E2=80=99, when using --s=
earch-paths,
and so on.)  The ** expansion would not happen in contexts where Bash is
not involved, which is not great.

In this case I agree that it=E2=80=99s almost a theoretical problem because=
 in
practice, for LOADKEYS_KEYMAP_PATH, we=E2=80=99re always passing the search=
 path
to the shell.  So maybe it=E2=80=99s not worth fixing after all, dunno.  WD=
YT?

Ludo=E2=80=99.