From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54806) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnjn2-0007eW-2x for guix-patches@gnu.org; Fri, 01 Sep 2017 07:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnjmx-00052K-4O for guix-patches@gnu.org; Fri, 01 Sep 2017 07:07:08 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:58800) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dnjmx-00051x-0M for guix-patches@gnu.org; Fri, 01 Sep 2017 07:07:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dnjmw-0007q2-Fi for guix-patches@gnu.org; Fri, 01 Sep 2017 07:07:02 -0400 Subject: [bug#27905] changes for openmpi Resent-Message-ID: From: Dave Love References: <87zibja1of.fsf@i-ulialbion.it.manchester.ac.uk> <87h8x1t0op.fsf@gnu.org> Date: Fri, 01 Sep 2017 12:06:14 +0100 In-Reply-To: <87h8x1t0op.fsf@gnu.org> ("Ludovic \=\?iso-8859-1\?Q\?Court\=E8s\?\= \=\?iso-8859-1\?Q\?\=22's\?\= message of "Mon, 21 Aug 2017 17:12:06 +0200") Message-ID: <87d17aznix.fsf@albion.it.manchester.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27905@debbugs.gnu.org Ludovic Court=C3=A8s writes: >> * mpi.scm (hwloc)[outputs]: Replace lib with nogui. >> (hwloc)[arguments]: Change configure --prefix; use "nogui" output, >> not "lib"; populate "all" output. >> (openmpi)[inputs]: Use hwloc-nogui. > > The downside of this is that the =E2=80=9Cnogui=E2=80=9D output is less d= iscoverable > (and it=E2=80=99s another user-visible breakage.) I don't understand why it's worse than currently. "hwloc" will provide the same as before, won't it? I guess developer breakage could be fixed by retaining the lib output if it matters. Maybe it's helpful to try to document what sort of stability is expected currently? > Also, it shouldn=E2=80=99t make any difference to the closure size of ope= nmpi > anyway, no? Right. It wasn't for openmpi specifically. >> + (add-after 'install 'install-openmpi >> + (lambda* (#:key outputs #:allow-other-keys) >> + (let ((dest (format #f "~a/lib/valgrind" >> + (assoc-ref outputs "openmpi")))) >> + (mkdir-p dest) >> + (zero? >> + (system (format #f "mv ~a/lib/valgrind/libmpiwrap* ~a" >> + (assoc-ref outputs "out") dest))))))))) > > Why move it to a separate output? After all, we can keep it in =E2=80=9C= out=E2=80=9D > since all it costs is the size of libmpiwrap.so, right? > > Also, I assume that this is functionally equivalent to Open MPI=E2=80=99s > built-in Valgrind support, is it? This is probably moot. It isn't entirely equivalent but, more importantly, the builtin support apparently doesn't have the performance hit which was documented; I haven't checked experimentally. See this thread, though not all my questions were answered: . The wrapper library may still be relevant for mpich-y MPIs, if they get used -- I don't know.