From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46286)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vBE-0005l1-Cr
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:43:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vB8-0003CI-R0
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:43:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:39991)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e4vB8-0003CD-N5
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:43:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e4vB8-00068t-G6
	for guix-patches@gnu.org; Wed, 18 Oct 2017 16:43:02 -0400
Subject: [bug#28841] [PATCH 02/24] =?UTF-8?Q?gnu:=C2=A0Add?= java-tomcat.
Resent-Message-ID: <handler.28841.B28841.150835938123603@debbugs.gnu.org>
References: <20171014233216.49c852f7@lepiller.eu>
	<20171014222349.12902-1-julien@lepiller.eu>
	<20171014222349.12902-2-julien@lepiller.eu>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20171014222349.12902-2-julien@lepiller.eu>
Date: Wed, 18 Oct 2017 22:42:23 +0200
Message-ID: <87d15k428g.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: julien@lepiller.eu
Cc: 28841@debbugs.gnu.org


Hi again,

> * gnu/packages/java.scm (java-tomcat): New variable.
> ---

[…]

> +    (inputs
> +     `(("java-eclipse-jdt-core" ,java-eclipse-jdt-core)))

Actually … I’m *very* surprised that this is the only input here.  I
remember trying to package this early on, but failing because there were
so many unpackaged dependencies.

Are you sure this is the only required input here?  Do the sources come
with bundled jars?

> +         (add-after 'unpack 'properties
> +           (lambda _
> +             (mkdir "downloads")
> +             (substitute* "build.xml"
> +               (("download-compile,") "")
> +               (("depends=\"validate\"") "depends=\"build-prepare\"")
> +               ((",download-validate") ""))
> +             (with-output-to-file "build.properties"
> +               (lambda _
> +                 (display
> +                   (string-append "base.path=" (getcwd)
> "/downloads\n"))))))

Forgot to say this in my previous comment: please end this phase with “#t”.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net