From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36150) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1efSE5-0007ZH-6T for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1efSE2-0001nQ-1I for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:05 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:37475) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1efSE1-0001n9-Tm for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1efSE1-0005GS-Mf for guix-patches@gnu.org; Sat, 27 Jan 2018 10:17:01 -0500 Subject: [bug#30214] [PATCH 03/10] gnu: Add go-github.com-jessevdk-go-flags. Resent-Message-ID: References: <87h8rd4nxg.fsf@cbaines.net> <20180122210830.28924-1-mail@cbaines.net> <20180122210830.28924-3-mail@cbaines.net> <20180122215447.GD15170@jasmine.lan> <87vafs5p79.fsf@cbaines.net> <20180123202935.GD6750@jasmine.lan> <87r2qg5n74.fsf@cbaines.net> <20180123204451.GG6750@jasmine.lan> From: Christopher Baines In-reply-to: <20180123204451.GG6750@jasmine.lan> Date: Sat, 27 Jan 2018 15:15:59 +0000 Message-ID: <87d11vs574.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Famulari Cc: 30214@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Tue, Jan 23, 2018 at 08:34:23PM +0000, Christopher Baines wrote: >>=20 >> Leo Famulari writes: >>=20 >> > On Tue, Jan 23, 2018 at 07:51:06PM +0000, Christopher Baines wrote: >> >> Leo Famulari writes: >> >> > On Mon, Jan 22, 2018 at 09:08:23PM +0000, Christopher Baines wrote: >> >> >> * gnu/packages/golang.scm (go-github.com-jessevdk-go-flags): New v= ariable. >> >> > >> >> >> + (add-after 'unpack 'rename-archive >> >> >> + (lambda _ >> >> >> + (rename-file >> >> >> + ,(string-append "src/github.com/jessevdk/go-flags-"= version) >> >> >> + "src/github.com/jessevdk/go-flags") >> >> >> + #t))))) >> >> > >> >> > Should the go-build-system try to handle this automatically? >> >>=20 >> >> I believe this might be connected with what is in the source >> >> tarball. Without this stage, the go-flags directory is called >> >> go-flags-1.3.0, and this causes the build to fail [2]. >> > >> > Oh right, Go expects you to use Git checkouts instead of release >> > tarballs. I bet it works if you do that. That kind of tarball is >> > automatically created by GitHub per tag, and can't be disabled. >> > >> >> I'm not sure about the wider context, but it would be good to handle >> >> this automatically. >> > >> > So, I think the build system doesn't need to handle this case. >>=20 >> Ok, would it be more appropriate to use a git checkout, rather than a >> tar archive for these packages then? > > Yeah, I bet you can avoid the rename-archive phases if you use a Git > checkout. I've done this now for all the packages, and sent a new set of patches. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlpsl69fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XfUbRAAi/cCsUPP6w9wE0J8LRIBuNtOdGBqYW9dw9zR1BqRe/OgQcsK3vlA1CdB BQfbMTyhzLaToF3HY0fCmvzMh4fdMvi91Rx5I+uZwF7yJU+nDJV3D5JkFXsnapRf D/6oBRO8wgrBLKqYs2MMEf6lgcFIV6a2Wt41ZPpFcDbSGVakDWl6s2oeLuHX/Uf9 bNNtGxuQIUq3nwjxxyvAPQBgvtP5I/AJPfPCuFVf1uACeNWB37r1MG0KTo1aaMd1 SqfKSz+Xse/FLGS54HR+MePiN2TXRJ3R4bdJC5V5M2L166mEILr1R3nSyhdQ1izB w3rMrvqmZf0YBp9Rw9kf9c79eK88if4Na48JsKSVaemxwhz6d3Cs84jy0QFCPej7 ZhQQYTzX9MCIkS3g20yGS1pI25GSDL1XYd6ILHxLml/qkcBQN1uV8M315g+gh/zt OPXNmSn5RQ7gJUmGyy+ilawnxi29GsnHiJ/Zu4TL+j3ayF+ARG2Mz3S/XyugjX5W 5jY4MyTLr+7GehinDgi+7ckf9TZvdXjfzzG4zVf5cCtAkhyBWw3wuqaD9tc5Njof yl6wedpw02RUAj0ZS2Btz4Noxc7tvJ6x9CavtEqFjFo/R8J4oa+rOuxay/qm1bKE z5ukgVtkSEnK1QCg+W3HbEXT+6qPRisdVQRKpnTcDURsszWfSNQ= =KhOQ -----END PGP SIGNATURE----- --=-=-=--