From: Ricardo Wurmus <rekado@elephly.net>
To: Sahithi Yarlagadda <sahi@swecha.net>
Cc: 30885@debbugs.gnu.org
Subject: [bug#30885] Submitting Patch File for r-catdap Package Description for CRAN package
Date: Wed, 21 Mar 2018 07:36:11 +0100 [thread overview]
Message-ID: <87d0zyc4v8.fsf@elephly.net> (raw)
In-Reply-To: <b18b6d13-3a40-4417-097f-4d6564664e62@swecha.net>
Hi Sahithi,
thanks for the patch!
> +
> +(define-public r-catdap
> + (package
> + (name "r-catdap")
> + (version "1.3.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (cran-uri "catdap" version))
> + (sha256
> + (base32
> + "0i877l61f6c75pczi235rzci67w29zv1d7z5zn5p5ymndclvlpl2"))))
> + (build-system r-build-system)
> + (home-page "https://cran.r-project.org/web/packages/catdap/")
> + (synopsis "Categorical data analysis program package")
> + (description
> + "Categorical data analysis by AIC. The methodology is described in
> +Sakamoto (1992) @url{https://www.springer.com/in/book/9780792314295}")
Please use full sentences in the description. In this case I went to
the home page and downloaded the reference manual, which contains this
sentence:
“This package provides functions for analyzing multivariate
data. Dependencies of the distribution of specified variable
(response variable) to other variables (explanatory variables) are
derived and evaluated by AIC (Akaike Information Criterion).”
This is a better description based on that sentence:
This package provides functions for analyzing multivariate data.
Dependencies of the distribution of the specified variable (response
variable) to other variables (explanatory variables) are derived and
evaluated by the @dfn{Akaike Information Criterion} (AIC).
“@dfn” is used for definitions.
> + ;; Any GPL version.
> + (license license:gpl2+)))
The comment is incorrect. The home page says:
License: GPL-2 | GPL-3 [expanded from: GPL (≥ 2)]
This means it is actually GPLv2+.
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
> +
Please don’t add so many empty lines at the end :)
Could you please send an updated patch as a reply to this message?
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
next prev parent reply other threads:[~2018-03-21 6:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 16:48 [bug#30885] Submitting Patch File for r-catdap Package Description for CRAN package Sahithi Yarlagadda
2018-03-21 6:36 ` Ricardo Wurmus [this message]
2018-03-21 10:30 ` Sahithi Yarlagadda
2018-03-21 21:08 ` Ricardo Wurmus
2018-03-22 13:35 ` Sahithi Yarlagadda
2018-03-22 13:56 ` julien lepiller
2018-03-22 14:11 ` Ricardo Wurmus
2018-03-22 15:48 ` Sahithi Yarlagadda
2018-03-23 20:06 ` Sahithi Yarlagadda
2018-03-23 20:57 ` bug#30885: " Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0zyc4v8.fsf@elephly.net \
--to=rekado@elephly.net \
--cc=30885@debbugs.gnu.org \
--cc=sahi@swecha.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).