From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56548) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fic53-0004lY-Ti for guix-patches@gnu.org; Thu, 26 Jul 2018 04:57:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fic51-0008F4-08 for guix-patches@gnu.org; Thu, 26 Jul 2018 04:57:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:53258) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fic50-0008EB-QO for guix-patches@gnu.org; Thu, 26 Jul 2018 04:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fic50-0004ND-9P for guix-patches@gnu.org; Thu, 26 Jul 2018 04:57:02 -0400 Subject: [bug#32165] [PATCH] gnu: Add cdrkit-libre. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20180715170748.4853-1-go.wigust@gmail.com> <87o9ex58pq.fsf@gnu.org> <8736w7pklr.fsf@gmail.com> Date: Thu, 26 Jul 2018 10:56:27 +0200 In-Reply-To: <8736w7pklr.fsf@gmail.com> (Oleg Pykhalov's message of "Wed, 25 Jul 2018 15:26:24 +0300") Message-ID: <87d0va2x50.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Oleg Pykhalov Cc: 32165@debbugs.gnu.org, Nils Gillmann Hello, Oleg Pykhalov skribis: > ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Oleg Pykhalov skribis: >> >>> * gnu/packages/cdrom.scm (cdrkit-libre): New variable. >> >> [...] >> >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append >>> + "https://repo.parabola.nu/other/cdrkit-libre/cdrki= t-libre-" >>> + version ".tar.gz")) >> >> Like Nils I wonder: can you explain how it differs from cdrkit? Could >> we use upstream cdrkit + snippet/patches instead of taking the source >> from Parabola=E2=80=99s repo? > > Comparing Nix cdrkit with Parabola cdrkit-libre tarball not much differ. > > $ /tmp/local$ diff -r -u cdrkit-1.1.11-nix/ cdrkit-1.1.11-parabola/ > Only in cdrkit-1.1.11-nix/doc/genisoimage: README.hfs_boot > Only in cdrkit-1.1.11-nix/genisoimage: apple_driver.8 > Only in cdrkit-1.1.11-nix/genisoimage: apple_driver.c > > > I probably could get a diff for apple_driver.{8,c} files, but the the > upstream URI http://cdrkit.org/releases/cdrkit.tar.gz is dead. I'm not > sure where is a better place to fetch the release tarball except from > another GNU/Linux distribution like Parabola. Uh, indeed. The perhaps add a comment above the URL stating that (1) cdrkit.org is dead, and (2) cdrkit-libre removes a couple of problematic files, with a link to this discussion. >>> + (home-page "http://cdrkit.org/") >> >> Like Nils wrote, is this the right URL? > > It's a right URL, I think. I converted recipe from Parabola, which > references the same URL [1]. Maybe I should use a Parabola repository > URL ? http://cdrkit.org is currently empty. Either way is fine with me. >>> + (synopsis "Portable command-line CD/DVD recorder software, mostly >>> +compatible with cdrtools") >> >> =E2=80=9CCommand-line CD/DVD recorder=E2=80=9D is enough IMO. > > OK. > >>> + (description "Cdrkit is a suite of programs for recording CDs and = DVDs, >>> +blanking CD-RW media, creating ISO-9660 filesystem images, extracting = audio CD >>> +data, and more.") >> >> Here you can mention that it=E2=80=99s =E2=80=9Cmostly compatible =E2=80= =A6=E2=80=9D. > > Do you mean =E2=80=9Ccreating more compatible ISO-9660 =E2=80=A6=E2=80=9D? I meant =E2=80=9Cmostly compatible with cdrtools=E2=80=9D, which is what yo= u had in =E2=80=98synopsis=E2=80=99 initially. Looks like you=E2=80=99re now ready to go. Thank you! Ludo=E2=80=99.