From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 32740@debbugs.gnu.org
Subject: [bug#32740] [PATCH] git-download: Don't assume the git checkout is the parent of ".git".
Date: Sun, 23 Sep 2018 21:55:47 +0200 [thread overview]
Message-ID: <87d0t4rnss.fsf@gnu.org> (raw)
In-Reply-To: <87y3bsl5lm.fsf@fastmail.com> (Marius Bakke's message of "Sun, 23 Sep 2018 15:13:09 +0200")
Hello!
Marius Bakke <mbakke@fastmail.com> skribis:
> From e8b443e1de0a5b1e3dfeee024cd0625790f4f834 Mon Sep 17 00:00:00 2001
> From: Marius Bakke <mbakke@fastmail.com>
> Date: Sat, 15 Sep 2018 11:53:40 +0200
> Subject: [PATCH] git-download: Don't assume the working directory is the
> parent of ".git".
>
> * guix/git-download.scm (git-file-list): Use REPOSITORY-WORKING-DIRECTORY to
> locate checkout. Rename from "top" to "workdir".
> ---
> guix/git-download.scm | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/guix/git-download.scm b/guix/git-download.scm
> index 24cf11be5..eb20927c7 100644
> --- a/guix/git-download.scm
> +++ b/guix/git-download.scm
> @@ -156,22 +156,21 @@ HASH-ALGO (a symbol). Use NAME as the file name, or a generic name if #f."
> The result is similar to that of the 'git ls-files' command, except that it
> also includes directories, not just regular files. The returned file names
> are relative to DIRECTORY, which is not necessarily the root of the checkout."
> - (let* ((directory (canonicalize-path directory))
> + (let* ((directory (string-append (canonicalize-path directory) "/"))
Could you just add a comment here explaining that
‘repository-working-directory’ always appends a trailing slash?
Otherwise LGTM, thank you!
Ludo’.
next prev parent reply other threads:[~2018-09-23 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-15 10:10 [bug#32740] [PATCH] git-download: Don't assume the git checkout is the parent of ".git" Marius Bakke
2018-09-17 19:19 ` Leo Famulari
2018-09-21 9:49 ` Ludovic Courtès
2018-09-21 9:48 ` Ludovic Courtès
2018-09-23 13:13 ` Marius Bakke
2018-09-23 19:55 ` Ludovic Courtès [this message]
2018-09-25 22:41 ` bug#32740: " Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0t4rnss.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32740@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).