From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59808)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOmmd-00010x-Bp
	for guix-patches@gnu.org; Mon, 19 Nov 2018 11:52:24 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOmeY-0006QT-OP
	for guix-patches@gnu.org; Mon, 19 Nov 2018 11:44:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:56908)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gOmeX-0006Py-UK
	for guix-patches@gnu.org; Mon, 19 Nov 2018 11:44:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gOmeX-0008Gp-Qh
	for guix-patches@gnu.org; Mon, 19 Nov 2018 11:44:01 -0500
Subject: [bug#33185] [PATCH 7/7] services: Add patchwork.
Resent-Message-ID: <handler.33185.B33185.154264578531711@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20181104104455.3527-1-mail@cbaines.net>
	<20181104104455.3527-7-mail@cbaines.net>
	<b32159e7-080a-ecb8-513b-3cd57959a0dd@riseup.net>
Date: Mon, 19 Nov 2018 17:42:55 +0100
In-Reply-To: <b32159e7-080a-ecb8-513b-3cd57959a0dd@riseup.net> (swedebugia's
	message of "Sun, 4 Nov 2018 20:10:42 +0100")
Message-ID: <87d0r1xblc.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: swedebugia <swedebugia@riseup.net>
Cc: 33185@debbugs.gnu.org

Hello,

swedebugia <swedebugia@riseup.net> skribis:

> On 2018-11-04 11:44, Christopher Baines wrote:
>> ---
>>   gnu/services/web.scm | 297 ++++++++++++++++++++++++++++++++++++++++++-
>>   gnu/tests/web.scm    | 104 ++++++++++++++-
>>   2 files changed, 399 insertions(+), 2 deletions(-)
>
> Nice work with the service-declaration. :) (untested)

+1!

> Would you be willing to update the patch with documentation also?

Yes, also with =E2=80=98documentation=E2=80=99 fields.  :-)

I spotted a typo here:

+(define-record-type* <patchwork-configuration>
+  patchwork-configuration make-patchwork-configuration
+  patckwork-configuration?
      ^^

Regarding =E2=80=98patchwork-setup-gexp=E2=80=99, I wonder if you could use
=E2=80=98make-forkexec-constructor=E2=80=99 with the appropriate environmen=
t variables
and move the =E2=80=9Ccreateuser=E2=80=9D bit to an activation snippet.

Hmm maybe the activation snippet would run too early, right?  In that
case, perhaps you could create another Shepherd service,
=E2=80=98patchwork-initialization=E2=80=99, that would do the createuser st=
uff, and have
=E2=80=98patchwork=E2=80=99 depend on it.

Thoughts?

Thanks, Chris!

Ludo=E2=80=99.